Commit 060cac3e authored by Arunoda Susiripala's avatar Arunoda Susiripala Committed by Guillermo Rauch

Move all the modules used in 1/2 of all pages into the common chunks. (#1659)

parent 0007cd2a
...@@ -36,7 +36,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false, ...@@ -36,7 +36,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
const mainJS = dev const mainJS = dev
? require.resolve('../../client/next-dev') : require.resolve('../../client/next') ? require.resolve('../../client/next-dev') : require.resolve('../../client/next')
let minChunks let totalPages
const entry = async () => { const entry = async () => {
const entries = { const entries = {
...@@ -68,8 +68,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false, ...@@ -68,8 +68,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
} }
} }
// calculate minChunks of CommonsChunkPlugin for later use totalPages = pages.filter((p) => p !== documentPage).length
minChunks = Math.max(2, pages.filter((p) => p !== documentPage).length)
return entries return entries
} }
...@@ -101,9 +100,8 @@ export default async function createCompiler (dir, { dev = false, quiet = false, ...@@ -101,9 +100,8 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
return module.context && module.context.indexOf('node_modules') >= 0 return module.context && module.context.indexOf('node_modules') >= 0
} }
// NOTE: it depends on the fact that the entry funtion is always called // Move modules used in at-least 1/2 of the total pages into commons.
// before applying CommonsChunkPlugin return count >= totalPages * 0.5
return count >= minChunks
} }
}), }),
// This chunk contains all the webpack related code. So, all the changes // This chunk contains all the webpack related code. So, all the changes
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment