Unverified Commit 08cd0e6e authored by Sebastian "Sebbie" Silbermann's avatar Sebastian "Sebbie" Silbermann Committed by GitHub

Improve type coverage of setup-dev-bundler (#71443)

parent 5bdf9154
...@@ -113,7 +113,7 @@ export async function createOriginalStackFrame({ ...@@ -113,7 +113,7 @@ export async function createOriginalStackFrame({
rootDirectory: string rootDirectory: string
frame: StackFrame frame: StackFrame
errorMessage?: string errorMessage?: string
}): Promise<OriginalStackFrameResponse | undefined> { }): Promise<OriginalStackFrameResponse | null> {
const { lineNumber, column } = frame const { lineNumber, column } = frame
const moduleNotFound = findModuleNotFoundFromError(errorMessage) const moduleNotFound = findModuleNotFoundFromError(errorMessage)
const result = await (async () => { const result = await (async () => {
...@@ -136,7 +136,7 @@ export async function createOriginalStackFrame({ ...@@ -136,7 +136,7 @@ export async function createOriginalStackFrame({
})() })()
if (!result?.sourcePosition.source) { if (!result?.sourcePosition.source) {
return undefined return null
} }
const { sourcePosition, sourceContent } = result const { sourcePosition, sourceContent } = result
......
...@@ -74,6 +74,7 @@ import { ...@@ -74,6 +74,7 @@ import {
batchedTraceSource, batchedTraceSource,
createOriginalStackFrame as createOriginalTurboStackFrame, createOriginalStackFrame as createOriginalTurboStackFrame,
} from '../../../client/components/react-dev-overlay/server/middleware-turbopack' } from '../../../client/components/react-dev-overlay/server/middleware-turbopack'
import type { OriginalStackFrameResponse } from '../../../client/components/react-dev-overlay/server/shared'
import { devPageFiles } from '../../../build/webpack/plugins/next-types-plugin/shared' import { devPageFiles } from '../../../build/webpack/plugins/next-types-plugin/shared'
import type { LazyRenderServerInstance } from '../router-server' import type { LazyRenderServerInstance } from '../router-server'
import { HMR_ACTIONS_SENT_TO_BROWSER } from '../../dev/hot-reloader-types' import { HMR_ACTIONS_SENT_TO_BROWSER } from '../../dev/hot-reloader-types'
...@@ -1003,7 +1004,8 @@ async function startWatcher(opts: SetupOpts) { ...@@ -1003,7 +1004,8 @@ async function startWatcher(opts: SetupOpts) {
!file?.includes('<anonymous>') !file?.includes('<anonymous>')
) )
let originalFrame, isEdgeCompiler let originalFrame: OriginalStackFrameResponse | null = null
let isEdgeCompiler = false
const frameFile = frame?.file const frameFile = frame?.file
if (frame?.lineNumber && frameFile) { if (frame?.lineNumber && frameFile) {
if (hotReloader.turbopackProject) { if (hotReloader.turbopackProject) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment