Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
08d270cd
Unverified
Commit
08d270cd
authored
Dec 07, 2022
by
Jan Kaifer
Committed by
GitHub
Dec 07, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add tests for rendering null and undefined in RSC (#43768)
parent
738de016
Show whitespace changes
Inline
Side-by-side
Showing
13 changed files
with
73 additions
and
0 deletions
+73
-0
rsc-basic.test.ts
test/e2e/app-dir/rsc-basic.test.ts
+39
-0
component.js
.../app-dir/rsc-basic/app/return-null/component/component.js
+3
-0
page.js
test/e2e/app-dir/rsc-basic/app/return-null/component/page.js
+5
-0
layout.js
test/e2e/app-dir/rsc-basic/app/return-null/layout.js
+3
-0
layout.js
test/e2e/app-dir/rsc-basic/app/return-null/layout/layout.js
+3
-0
page.js
test/e2e/app-dir/rsc-basic/app/return-null/layout/page.js
+3
-0
page.js
test/e2e/app-dir/rsc-basic/app/return-null/page/page.js
+3
-0
component.js
...dir/rsc-basic/app/return-undefined/component/component.js
+1
-0
page.js
.../app-dir/rsc-basic/app/return-undefined/component/page.js
+5
-0
layout.js
test/e2e/app-dir/rsc-basic/app/return-undefined/layout.js
+3
-0
layout.js
...e/app-dir/rsc-basic/app/return-undefined/layout/layout.js
+1
-0
page.js
...e2e/app-dir/rsc-basic/app/return-undefined/layout/page.js
+3
-0
page.js
test/e2e/app-dir/rsc-basic/app/return-undefined/page/page.js
+1
-0
No files found.
test/e2e/app-dir/rsc-basic.test.ts
View file @
08d270cd
...
@@ -64,6 +64,45 @@ describe('app dir - rsc basics', () => {
...
@@ -64,6 +64,45 @@ describe('app dir - rsc basics', () => {
return
return
}
}
it
(
'should correctly render page returning null'
,
async
()
=>
{
const
homeHTML
=
await
renderViaHTTP
(
next
.
url
,
'/return-null/page'
)
const
$
=
cheerio
.
load
(
homeHTML
)
expect
(
$
(
'#return-null-layout'
).
html
()).
toBeEmpty
()
})
it
(
'should correctly render component returning null'
,
async
()
=>
{
const
homeHTML
=
await
renderViaHTTP
(
next
.
url
,
'/return-null/component'
)
const
$
=
cheerio
.
load
(
homeHTML
)
expect
(
$
(
'#return-null-layout'
).
html
()).
toBeEmpty
()
})
it
(
'should correctly render layout returning null'
,
async
()
=>
{
const
homeHTML
=
await
renderViaHTTP
(
next
.
url
,
'/return-null/layout'
)
const
$
=
cheerio
.
load
(
homeHTML
)
expect
(
$
(
'#return-null-layout'
).
html
()).
toBeEmpty
()
})
it
(
'should correctly render page returning undefined'
,
async
()
=>
{
const
homeHTML
=
await
renderViaHTTP
(
next
.
url
,
'/return-undefined/page'
)
const
$
=
cheerio
.
load
(
homeHTML
)
expect
(
$
(
'#return-undefined-layout'
).
html
()).
toBeEmpty
()
})
it
(
'should correctly render component returning undefined'
,
async
()
=>
{
const
homeHTML
=
await
renderViaHTTP
(
next
.
url
,
'/return-undefined/component'
)
const
$
=
cheerio
.
load
(
homeHTML
)
expect
(
$
(
'#return-undefined-layout'
).
html
()).
toBeEmpty
()
})
it
(
'should correctly render layout returning undefined'
,
async
()
=>
{
const
homeHTML
=
await
renderViaHTTP
(
next
.
url
,
'/return-undefined/layout'
)
const
$
=
cheerio
.
load
(
homeHTML
)
expect
(
$
(
'#return-undefined-layout'
).
html
()).
toBeEmpty
()
})
it
(
'should render server components correctly'
,
async
()
=>
{
it
(
'should render server components correctly'
,
async
()
=>
{
const
homeHTML
=
await
renderViaHTTP
(
next
.
url
,
'/'
,
null
,
{
const
homeHTML
=
await
renderViaHTTP
(
next
.
url
,
'/'
,
null
,
{
headers
:
{
headers
:
{
...
...
test/e2e/app-dir/rsc-basic/app/return-null/component/component.js
0 → 100644
View file @
08d270cd
export
default
function
Component
()
{
return
null
}
test/e2e/app-dir/rsc-basic/app/return-null/component/page.js
0 → 100644
View file @
08d270cd
import
Component
from
'./component'
export
default
function
Page
()
{
return
<
Component
/>
}
test/e2e/app-dir/rsc-basic/app/return-null/layout.js
0 → 100644
View file @
08d270cd
export
default
function
Layout
({
children
})
{
return
<
div
id
=
"return-null-layout"
>
{
children
}
<
/div
>
}
test/e2e/app-dir/rsc-basic/app/return-null/layout/layout.js
0 → 100644
View file @
08d270cd
export
default
function
Layout
()
{
return
null
}
test/e2e/app-dir/rsc-basic/app/return-null/layout/page.js
0 → 100644
View file @
08d270cd
export
default
function
Page
()
{
return
<
div
/>
}
test/e2e/app-dir/rsc-basic/app/return-null/page/page.js
0 → 100644
View file @
08d270cd
export
default
function
Page
()
{
return
null
}
test/e2e/app-dir/rsc-basic/app/return-undefined/component/component.js
0 → 100644
View file @
08d270cd
export
default
function
Component
()
{}
test/e2e/app-dir/rsc-basic/app/return-undefined/component/page.js
0 → 100644
View file @
08d270cd
import
Component
from
'./component'
export
default
function
Page
()
{
return
<
Component
/>
}
test/e2e/app-dir/rsc-basic/app/return-undefined/layout.js
0 → 100644
View file @
08d270cd
export
default
function
Layout
({
children
})
{
return
<
div
id
=
"return-undefined-layout"
>
{
children
}
<
/div
>
}
test/e2e/app-dir/rsc-basic/app/return-undefined/layout/layout.js
0 → 100644
View file @
08d270cd
export
default
function
Layout
()
{}
test/e2e/app-dir/rsc-basic/app/return-undefined/layout/page.js
0 → 100644
View file @
08d270cd
export
default
function
Page
()
{
return
<
div
/>
}
test/e2e/app-dir/rsc-basic/app/return-undefined/page/page.js
0 → 100644
View file @
08d270cd
export
default
function
Page
()
{}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment