Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
0d4e0e52
Commit
0d4e0e52
authored
Jun 09, 2017
by
Arunoda Susiripala
Committed by
GitHub
Jun 09, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Implement the correct browser behavior for hash changes. (#2223)
parent
28b40a5d
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
2 deletions
+11
-2
router.js
lib/router/router.js
+11
-2
No files found.
lib/router/router.js
View file @
0d4e0e52
...
@@ -132,9 +132,10 @@ export default class Router {
...
@@ -132,9 +132,10 @@ export default class Router {
const
{
pathname
,
query
}
=
parse
(
url
,
true
)
const
{
pathname
,
query
}
=
parse
(
url
,
true
)
// If the url change is only related to a hash change
// If the url change is only related to a hash change
// We should not proceed. We should only
replac
e the state.
// We should not proceed. We should only
chang
e the state.
if
(
this
.
onlyAHashChange
(
as
))
{
if
(
this
.
onlyAHashChange
(
as
))
{
this
.
changeState
(
'replaceState'
,
url
,
as
)
this
.
changeState
(
method
,
url
,
as
)
this
.
scrollToHash
(
as
)
return
return
}
}
...
@@ -261,6 +262,14 @@ export default class Router {
...
@@ -261,6 +262,14 @@ export default class Router {
return
true
return
true
}
}
scrollToHash
(
as
)
{
const
[
,
hash
]
=
as
.
split
(
'#'
)
const
el
=
document
.
getElementById
(
hash
)
if
(
el
)
{
el
.
scrollIntoView
()
}
}
urlIsNew
(
pathname
,
query
)
{
urlIsNew
(
pathname
,
query
)
{
return
this
.
pathname
!==
pathname
||
!
shallowEquals
(
query
,
this
.
query
)
return
this
.
pathname
!==
pathname
||
!
shallowEquals
(
query
,
this
.
query
)
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment