Unverified Commit 19f3306a authored by Darsh Patel's avatar Darsh Patel Committed by GitHub

open click-to-open editor in foreground for windows (#14307)

spent a lot of hours trying to figure out why did the editor window not open in the foreground on windows.

The fix was super simple  : /
Needed to add `detached: true` option in child_process.spawn call

Fixes: https://github.com/vercel/next.js/issues/14016
parent eead55cb
...@@ -399,6 +399,7 @@ function launchEditor(fileName: string, lineNumber: number, colNumber: number) { ...@@ -399,6 +399,7 @@ function launchEditor(fileName: string, lineNumber: number, colNumber: number) {
// launch .exe files. // launch .exe files.
p = child_process.spawn('cmd.exe', ['/C', editor].concat(args), { p = child_process.spawn('cmd.exe', ['/C', editor].concat(args), {
stdio: 'inherit', stdio: 'inherit',
detached: true,
}) })
} else if (isTerminalEditor(editor)) { } else if (isTerminalEditor(editor)) {
if (process.platform === 'darwin') { if (process.platform === 'darwin') {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment