Unverified Commit 1f9e958e authored by Jamie's avatar Jamie Committed by GitHub

Follow up rewrites regression test for #25208 (#25282)



## Summary

Follow up regression test for rewrites with a `has` condition throwing errors in older browsers  #25208.

@timneutkens Let me know if this is what you had in mind? 😸 
parent 14cedc75
...@@ -86,7 +86,7 @@ stages: ...@@ -86,7 +86,7 @@ stages:
path: $(System.DefaultWorkingDirectory) path: $(System.DefaultWorkingDirectory)
displayName: Cache Build displayName: Cache Build
- script: | - script: |
yarn testie --forceExit test/integration/production/ test/integration/css-client-nav/ yarn testie --forceExit test/integration/production/ test/integration/css-client-nav/ test/integration/rewrites-has-condition/
displayName: 'Run tests' displayName: 'Run tests'
- job: test_unit - job: test_unit
......
module.exports = {
rewrites() {
return [
{
source: '/rewrite-simple',
destination: '/another',
},
{
source: '/rewrite-with-has',
has: [
{
type: 'query',
key: 'hasQuery',
},
],
destination: '/another',
},
]
},
}
import { useRouter } from 'next/router'
export default function Page() {
const router = useRouter()
return (
<>
<p id="another">another page</p>
<p id="pathname">{router.pathname}</p>
<p id="query">{JSON.stringify(router.query)}</p>
</>
)
}
/* eslint-env jest */
import { join } from 'path'
import {
findPort,
killApp,
launchApp,
nextBuild,
nextStart,
} from 'next-test-utils'
import webdriver from 'next-webdriver'
jest.setTimeout(1000 * 60 * 2)
const appDir = join(__dirname, '../')
let appPort
let app
const runTests = () => {
it('should load page rewrite without browser errors', async () => {
const browser = await webdriver(appPort, '/rewrite-simple')
expect(await browser.waitForElementByCss('#another').text()).toBe(
'another page'
)
const browserLogs = await browser.log('browser')
const errorLogs = browserLogs.filter((log) => {
return log.level.name === 'SEVERE' && log.message.includes('Error:')
})
expect(errorLogs).toEqual([])
})
// Regression test for https://github.com/vercel/next.js/issues/25207
it('should load page rewrite, with "has" condition, without browser errors', async () => {
const browser = await webdriver(appPort, '/rewrite-with-has?hasQuery=123')
expect(await browser.waitForElementByCss('#another').text()).toBe(
'another page'
)
const browserLogs = await browser.log('browser')
const errorLogs = browserLogs.filter((log) => {
return log.level.name === 'SEVERE' && log.message.includes('Error:')
})
expect(errorLogs).toEqual([])
})
}
describe('rewrites has condition', () => {
describe('dev mode', () => {
beforeAll(async () => {
appPort = await findPort()
app = await launchApp(appDir, appPort)
})
afterAll(() => killApp(app))
runTests()
})
describe('production mode', () => {
beforeAll(async () => {
await nextBuild(appDir)
appPort = await findPort()
app = await nextStart(appDir, appPort)
})
afterAll(() => killApp(app))
runTests()
})
})
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment