Unverified Commit 2036a5b1 authored by Hendrik Liebau's avatar Hendrik Liebau Committed by GitHub

[Cache Components] Avoid cache misses when resuming a cached page (#82578)

When a page component (or a parallel route slot) is cached, but other
parts of the component tree are dynamic, we generate a partially static
shell at buildtime that's resumed at runtime. During the resume, we need
to ensure that the cache key is the same as during prerendering. This is
currently not the case because we automatically include the (unused)
`searchParams` prop in the cache key. Its value is a hanging promise
during prerendering, and a resolving promise at runtime, leading to a
cache miss when looking up the cached page data in the Resume Data Cache
(RDC). Subsequently, hydration errors might occur when the recomputed
result is different than the prerendered result.

Since search params are not allowed to be read in public cache scopes
anyways, we can pass erroring search params into the cached page,
instead of using a hanging promise, and omit them from the generated
cache key. We already used this technique when `cacheComponents` is not
enabled.

closes NAR-87
parent 3d5e456a
...@@ -776,5 +776,6 @@ ...@@ -776,5 +776,6 @@
"775": "Node.js instrumentation extensions should not be loaded in the Edge runtime.", "775": "Node.js instrumentation extensions should not be loaded in the Edge runtime.",
"776": "`unstable_isUnrecognizedActionError` can only be used on the client.", "776": "`unstable_isUnrecognizedActionError` can only be used on the client.",
"777": "Invariant: failed to find source route %s for prerender %s", "777": "Invariant: failed to find source route %s for prerender %s",
"778": "`prerenderAndAbortInSequentialTasksWithStages` should not be called in edge runtime." "778": "`prerenderAndAbortInSequentialTasksWithStages` should not be called in edge runtime.",
"779": "Route %s used \"searchParams\" inside \"use cache\". Accessing dynamic request data inside a cache scope is not supported. If you need some search params inside a cached function await \"searchParams\" outside of the cached function and pass only the required search params as arguments to the cached function. See more info here: https://nextjs.org/docs/messages/next-request-in-use-cache"
} }
...@@ -460,7 +460,7 @@ function makeErroringExoticSearchParams( ...@@ -460,7 +460,7 @@ function makeErroringExoticSearchParams(
* error on access, because accessing searchParams inside of `"use cache"` is * error on access, because accessing searchParams inside of `"use cache"` is
* not allowed. * not allowed.
*/ */
export function makeErroringExoticSearchParamsForUseCache( export function makeErroringSearchParamsForUseCache(
workStore: WorkStore workStore: WorkStore
): Promise<SearchParams> { ): Promise<SearchParams> {
const cachedSearchParams = CachedSearchParamsForUseCache.get(workStore) const cachedSearchParams = CachedSearchParamsForUseCache.get(workStore)
......
...@@ -25,7 +25,7 @@ export function throwForSearchParamsAccessInUseCache( ...@@ -25,7 +25,7 @@ export function throwForSearchParamsAccessInUseCache(
constructorOpt: Function constructorOpt: Function
): never { ): never {
const error = new Error( const error = new Error(
`Route ${workStore.route} used "searchParams" inside "use cache". Accessing Dynamic data sources inside a cache scope is not supported. If you need this data inside a cached function use "searchParams" outside of the cached function and pass the required dynamic data in as an argument. See more info here: https://nextjs.org/docs/messages/next-request-in-use-cache` `Route ${workStore.route} used "searchParams" inside "use cache". Accessing dynamic request data inside a cache scope is not supported. If you need some search params inside a cached function await "searchParams" outside of the cached function and pass only the required search params as arguments to the cached function. See more info here: https://nextjs.org/docs/messages/next-request-in-use-cache`
) )
Error.captureStackTrace(error, constructorOpt) Error.captureStackTrace(error, constructorOpt)
......
...@@ -59,7 +59,7 @@ import { ...@@ -59,7 +59,7 @@ import {
throwToInterruptStaticGeneration, throwToInterruptStaticGeneration,
} from '../app-render/dynamic-rendering' } from '../app-render/dynamic-rendering'
import { import {
makeErroringExoticSearchParamsForUseCache, makeErroringSearchParamsForUseCache,
type SearchParams, type SearchParams,
} from '../request/search-params' } from '../request/search-params'
import type { Params } from '../request/params' import type { Params } from '../request/params'
...@@ -91,6 +91,11 @@ type CacheKeyParts = ...@@ -91,6 +91,11 @@ type CacheKeyParts =
| [buildId: string, id: string, args: unknown[]] | [buildId: string, id: string, args: unknown[]]
| [buildId: string, id: string, args: unknown[], hmrRefreshHash: string] | [buildId: string, id: string, args: unknown[], hmrRefreshHash: string]
interface UseCacheInnerPageComponentProps {
params: Promise<Params>
searchParams?: Promise<SearchParams>
}
export interface UseCachePageComponentProps { export interface UseCachePageComponentProps {
params: Promise<Params> params: Promise<Params>
searchParams: Promise<SearchParams> searchParams: Promise<SearchParams>
...@@ -981,37 +986,38 @@ export function cache( ...@@ -981,37 +986,38 @@ export function cache(
isPageOrLayout = true isPageOrLayout = true
const [{ params: outerParams, searchParams: outerSearchParams }] = args const [{ params: outerParams, searchParams: outerSearchParams }] = args
const keepSearchParams = workStore.cacheComponentsEnabled || isPrivate
args = [ const props: UseCacheInnerPageComponentProps = {
{
params: outerParams, params: outerParams,
searchParams: keepSearchParams // Omit searchParams and $$isPageComponent.
? outerSearchParams }
: Promise.resolve({}),
// omit $$isPageComponent. if (isPrivate) {
}, // Private caches allow accessing search params. We need to include
] // them in the serialized args and when generating the cache key.
props.searchParams = outerSearchParams
}
args = [props]
fn = { fn = {
[name]: async ({ [name]: async ({
params: _innerParams, params: _innerParams,
searchParams: innerSearchParams, searchParams: innerSearchParams,
}: Omit<UseCachePageComponentProps, '$$isPageComponent'>) => }: UseCacheInnerPageComponentProps) =>
originalFn.apply(null, [ originalFn.apply(null, [
{ {
params: outerParams, params: outerParams,
searchParams: keepSearchParams searchParams:
? innerSearchParams innerSearchParams ??
: // When cacheComponents is not enabled, we can not encode // For public caches, search params are omitted from the cache
// searchParams as a hanging promise. To still avoid unused // key (and the serialized args) to avoid mismatches between
// search params from making a page dynamic, we define them // prerendering and resuming a cached page that does not
// as a promise that resolves to an empty object above. And // access search params. This is also the reason why we're not
// here, we're creating an erroring searchParams prop, when // using a hanging promise for search params. For cached pages
// invoking the original function. This ensures that used // that do access them, which is an invalid dynamic usage, we
// searchParams inside of cached functions would still yield // need to ensure that an error is shown.
// an error. makeErroringSearchParamsForUseCache(workStore),
makeErroringExoticSearchParamsForUseCache(workStore),
}, },
]), ]),
}[name] as (...args: unknown[]) => Promise<unknown> }[name] as (...args: unknown[]) => Promise<unknown>
......
...@@ -276,7 +276,6 @@ ...@@ -276,7 +276,6 @@
"test/e2e/app-dir/use-cache-metadata-route-handler/**/*", "test/e2e/app-dir/use-cache-metadata-route-handler/**/*",
"test/e2e/app-dir/use-cache-route-handler-only/**/*", "test/e2e/app-dir/use-cache-route-handler-only/**/*",
"test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts", "test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts",
"test/e2e/app-dir/use-cache-standalone-search-params/use-cache-standalone-search-params.test.ts",
"test/e2e/app-dir/use-cache-without-experimental-flag/use-cache-without-experimental-flag.test.ts", "test/e2e/app-dir/use-cache-without-experimental-flag/use-cache-without-experimental-flag.test.ts",
"test/e2e/app-dir/use-params/use-params.test.ts", "test/e2e/app-dir/use-params/use-params.test.ts",
"test/e2e/app-dir/use-selected-layout-segment-s/use-selected-layout-segment-s.test.ts", "test/e2e/app-dir/use-selected-layout-segment-s/use-selected-layout-segment-s.test.ts",
......
async function getSearchParam({
searchParams,
}: {
searchParams: Promise<{ n: string }>
}): Promise<string> {
'use cache'
return (await searchParams).n
}
export default async function Page({
searchParams,
}: {
searchParams: Promise<{ n: string }>
}) {
let searchParam: string | undefined
try {
searchParam = await getSearchParam({ searchParams })
} catch {
// Ignore not having access to searchParams. This is still an invalid
// dynamic access though that we need to detect.
}
return (
<p>{searchParam ? `search param: ${searchParam}` : 'no search param'}</p>
)
}
'use cache'
export default async function Page({
searchParams,
}: {
searchParams: Promise<{ n: string }>
}) {
return <p>search params not used</p>
}
'use cache'
export default async function Page({
searchParams,
}: {
searchParams: Promise<{ n: string }>
}) {
const { n } = await searchParams
return <p>search param: {n}</p>
}
...@@ -7,7 +7,6 @@ import { ...@@ -7,7 +7,6 @@ import {
assertHasRedbox, assertHasRedbox,
getRedboxTitle, getRedboxTitle,
getRedboxTotalErrorCount, getRedboxTotalErrorCount,
assertNoRedbox,
} from 'next-test-utils' } from 'next-test-utils'
import stripAnsi from 'strip-ansi' import stripAnsi from 'strip-ansi'
...@@ -26,123 +25,6 @@ describe('use-cache-hanging-inputs', () => { ...@@ -26,123 +25,6 @@ describe('use-cache-hanging-inputs', () => {
} }
if (isNextDev) { if (isNextDev) {
describe('when searchParams are used inside of "use cache"', () => {
it('should show an error toast after a timeout', async () => {
const outputIndex = next.cliOutput.length
const browser = await next.browser('/search-params?n=1')
// The request is pending while we stall on the hanging inputs, and
// playwright will wait for the load event before continuing. So we
// don't need to wait for the "use cache" timeout of 50 seconds here.
await openRedbox(browser)
const errorCount = await getRedboxTotalErrorCount(browser)
const errorDescription = await getRedboxDescription(browser)
const errorSource = await getRedboxSource(browser)
expect(errorCount).toBe(1)
expect(errorDescription).toBe(expectedTimeoutErrorMessage)
const cliOutput = stripAnsi(next.cliOutput.slice(outputIndex))
if (isTurbopack) {
expect(errorSource).toMatchInlineSnapshot(`
"app/search-params/page.tsx (3:16) @ {module evaluation}
1 | 'use cache'
2 |
> 3 | export default async function Page({
| ^
4 | searchParams,
5 | }: {
6 | searchParams: Promise<{ n: string }>"
`)
expect(cliOutput).toContain(`Error: ${expectedTimeoutErrorMessage}
at __TURBOPACK__module__evaluation__`)
} else {
expect(errorSource).toMatchInlineSnapshot(`
"app/search-params/page.tsx (3:16) @ eval
1 | 'use cache'
2 |
> 3 | export default async function Page({
| ^
4 | searchParams,
5 | }: {
6 | searchParams: Promise<{ n: string }>"
`)
expect(cliOutput).toContain(`Error: ${expectedTimeoutErrorMessage}
at eval (app/search-params/page.tsx:3:16)`)
}
}, 180_000)
})
describe('when searchParams are used inside of "use cache", wrapped in try/catch', () => {
it('should show an error toast after a timeout', async () => {
const outputIndex = next.cliOutput.length
const browser = await next.browser('/search-params-caught?n=1')
// The request is pending while we stall on the hanging inputs, and
// playwright will wait for the load event before continuing. So we
// don't need to wait for the "use cache" timeout of 50 seconds here.
await openRedbox(browser)
const errorCount = await getRedboxTotalErrorCount(browser)
const errorDescription = await getRedboxDescription(browser)
const errorSource = await getRedboxSource(browser)
expect(errorCount).toBe(1)
expect(errorDescription).toBe(expectedTimeoutErrorMessage)
const cliOutput = stripAnsi(next.cliOutput.slice(outputIndex))
if (isTurbopack) {
expect(errorSource).toMatchInlineSnapshot(`
"app/search-params-caught/page.tsx (1:1) @ {module evaluation}
> 1 | async function getSearchParam({
| ^
2 | searchParams,
3 | }: {
4 | searchParams: Promise<{ n: string }>"
`)
expect(cliOutput).toContain(`Error: ${expectedTimeoutErrorMessage}
at __TURBOPACK__module__evaluation__`)
} else {
expect(errorSource).toMatchInlineSnapshot(`
"app/search-params-caught/page.tsx (1:1) @ eval
> 1 | async function getSearchParam({
| ^
2 | searchParams,
3 | }: {
4 | searchParams: Promise<{ n: string }>"
`)
expect(cliOutput).toContain(`Error: ${expectedTimeoutErrorMessage}
at eval (app/search-params-caught/page.tsx:1:1)`)
}
}, 180_000)
})
describe('when searchParams are unused inside of "use cache"', () => {
it('should not show an error', async () => {
const outputIndex = next.cliOutput.length
const browser = await next.browser('/search-params-unused?n=1')
await assertNoRedbox(browser)
const cliOutput = stripAnsi(next.cliOutput.slice(outputIndex))
expect(cliOutput).not.toContain(`Error: ${expectedTimeoutErrorMessage}`)
})
})
describe('when an uncached promise is used inside of "use cache"', () => { describe('when an uncached promise is used inside of "use cache"', () => {
it('should show an error toast after a timeout', async () => { it('should show an error toast after a timeout', async () => {
const outputIndex = next.cliOutput.length const outputIndex = next.cliOutput.length
...@@ -333,21 +215,13 @@ describe('use-cache-hanging-inputs', () => { ...@@ -333,21 +215,13 @@ describe('use-cache-hanging-inputs', () => {
expect(cliOutput).toIncludeRepeated( expect(cliOutput).toIncludeRepeated(
escapeStringRegexp(expectedTimeoutErrorMessage), escapeStringRegexp(expectedTimeoutErrorMessage),
6 4
) )
expect(cliOutput).toInclude( expect(cliOutput).toInclude(
createExpectedBuildErrorMessage('/bound-args') createExpectedBuildErrorMessage('/bound-args')
) )
expect(cliOutput).toInclude(
createExpectedBuildErrorMessage('/search-params')
)
expect(cliOutput).toInclude(
createExpectedBuildErrorMessage('/search-params-caught')
)
expect(cliOutput).toInclude( expect(cliOutput).toInclude(
createExpectedBuildErrorMessage('/transformed-params/[slug]') createExpectedBuildErrorMessage('/transformed-params/[slug]')
) )
......
import { connection } from 'next/server'
import { ReactNode, Suspense } from 'react'
export default function Root({ children }: { children: ReactNode }) {
return (
<html>
<body>
<Suspense fallback={<p>Loading...</p>}>
<Dynamic />
</Suspense>
{children}
</body>
</html>
)
}
async function Dynamic() {
await connection()
return (
<p>
Layout: <span id="layout-date">{new Date().toISOString()}</span>
</p>
)
}
...@@ -5,5 +5,9 @@ export default async function Page({ ...@@ -5,5 +5,9 @@ export default async function Page({
}: { }: {
searchParams: Promise<{ [key: string]: string | string[] | undefined }> searchParams: Promise<{ [key: string]: string | string[] | undefined }>
}) { }) {
return <p>hello world</p> return (
<p>
Page: <span id="page-date">{new Date().toISOString()}</span>
</p>
)
} }
import { nextTestSetup } from 'e2e-utils' import { nextTestSetup } from 'e2e-utils'
import { import {
assertHasRedbox, assertHasRedbox,
assertNoConsoleErrors,
assertNoRedbox, assertNoRedbox,
getRedboxDescription, getRedboxDescription,
getRedboxSource, getRedboxSource,
...@@ -8,9 +9,9 @@ import { ...@@ -8,9 +9,9 @@ import {
import stripAnsi from 'strip-ansi' import stripAnsi from 'strip-ansi'
const getExpectedErrorMessage = (route: string) => const getExpectedErrorMessage = (route: string) =>
`Route ${route} used "searchParams" inside "use cache". Accessing Dynamic data sources inside a cache scope is not supported. If you need this data inside a cached function use "searchParams" outside of the cached function and pass the required dynamic data in as an argument. See more info here: https://nextjs.org/docs/messages/next-request-in-use-cache` `Route ${route} used "searchParams" inside "use cache". Accessing dynamic request data inside a cache scope is not supported. If you need some search params inside a cached function await "searchParams" outside of the cached function and pass only the required search params as arguments to the cached function. See more info here: https://nextjs.org/docs/messages/next-request-in-use-cache`
describe('use-cache-standalone-search-params', () => { describe('use-cache-search-params', () => {
const { next, isNextDev, skipped } = nextTestSetup({ const { next, isNextDev, skipped } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true, skipDeployment: true,
...@@ -128,6 +129,10 @@ describe('use-cache-standalone-search-params', () => { ...@@ -128,6 +129,10 @@ describe('use-cache-standalone-search-params', () => {
}) })
}) })
} else { } else {
afterEach(async () => {
await next.stop()
})
it('should fail the build with errors', async () => { it('should fail the build with errors', async () => {
const { cliOutput } = await next.build() const { cliOutput } = await next.build()
...@@ -147,9 +152,49 @@ describe('use-cache-standalone-search-params', () => { ...@@ -147,9 +152,49 @@ describe('use-cache-standalone-search-params', () => {
'Error occurred prerendering page "/search-params-used"' 'Error occurred prerendering page "/search-params-used"'
) )
expect(cliOutput).toInclude(
'Error occurred prerendering page "/search-params-caught"'
)
expect(cliOutput).not.toInclude( expect(cliOutput).not.toInclude(
'Error occurred prerendering page "/search-params-unused"' 'Error occurred prerendering page "/search-params-unused"'
) )
}) })
it('should resume a cached page that does not access search params without hydration errors', async () => {
await next.build({
env: {
NEXT_PRIVATE_APP_PATHS: JSON.stringify([
'/search-params-unused/page.tsx',
]),
},
})
await next.start({ skipBuild: true })
let browser = await next.browser('/search-params-unused', {
disableJavaScript: true,
})
const prerenderedPageDate = await browser.elementById('page-date').text()
await browser.close()
browser = await next.browser('/search-params-unused', {
pushErrorAsConsoleLog: true,
})
// After hydration, the resumed page date should be the prerendered date.
// Note: When cacheComponents is not enabled, the page is not actually
// prerendered, but because the page is cached on the first page load, the
// date should still be the same for the second page load.
expect(await browser.elementById('page-date').text()).toBe(
prerenderedPageDate
)
// There should also be no hydration errors due to a buildtime date being
// replaced by a new runtime date.
await assertNoConsoleErrors(browser)
})
} }
}) })
import { ReactNode } from 'react'
export default function Root({ children }: { children: ReactNode }) {
return (
<html>
<body>{children}</body>
</html>
)
}
...@@ -6492,18 +6492,16 @@ ...@@ -6492,18 +6492,16 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts": { "test/e2e/app-dir/use-cache-search-params/use-cache-search-params.test.ts": {
"passed": [ "passed": ["use-cache-search-params should fail the build with errors"],
"use-cache-segment-configs it should error when using segment configs that aren't supported by useCache"
],
"failed": [], "failed": [],
"pending": [], "pending": [],
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/use-cache-standalone-search-params/use-cache-standalone-search-params.test.ts": { "test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts": {
"passed": [ "passed": [
"use-cache-standalone-search-params should fail the build with errors" "use-cache-segment-configs it should error when using segment configs that aren't supported by useCache"
], ],
"failed": [], "failed": [],
"pending": [], "pending": [],
...@@ -10298,23 +10298,23 @@ ...@@ -10298,23 +10298,23 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts": { "test/e2e/app-dir/use-cache-search-params/use-cache-search-params.test.ts": {
"passed": [], "passed": [
"use-cache-search-params when searchParams are caught inside of \"use cache\" should also show an error after the second reload",
"use-cache-search-params when searchParams are caught inside of \"use cache\" should show an error",
"use-cache-search-params when searchParams are unused inside of \"use cache\" should not show an error"
],
"failed": [ "failed": [
"use-cache-segment-configs it should error when using segment configs that aren't supported by useCache" "use-cache-search-params when searchParams are used inside of \"use cache\" should show an error"
], ],
"pending": [], "pending": [],
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/use-cache-standalone-search-params/use-cache-standalone-search-params.test.ts": { "test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts": {
"passed": [ "passed": [],
"use-cache-standalone-search-params when searchParams are caught inside of \"use cache\" should also show an error after the second reload",
"use-cache-standalone-search-params when searchParams are caught inside of \"use cache\" should show an error",
"use-cache-standalone-search-params when searchParams are unused inside of \"use cache\" should not show an error"
],
"failed": [ "failed": [
"use-cache-standalone-search-params when searchParams are used inside of \"use cache\" should show an error" "use-cache-segment-configs it should error when using segment configs that aren't supported by useCache"
], ],
"pending": [], "pending": [],
"flakey": [], "flakey": [],
...@@ -6065,18 +6065,16 @@ ...@@ -6065,18 +6065,16 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts": { "test/e2e/app-dir/use-cache-search-params/use-cache-search-params.test.ts": {
"passed": [ "passed": ["use-cache-search-params should fail the build with errors"],
"use-cache-segment-configs it should error when using segment configs that aren't supported by useCache"
],
"failed": [], "failed": [],
"pending": [], "pending": [],
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/use-cache-standalone-search-params/use-cache-standalone-search-params.test.ts": { "test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts": {
"passed": [ "passed": [
"use-cache-standalone-search-params should fail the build with errors" "use-cache-segment-configs it should error when using segment configs that aren't supported by useCache"
], ],
"failed": [], "failed": [],
"pending": [], "pending": [],
...@@ -9639,21 +9639,21 @@ ...@@ -9639,21 +9639,21 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts": { "test/e2e/app-dir/use-cache-search-params/use-cache-search-params.test.ts": {
"passed": [ "passed": [
"use-cache-segment-configs it should error when using segment configs that aren't supported by useCache" "use-cache-search-params when searchParams are caught inside of \"use cache\" should also show an error after the second reload",
"use-cache-search-params when searchParams are caught inside of \"use cache\" should show an error",
"use-cache-search-params when searchParams are unused inside of \"use cache\" should not show an error",
"use-cache-search-params when searchParams are used inside of \"use cache\" should show an error"
], ],
"failed": [], "failed": [],
"pending": [], "pending": [],
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/use-cache-standalone-search-params/use-cache-standalone-search-params.test.ts": { "test/e2e/app-dir/use-cache-segment-configs/use-cache-segment-configs.test.ts": {
"passed": [ "passed": [
"use-cache-standalone-search-params when searchParams are caught inside of \"use cache\" should also show an error after the second reload", "use-cache-segment-configs it should error when using segment configs that aren't supported by useCache"
"use-cache-standalone-search-params when searchParams are caught inside of \"use cache\" should show an error",
"use-cache-standalone-search-params when searchParams are unused inside of \"use cache\" should not show an error",
"use-cache-standalone-search-params when searchParams are used inside of \"use cache\" should show an error"
], ],
"failed": [], "failed": [],
"pending": [], "pending": [],
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment