Commit 2555a1aa authored by Evan Kirkiles's avatar Evan Kirkiles Committed by devjiwonchoi

Add missing (duplicate) /500 span to expected test result in `start`

parent 5638da50
...@@ -13,7 +13,7 @@ const EXTERNAL = { ...@@ -13,7 +13,7 @@ const EXTERNAL = {
const COLLECTOR_PORT = 9001 const COLLECTOR_PORT = 9001
describe('opentelemetry', () => { describe('opentelemetry', () => {
const { next, skipped, isNextDev, isNextStart } = nextTestSetup({ const { next, skipped, isNextDev } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true, skipDeployment: true,
dependencies: require('./package.json').dependencies, dependencies: require('./package.json').dependencies,
...@@ -874,6 +874,7 @@ describe('opentelemetry', () => { ...@@ -874,6 +874,7 @@ describe('opentelemetry', () => {
'next.span_name': 'next.span_name':
'GET /pages/[param]/getServerSidePropsError', 'GET /pages/[param]/getServerSidePropsError',
'next.span_type': 'BaseServer.handleRequest', 'next.span_type': 'BaseServer.handleRequest',
'error.type': '500',
}, },
kind: 1, kind: 1,
status: { code: 2 }, status: { code: 2 },
...@@ -887,6 +888,7 @@ describe('opentelemetry', () => { ...@@ -887,6 +888,7 @@ describe('opentelemetry', () => {
'next.span_name': 'next.span_name':
'getServerSideProps /pages/[param]/getServerSidePropsError', 'getServerSideProps /pages/[param]/getServerSidePropsError',
'next.span_type': 'Render.getServerSideProps', 'next.span_type': 'Render.getServerSideProps',
'error.type': 'Error',
}, },
kind: 0, kind: 0,
status: { status: {
...@@ -923,8 +925,9 @@ describe('opentelemetry', () => { ...@@ -923,8 +925,9 @@ describe('opentelemetry', () => {
kind: 0, kind: 0,
status: { code: 0 }, status: { code: 0 },
}, },
...(isNextStart ...(isNextDev
? [ ? []
: [
{ {
name: 'resolve page components', name: 'resolve page components',
attributes: { attributes: {
...@@ -936,8 +939,18 @@ describe('opentelemetry', () => { ...@@ -936,8 +939,18 @@ describe('opentelemetry', () => {
kind: 0, kind: 0,
status: { code: 0 }, status: { code: 0 },
}, },
] {
: []), name: 'resolve page components',
attributes: {
'next.route': '/500',
'next.span_name': 'resolve page components',
'next.span_type':
'NextNodeServer.findPageComponents',
},
kind: 0,
status: { code: 0 },
},
]),
{ {
name: 'resolve page components', name: 'resolve page components',
attributes: { attributes: {
...@@ -990,6 +1003,8 @@ describe('opentelemetry', () => { ...@@ -990,6 +1003,8 @@ describe('opentelemetry', () => {
code: 0, code: 0,
}, },
}, },
...(isNextDev
? [
{ {
name: 'render route (app) /_not-found', name: 'render route (app) /_not-found',
attributes: { attributes: {
...@@ -1000,6 +1015,8 @@ describe('opentelemetry', () => { ...@@ -1000,6 +1015,8 @@ describe('opentelemetry', () => {
kind: 0, kind: 0,
status: { code: 0 }, status: { code: 0 },
}, },
]
: []),
{ {
name: 'resolve page components', name: 'resolve page components',
attributes: { attributes: {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment