Unverified Commit 2bb65cab authored by LuiGeeDev's avatar LuiGeeDev Committed by GitHub

Update a third-parties docs, GoogleTagManager example (#63448)

### What?
If I follow the example in docs then use GTM, it doesn't work when I
send an event in page when mounted using useEffect. It logs a warning:
`@next/third-parties: GTM dataLayer dataLayer does not exist`

### Why?
`window.dataLayer` does not exist when children is rendered, because
children runs faster than GoogleTagManager component. It works in dev
mode, but doesn't work when built, so it can be easily missed.

### How?
It works fine when the order is changed. As you see in example,
GoogleTagManager should come first, higher than children.
parent 203f6a86
...@@ -49,8 +49,8 @@ export default function RootLayout({ ...@@ -49,8 +49,8 @@ export default function RootLayout({
}) { }) {
return ( return (
<html lang="en"> <html lang="en">
<body>{children}</body>
<GoogleTagManager gtmId="GTM-XYZ" /> <GoogleTagManager gtmId="GTM-XYZ" />
<body>{children}</body>
</html> </html>
) )
} }
...@@ -62,8 +62,8 @@ import { GoogleTagManager } from '@next/third-parties/google' ...@@ -62,8 +62,8 @@ import { GoogleTagManager } from '@next/third-parties/google'
export default function RootLayout({ children }) { export default function RootLayout({ children }) {
return ( return (
<html lang="en"> <html lang="en">
<body>{children}</body>
<GoogleTagManager gtmId="GTM-XYZ" /> <GoogleTagManager gtmId="GTM-XYZ" />
<body>{children}</body>
</html> </html>
) )
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment