Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
2d08397b
Unverified
Commit
2d08397b
authored
May 05, 2026
by
Hendrik Liebau
Committed by
GitHub
May 05, 2026
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[backport] fix accidental test duplication (#93507)
parent
75d19ecb
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
250 deletions
+0
-250
next.config.js
test/e2e/rewrite-request-smuggling/next.config.js
+0
-13
index.tsx
test/e2e/rewrite-request-smuggling/pages/index.tsx
+0
-3
rewrite-request-smuggling.test.ts
...write-request-smuggling/rewrite-request-smuggling.test.ts
+0
-234
No files found.
test/e2e/rewrite-request-smuggling/next.config.js
deleted
100644 → 0
View file @
75d19ecb
/** @type {import('next').NextConfig} */
const
nextConfig
=
{
async
rewrites
()
{
return
[
{
source
:
'/rewrites/:path*'
,
destination
:
`http://127.0.0.1:
${
process
.
env
.
TEST_INTERMEDIARY_PORT
}
/rewrites/:path*`
,
},
]
},
}
module
.
exports
=
nextConfig
test/e2e/rewrite-request-smuggling/pages/index.tsx
deleted
100644 → 0
View file @
75d19ecb
export
default
function
Page
()
{
return
<
p
>
hello world
</
p
>
}
test/e2e/rewrite-request-smuggling/rewrite-request-smuggling.test.ts
deleted
100644 → 0
View file @
75d19ecb
import
net
from
'net'
import
http
from
'http'
import
{
createNext
,
NextInstance
}
from
'e2e-utils'
import
{
findPort
,
retry
}
from
'next-test-utils'
describe
(
'rewrite-request-smuggling'
,
()
=>
{
if
((
global
as
any
).
isNextDeploy
)
{
it
(
'should skip deploy'
,
()
=>
{})
return
}
let
backend
:
http
.
Server
let
backendPort
:
number
let
intermediary
:
http
.
Server
let
intermediaryPort
:
number
let
next
:
NextInstance
const
backendRequests
:
string
[]
=
[]
async
function
sendSmugglingPayload
({
nextPort
,
connectionHeader
,
method
=
'DELETE'
,
rewritePath
=
'/rewrites/poc'
,
}:
{
nextPort
:
number
connectionHeader
:
string
method
?:
'DELETE'
|
'OPTIONS'
rewritePath
?:
string
})
{
const
smuggledRequest
=
Buffer
.
from
(
`GET /secret HTTP/1.1\r\nHost: 127.0.0.1:
${
nextPort
}
\r\n\r\n`
,
'latin1'
)
const
chunkSize
=
Buffer
.
from
(
`
${
smuggledRequest
.
length
.
toString
(
16
).
toUpperCase
()}
\r\n`
,
'latin1'
)
const
payload
=
Buffer
.
concat
([
Buffer
.
from
(
`
${
method
}
${
rewritePath
}
HTTP/1.1\r\nHost: 127.0.0.1:
${
nextPort
}
\r\nTransfer-Encoding: chunked\r\nConnection:
${
connectionHeader
}
\r\n\r\n`
,
'latin1'
),
chunkSize
,
smuggledRequest
,
Buffer
.
from
(
'
\
r
\
n0
\
r
\
n
\
r
\
n'
,
'latin1'
),
])
await
new
Promise
<
void
>
((
resolve
,
reject
)
=>
{
const
socket
=
net
.
createConnection
({
host
:
'127.0.0.1'
,
port
:
nextPort
,
})
socket
.
once
(
'connect'
,
()
=>
{
socket
.
write
(
payload
)
})
socket
.
once
(
'error'
,
reject
)
socket
.
setTimeout
(
1000
,
()
=>
socket
.
destroy
())
socket
.
once
(
'close'
,
()
=>
resolve
())
})
}
beforeAll
(
async
()
=>
{
backendPort
=
await
findPort
()
intermediaryPort
=
await
findPort
()
backend
=
http
.
createServer
((
req
,
res
)
=>
{
backendRequests
.
push
(
`
${
req
.
method
}
${
req
.
url
}
`
)
if
(
req
.
url
?.
startsWith
(
'/rewrites/'
))
{
res
.
statusCode
=
200
res
.
end
(
'rewrite-ok'
)
return
}
if
(
req
.
url
===
'/secret'
)
{
res
.
statusCode
=
200
res
.
end
(
'secret'
)
return
}
res
.
statusCode
=
404
res
.
end
(
'not-found'
)
})
intermediary
=
http
.
createServer
((
req
,
res
)
=>
{
const
connectionHeader
=
Array
.
isArray
(
req
.
headers
[
'connection'
])
?
req
.
headers
[
'connection'
].
join
(
','
)
:
req
.
headers
[
'connection'
]
||
''
const
hopByHopHeaders
=
connectionHeader
.
split
(
','
)
.
map
((
h
)
=>
h
.
trim
().
toLowerCase
())
.
filter
(
Boolean
)
const
stripTransferEncodingUnconditionally
=
req
.
url
?.
startsWith
(
'/rewrites/non-rfc-strip'
)
||
false
const
forwardHeaders
:
Record
<
string
,
string
|
string
[]
>
=
{}
for
(
const
[
key
,
value
]
of
Object
.
entries
(
req
.
headers
))
{
if
(
key
===
'connection'
)
continue
if
(
stripTransferEncodingUnconditionally
&&
key
===
'transfer-encoding'
)
continue
if
(
hopByHopHeaders
.
includes
(
key
))
continue
if
(
value
!==
undefined
)
{
forwardHeaders
[
key
]
=
value
}
}
forwardHeaders
.
connection
=
stripTransferEncodingUnconditionally
?
connectionHeader
.
toLowerCase
().
includes
(
'close'
)
?
'close'
:
'keep-alive'
:
'keep-alive'
const
proxyReq
=
http
.
request
(
{
hostname
:
'127.0.0.1'
,
port
:
backendPort
,
method
:
req
.
method
,
path
:
req
.
url
,
headers
:
forwardHeaders
,
},
(
proxyRes
)
=>
{
res
.
writeHead
(
proxyRes
.
statusCode
||
500
,
proxyRes
.
headers
)
proxyRes
.
pipe
(
res
)
}
)
proxyReq
.
on
(
'error'
,
()
=>
{
res
.
statusCode
=
502
res
.
end
(
'Bad Gateway'
)
})
req
.
pipe
(
proxyReq
)
})
await
new
Promise
<
void
>
((
resolve
,
reject
)
=>
{
backend
.
listen
(
backendPort
,
'127.0.0.1'
,
resolve
)
backend
.
once
(
'error'
,
reject
)
})
await
new
Promise
<
void
>
((
resolve
,
reject
)
=>
{
intermediary
.
listen
(
intermediaryPort
,
'127.0.0.1'
,
resolve
)
intermediary
.
once
(
'error'
,
reject
)
})
next
=
await
createNext
({
files
:
__dirname
,
env
:
{
TEST_INTERMEDIARY_PORT
:
String
(
intermediaryPort
),
},
})
})
afterAll
(
async
()
=>
{
await
next
?.
destroy
()
await
new
Promise
<
void
>
((
resolve
)
=>
intermediary
.
close
(()
=>
resolve
()))
await
new
Promise
<
void
>
((
resolve
)
=>
backend
.
close
(()
=>
resolve
()))
})
it
(
'does not smuggle a second request when using keep-alive only'
,
async
()
=>
{
backendRequests
.
length
=
0
const
nextPort
=
Number
(
new
URL
(
next
.
url
).
port
)
await
sendSmugglingPayload
({
nextPort
,
connectionHeader
:
'keep-alive'
})
await
retry
(
async
()
=>
{
expect
(
backendRequests
).
toContain
(
'DELETE /rewrites/poc'
)
})
expect
(
backendRequests
).
not
.
toContain
(
'GET /secret'
)
})
it
(
'does not smuggle a second request with keep-alive, upgrade'
,
async
()
=>
{
backendRequests
.
length
=
0
const
nextPort
=
Number
(
new
URL
(
next
.
url
).
port
)
await
sendSmugglingPayload
({
nextPort
,
connectionHeader
:
'keep-alive, upgrade'
,
})
await
retry
(
async
()
=>
{
expect
(
backendRequests
).
toContain
(
'DELETE /rewrites/poc'
)
})
expect
(
backendRequests
).
not
.
toContain
(
'GET /secret'
)
})
it
(
'does not smuggle a second request with Transfer-Encoding, upgrade'
,
async
()
=>
{
backendRequests
.
length
=
0
const
nextPort
=
Number
(
new
URL
(
next
.
url
).
port
)
await
sendSmugglingPayload
({
nextPort
,
connectionHeader
:
'Transfer-Encoding, upgrade'
,
})
await
retry
(
async
()
=>
{
expect
(
backendRequests
).
toContain
(
'DELETE /rewrites/poc'
)
})
expect
(
backendRequests
).
not
.
toContain
(
'GET /secret'
)
})
it
(
'does not smuggle a second request for OPTIONS with Transfer-Encoding, upgrade'
,
async
()
=>
{
backendRequests
.
length
=
0
const
nextPort
=
Number
(
new
URL
(
next
.
url
).
port
)
await
sendSmugglingPayload
({
nextPort
,
method
:
'OPTIONS'
,
connectionHeader
:
'Transfer-Encoding, upgrade'
,
})
await
retry
(
async
()
=>
{
expect
(
backendRequests
).
toContain
(
'OPTIONS /rewrites/poc'
)
})
expect
(
backendRequests
).
not
.
toContain
(
'GET /secret'
)
})
it
(
'does not smuggle a second request when an intermediary strips transfer-encoding unconditionally'
,
async
()
=>
{
backendRequests
.
length
=
0
const
nextPort
=
Number
(
new
URL
(
next
.
url
).
port
)
await
sendSmugglingPayload
({
nextPort
,
method
:
'OPTIONS'
,
rewritePath
:
'/rewrites/non-rfc-strip'
,
connectionHeader
:
'keep-alive, upgrade'
,
})
await
retry
(
async
()
=>
{
expect
(
backendRequests
).
toContain
(
'OPTIONS /rewrites/non-rfc-strip'
)
})
expect
(
backendRequests
).
not
.
toContain
(
'GET /secret'
)
})
})
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment