Unverified Commit 2e5fc012 authored by Janka Uryga's avatar Janka Uryga Committed by GitHub

[Instant] test: remove unnecessary reactDebugChannel permutation (#90103)

This is already handled by our test sharding, we don't need to duplicate
it
parent b0595b17
...@@ -5,7 +5,6 @@ const nextConfig: NextConfig = { ...@@ -5,7 +5,6 @@ const nextConfig: NextConfig = {
productionBrowserSourceMaps: true, productionBrowserSourceMaps: true,
experimental: { experimental: {
prerenderEarlyExit: false, prerenderEarlyExit: false,
reactDebugChannel: process.env.REACT_DEBUG_CHANNEL ? true : false,
}, },
typescript: { typescript: {
ignoreBuildErrors: true, ignoreBuildErrors: true,
......
...@@ -5,7 +5,6 @@ const nextConfig: NextConfig = { ...@@ -5,7 +5,6 @@ const nextConfig: NextConfig = {
productionBrowserSourceMaps: true, productionBrowserSourceMaps: true,
experimental: { experimental: {
prerenderEarlyExit: false, prerenderEarlyExit: false,
reactDebugChannel: process.env.REACT_DEBUG_CHANNEL ? true : false,
}, },
typescript: { typescript: {
ignoreBuildErrors: true, ignoreBuildErrors: true,
......
...@@ -29,18 +29,12 @@ describe('instant validation - opting out of static shells', () => { ...@@ -29,18 +29,12 @@ describe('instant validation - opting out of static shells', () => {
}) })
}) })
describe.each([ describe('instant validation', () => {
{ debugChannelEnabled: true, description: 'with debug channel' },
{ debugChannelEnabled: false, description: 'without debug channel' },
])('instant validation - $description', ({ debugChannelEnabled }) => {
describe('requires a static shell if a below a static layout page is configured as blocking', () => { describe('requires a static shell if a below a static layout page is configured as blocking', () => {
const { next, skipped, isNextDev } = nextTestSetup({ const { next, skipped, isNextDev } = nextTestSetup({
files: join(__dirname, 'fixtures', 'invalid-blocking-page-below-static'), files: join(__dirname, 'fixtures', 'invalid-blocking-page-below-static'),
skipStart: true, skipStart: true,
skipDeployment: true, skipDeployment: true,
env: {
REACT_DEBUG_CHANNEL: debugChannelEnabled ? '1' : '',
},
}) })
if (skipped) return if (skipped) return
......
...@@ -11,16 +11,10 @@ import { ...@@ -11,16 +11,10 @@ import {
RedboxSnapshot, RedboxSnapshot,
} from '../../../lib/add-redbox-matchers' } from '../../../lib/add-redbox-matchers'
describe.each([ describe('instant validation', () => {
{ debugChannelEnabled: true, description: 'with debug channel' },
{ debugChannelEnabled: false, description: 'without debug channel' },
])('instant validation - $description', ({ debugChannelEnabled }) => {
const { next, skipped, isNextDev } = nextTestSetup({ const { next, skipped, isNextDev } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true, skipDeployment: true,
env: {
REACT_DEBUG_CHANNEL: debugChannelEnabled ? '1' : '',
},
}) })
if (skipped) return if (skipped) return
if (!isNextDev) { if (!isNextDev) {
......
...@@ -3,9 +3,6 @@ import type { NextConfig } from 'next' ...@@ -3,9 +3,6 @@ import type { NextConfig } from 'next'
const nextConfig: NextConfig = { const nextConfig: NextConfig = {
cacheComponents: true, cacheComponents: true,
productionBrowserSourceMaps: true, productionBrowserSourceMaps: true,
experimental: {
reactDebugChannel: process.env.REACT_DEBUG_CHANNEL ? true : false,
},
typescript: { typescript: {
ignoreBuildErrors: true, ignoreBuildErrors: true,
}, },
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment