Unverified Commit 39e705ca authored by Benjamin Woodruff's avatar Benjamin Woodruff Committed by GitHub

Turbopack: Merge release-with-assertions-no-lto profile into release-with-assertions (#91530)

- More profiles means more bloat to the `target` directory and more cold builds.
- There's no practical use case where we'd be okay with the performance hit of `debug-assertions` and not okay with the performance hit of `lto = false`. Neither profile was suitable for benchmarking.
- `release-with-assertions-no-lto` is too long to type and was giving me carpal tunnel.
parent 4de22017
...@@ -271,16 +271,17 @@ opt-level = "s" ...@@ -271,16 +271,17 @@ opt-level = "s"
[profile.release.package.miette] [profile.release.package.miette]
opt-level = "s" opt-level = "s"
# Use a custom profile for CI or local testing where we are somewhat performance
# Use a custom profile for CI where many tests are performance sensitive but we still want the additional validation of debug-assertions # sensitive but we still want the additional validation of debug-assertions.
#
# This is not suitable for benchmarking, as debug assertions worsen performance
# and we disable LTO.
[profile.release-with-assertions] [profile.release-with-assertions]
inherits = "release" inherits = "release"
debug-assertions = true debug-assertions = true
overflow-checks = true overflow-checks = true
# Thin-LTO can make the binary ~5-10% faster, but it can make our build take a
# Like release-with-assertions but without LTO for faster test binary linking # couple more minutes, so it's not worth it for most test scenarios.
[profile.release-with-assertions-no-lto]
inherits = "release-with-assertions"
lto = false lto = false
[profile.release-with-debug] [profile.release-with-debug]
......
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
"rust-check-doc": "RUSTDOCFLAGS='-Zunstable-options --output-format=json' cargo doc --no-deps --workspace", "rust-check-doc": "RUSTDOCFLAGS='-Zunstable-options --output-format=json' cargo doc --no-deps --workspace",
"rust-check-fmt": "cd ../..; cargo fmt -- --check", "rust-check-fmt": "cd ../..; cargo fmt -- --check",
"rust-check-napi": "cargo check -p next-napi-bindings", "rust-check-napi": "cargo check -p next-napi-bindings",
"test-cargo-unit": "cargo nextest run --workspace --exclude next-napi-bindings --exclude turbo-tasks-macros --cargo-profile release-with-assertions-no-lto --no-fail-fast" "test-cargo-unit": "cargo nextest run --workspace --exclude next-napi-bindings --exclude turbo-tasks-macros --cargo-profile release-with-assertions --no-fail-fast"
}, },
"napi": { "napi": {
"name": "next-swc", "name": "next-swc",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment