Unverified Commit 39faecad authored by Luka Hartwig's avatar Luka Hartwig Committed by GitHub

Fix Server Action closure example (#65029)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

The example defines a Server Action in a client component.
parent 84af8009
...@@ -917,11 +917,10 @@ export function addItem() { ...@@ -917,11 +917,10 @@ export function addItem() {
Defining a Server Action inside a component creates a [closure](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Closures) where the action has access to the outer function's scope. For example, the `publish` action has access to the `publishVersion` variable: Defining a Server Action inside a component creates a [closure](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Closures) where the action has access to the outer function's scope. For example, the `publish` action has access to the `publishVersion` variable:
```tsx filename="app/page.tsx" switcher ```tsx filename="app/page.tsx" switcher
'use client' export default async function Page() {
export default function Page() {
const publishVersion = await getLatestVersion(); const publishVersion = await getLatestVersion();
async function publish(formData: FormData) { async function publish() {
"use server"; "use server";
if (publishVersion !== await getLatestVersion()) { if (publishVersion !== await getLatestVersion()) {
throw new Error('The version has changed since pressing publish'); throw new Error('The version has changed since pressing publish');
...@@ -929,13 +928,16 @@ export default function Page() { ...@@ -929,13 +928,16 @@ export default function Page() {
... ...
} }
return <button onClick={publish}>Publish</button>; return (
<form>
<button formAction={publish}>Publish</button>
</form>
);
} }
``` ```
```jsx filename="app/page.js" switcher ```jsx filename="app/page.js" switcher
'use client' export default async function Page() {
export default function Page() {
const publishVersion = await getLatestVersion(); const publishVersion = await getLatestVersion();
async function publish() { async function publish() {
...@@ -946,7 +948,11 @@ export default function Page() { ...@@ -946,7 +948,11 @@ export default function Page() {
... ...
} }
return <button onClick={publish}>Publish</button>; return (
<form>
<button formAction={publish}>Publish</button>
</form>
);
} }
``` ```
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment