Unverified Commit 43136958 authored by Niklas Mischkulnig's avatar Niklas Mischkulnig Committed by GitHub

Add `experimental.reportSystemEnvInlining` for Turbopack (#89304)

Part of PACK-6641

We don't have a way to silence (ignore-comment) warnings
And additionally, warnings in node_modules are always hidden...
parent 1e474a41
...@@ -1098,7 +1098,11 @@ impl Project { ...@@ -1098,7 +1098,11 @@ impl Project {
#[turbo_tasks::function] #[turbo_tasks::function]
pub(super) fn client_compile_time_info(&self) -> Vc<CompileTimeInfo> { pub(super) fn client_compile_time_info(&self) -> Vc<CompileTimeInfo> {
get_client_compile_time_info(self.browserslist_query.clone(), self.define_env.client()) get_client_compile_time_info(
self.browserslist_query.clone(),
self.define_env.client(),
self.next_config.report_system_env_inlining(),
)
} }
#[turbo_tasks::function] #[turbo_tasks::function]
...@@ -1336,6 +1340,7 @@ impl Project { ...@@ -1336,6 +1340,7 @@ impl Project {
self.project_path(), self.project_path(),
this.define_env.nodejs(), this.define_env.nodejs(),
self.current_node_js_version(), self.current_node_js_version(),
this.next_config.report_system_env_inlining(),
)) ))
} }
...@@ -1346,6 +1351,7 @@ impl Project { ...@@ -1346,6 +1351,7 @@ impl Project {
self.project_path().owned().await?, self.project_path().owned().await?,
this.define_env.edge(), this.define_env.edge(),
self.current_node_js_version(), self.current_node_js_version(),
this.next_config.report_system_env_inlining(),
)) ))
} }
......
...@@ -22,6 +22,7 @@ use turbopack_core::{ ...@@ -22,6 +22,7 @@ use turbopack_core::{
compile_time_info::{CompileTimeDefines, CompileTimeInfo, FreeVarReference, FreeVarReferences}, compile_time_info::{CompileTimeDefines, CompileTimeInfo, FreeVarReference, FreeVarReferences},
environment::{BrowserEnvironment, Environment, ExecutionEnvironment}, environment::{BrowserEnvironment, Environment, ExecutionEnvironment},
free_var_references, free_var_references,
issue::IssueSeverity,
module_graph::binding_usage_info::OptionBindingUsageInfo, module_graph::binding_usage_info::OptionBindingUsageInfo,
resolve::{parse::Request, pattern::Pattern}, resolve::{parse::Request, pattern::Pattern},
}; };
...@@ -68,7 +69,8 @@ use crate::{ ...@@ -68,7 +69,8 @@ use crate::{
get_typescript_transform_options, get_typescript_transform_options,
}, },
util::{ util::{
OptionEnvMap, defines, foreign_code_context_condition, internal_assets_conditions, OptionEnvMap, defines, foreign_code_context_condition,
free_var_references_with_vercel_system_env_warnings, internal_assets_conditions,
module_styles_rule_condition, module_styles_rule_condition,
}, },
}; };
...@@ -79,9 +81,15 @@ async fn next_client_defines(define_env: Vc<OptionEnvMap>) -> Result<Vc<CompileT ...@@ -79,9 +81,15 @@ async fn next_client_defines(define_env: Vc<OptionEnvMap>) -> Result<Vc<CompileT
} }
#[turbo_tasks::function] #[turbo_tasks::function]
async fn next_client_free_vars(define_env: Vc<OptionEnvMap>) -> Result<Vc<FreeVarReferences>> { async fn next_client_free_vars(
define_env: Vc<OptionEnvMap>,
report_system_env_inlining: Vc<IssueSeverity>,
) -> Result<Vc<FreeVarReferences>> {
Ok(free_var_references!( Ok(free_var_references!(
..defines(&*define_env.await?).into_iter(), ..free_var_references_with_vercel_system_env_warnings(
defines(&*define_env.await?),
*report_system_env_inlining.await?
),
Buffer = FreeVarReference::EcmaScriptModule { Buffer = FreeVarReference::EcmaScriptModule {
request: rcstr!("node:buffer"), request: rcstr!("node:buffer"),
lookup_path: None, lookup_path: None,
...@@ -100,6 +108,7 @@ async fn next_client_free_vars(define_env: Vc<OptionEnvMap>) -> Result<Vc<FreeVa ...@@ -100,6 +108,7 @@ async fn next_client_free_vars(define_env: Vc<OptionEnvMap>) -> Result<Vc<FreeVa
pub async fn get_client_compile_time_info( pub async fn get_client_compile_time_info(
browserslist_query: RcStr, browserslist_query: RcStr,
define_env: Vc<OptionEnvMap>, define_env: Vc<OptionEnvMap>,
report_system_env_inlining: Vc<IssueSeverity>,
) -> Result<Vc<CompileTimeInfo>> { ) -> Result<Vc<CompileTimeInfo>> {
CompileTimeInfo::builder( CompileTimeInfo::builder(
Environment::new(ExecutionEnvironment::Browser( Environment::new(ExecutionEnvironment::Browser(
...@@ -115,7 +124,11 @@ pub async fn get_client_compile_time_info( ...@@ -115,7 +124,11 @@ pub async fn get_client_compile_time_info(
.await?, .await?,
) )
.defines(next_client_defines(define_env).to_resolved().await?) .defines(next_client_defines(define_env).to_resolved().await?)
.free_var_references(next_client_free_vars(define_env).to_resolved().await?) .free_var_references(
next_client_free_vars(define_env, report_system_env_inlining)
.to_resolved()
.await?,
)
.cell() .cell()
.await .await
} }
......
...@@ -19,7 +19,7 @@ use turbopack::module_options::{ ...@@ -19,7 +19,7 @@ use turbopack::module_options::{
}; };
use turbopack_core::{ use turbopack_core::{
chunk::SourceMapsType, chunk::SourceMapsType,
issue::{Issue, IssueExt, IssueStage, OptionStyledString, StyledString}, issue::{Issue, IssueExt, IssueSeverity, IssueStage, OptionStyledString, StyledString},
resolve::ResolveAliasMap, resolve::ResolveAliasMap,
}; };
use turbopack_ecmascript::{OptionTreeShaking, TreeShakingMode}; use turbopack_ecmascript::{OptionTreeShaking, TreeShakingMode};
...@@ -1097,6 +1097,8 @@ pub struct ExperimentalConfig { ...@@ -1097,6 +1097,8 @@ pub struct ExperimentalConfig {
turbopack_infer_module_side_effects: Option<bool>, turbopack_infer_module_side_effects: Option<bool>,
/// Devtool option for the segment explorer. /// Devtool option for the segment explorer.
devtool_segment_explorer: Option<bool>, devtool_segment_explorer: Option<bool>,
/// Whether to report inlined system environment variables as warnings or errors.
report_system_env_inlining: Option<String>,
} }
#[derive( #[derive(
...@@ -2108,6 +2110,18 @@ impl NextConfig { ...@@ -2108,6 +2110,18 @@ impl NextConfig {
pub fn fetch_client(&self) -> Vc<FetchClientConfig> { pub fn fetch_client(&self) -> Vc<FetchClientConfig> {
FetchClientConfig::default().cell() FetchClientConfig::default().cell()
} }
#[turbo_tasks::function]
pub async fn report_system_env_inlining(&self) -> Result<Vc<IssueSeverity>> {
match self.experimental.report_system_env_inlining.as_deref() {
None => Ok(IssueSeverity::Suggestion.cell()),
Some("warn") => Ok(IssueSeverity::Warning.cell()),
Some("error") => Ok(IssueSeverity::Error.cell()),
_ => bail!(
"`experimental.reportSystemEnvInlining` must be undefined, \"error\", or \"warn\""
),
}
}
} }
/// A subset of ts/jsconfig that next.js implicitly /// A subset of ts/jsconfig that next.js implicitly
......
...@@ -12,6 +12,7 @@ use turbopack_core::{ ...@@ -12,6 +12,7 @@ use turbopack_core::{
compile_time_info::{CompileTimeDefines, CompileTimeInfo, FreeVarReference, FreeVarReferences}, compile_time_info::{CompileTimeDefines, CompileTimeInfo, FreeVarReference, FreeVarReferences},
environment::{EdgeWorkerEnvironment, Environment, ExecutionEnvironment, NodeJsVersion}, environment::{EdgeWorkerEnvironment, Environment, ExecutionEnvironment, NodeJsVersion},
free_var_references, free_var_references,
issue::IssueSeverity,
module_graph::binding_usage_info::OptionBindingUsageInfo, module_graph::binding_usage_info::OptionBindingUsageInfo,
}; };
use turbopack_css::chunk::CssChunkType; use turbopack_css::chunk::CssChunkType;
...@@ -30,7 +31,10 @@ use crate::{ ...@@ -30,7 +31,10 @@ use crate::{
ModuleFeatureReportResolvePlugin, NextSharedRuntimeResolvePlugin, ModuleFeatureReportResolvePlugin, NextSharedRuntimeResolvePlugin,
get_invalid_client_only_resolve_plugin, get_invalid_styled_jsx_resolve_plugin, get_invalid_client_only_resolve_plugin, get_invalid_styled_jsx_resolve_plugin,
}, },
util::{NextRuntime, OptionEnvMap, defines, foreign_code_context_condition}, util::{
NextRuntime, OptionEnvMap, defines, foreign_code_context_condition,
free_var_references_with_vercel_system_env_warnings,
},
}; };
#[turbo_tasks::function] #[turbo_tasks::function]
...@@ -44,9 +48,13 @@ async fn next_edge_defines(define_env: Vc<OptionEnvMap>) -> Result<Vc<CompileTim ...@@ -44,9 +48,13 @@ async fn next_edge_defines(define_env: Vc<OptionEnvMap>) -> Result<Vc<CompileTim
async fn next_edge_free_vars( async fn next_edge_free_vars(
project_path: FileSystemPath, project_path: FileSystemPath,
define_env: Vc<OptionEnvMap>, define_env: Vc<OptionEnvMap>,
report_system_env_inlining: Vc<IssueSeverity>,
) -> Result<Vc<FreeVarReferences>> { ) -> Result<Vc<FreeVarReferences>> {
Ok(free_var_references!( Ok(free_var_references!(
..defines(&*define_env.await?).into_iter(), ..free_var_references_with_vercel_system_env_warnings(
defines(&*define_env.await?),
*report_system_env_inlining.await?
),
Buffer = FreeVarReference::EcmaScriptModule { Buffer = FreeVarReference::EcmaScriptModule {
request: rcstr!("buffer"), request: rcstr!("buffer"),
lookup_path: Some(project_path), lookup_path: Some(project_path),
...@@ -61,6 +69,7 @@ pub async fn get_edge_compile_time_info( ...@@ -61,6 +69,7 @@ pub async fn get_edge_compile_time_info(
project_path: FileSystemPath, project_path: FileSystemPath,
define_env: Vc<OptionEnvMap>, define_env: Vc<OptionEnvMap>,
node_version: ResolvedVc<NodeJsVersion>, node_version: ResolvedVc<NodeJsVersion>,
report_system_env_inlining: Vc<IssueSeverity>,
) -> Result<Vc<CompileTimeInfo>> { ) -> Result<Vc<CompileTimeInfo>> {
CompileTimeInfo::builder( CompileTimeInfo::builder(
Environment::new(ExecutionEnvironment::EdgeWorker( Environment::new(ExecutionEnvironment::EdgeWorker(
...@@ -71,7 +80,7 @@ pub async fn get_edge_compile_time_info( ...@@ -71,7 +80,7 @@ pub async fn get_edge_compile_time_info(
) )
.defines(next_edge_defines(define_env).to_resolved().await?) .defines(next_edge_defines(define_env).to_resolved().await?)
.free_var_references( .free_var_references(
next_edge_free_vars(project_path, define_env) next_edge_free_vars(project_path, define_env, report_system_env_inlining)
.to_resolved() .to_resolved()
.await?, .await?,
) )
......
...@@ -21,7 +21,7 @@ use turbopack_core::{ ...@@ -21,7 +21,7 @@ use turbopack_core::{
compile_time_defines, compile_time_defines,
compile_time_info::{CompileTimeDefines, CompileTimeInfo, FreeVarReferences}, compile_time_info::{CompileTimeDefines, CompileTimeInfo, FreeVarReferences},
environment::{Environment, ExecutionEnvironment, NodeJsEnvironment, NodeJsVersion}, environment::{Environment, ExecutionEnvironment, NodeJsEnvironment, NodeJsVersion},
free_var_references, issue::IssueSeverity,
module_graph::binding_usage_info::OptionBindingUsageInfo, module_graph::binding_usage_info::OptionBindingUsageInfo,
target::CompileTarget, target::CompileTarget,
}; };
...@@ -73,8 +73,8 @@ use crate::{ ...@@ -73,8 +73,8 @@ use crate::{
}, },
util::{ util::{
NextRuntime, OptionEnvMap, defines, foreign_code_context_condition, NextRuntime, OptionEnvMap, defines, foreign_code_context_condition,
get_transpiled_packages, internal_assets_conditions, load_next_js_jsonc_file, free_var_references_with_vercel_system_env_warnings, get_transpiled_packages,
module_styles_rule_condition, internal_assets_conditions, load_next_js_jsonc_file, module_styles_rule_condition,
}, },
}; };
...@@ -356,8 +356,15 @@ async fn next_server_defines(define_env: Vc<OptionEnvMap>) -> Result<Vc<CompileT ...@@ -356,8 +356,15 @@ async fn next_server_defines(define_env: Vc<OptionEnvMap>) -> Result<Vc<CompileT
} }
#[turbo_tasks::function] #[turbo_tasks::function]
async fn next_server_free_vars(define_env: Vc<OptionEnvMap>) -> Result<Vc<FreeVarReferences>> { async fn next_server_free_vars(
Ok(free_var_references!(..defines(&*define_env.await?).into_iter()).cell()) define_env: Vc<OptionEnvMap>,
report_system_env_inlining: Vc<IssueSeverity>,
) -> Result<Vc<FreeVarReferences>> {
Ok(free_var_references_with_vercel_system_env_warnings(
defines(&*define_env.await?),
*report_system_env_inlining.await?,
)
.cell())
} }
#[turbo_tasks::function] #[turbo_tasks::function]
...@@ -365,6 +372,7 @@ pub async fn get_server_compile_time_info( ...@@ -365,6 +372,7 @@ pub async fn get_server_compile_time_info(
cwd: Vc<FileSystemPath>, cwd: Vc<FileSystemPath>,
define_env: Vc<OptionEnvMap>, define_env: Vc<OptionEnvMap>,
node_version: ResolvedVc<NodeJsVersion>, node_version: ResolvedVc<NodeJsVersion>,
report_system_env_inlining: Vc<IssueSeverity>,
) -> Result<Vc<CompileTimeInfo>> { ) -> Result<Vc<CompileTimeInfo>> {
CompileTimeInfo::builder( CompileTimeInfo::builder(
Environment::new(ExecutionEnvironment::NodeJsLambda( Environment::new(ExecutionEnvironment::NodeJsLambda(
...@@ -379,7 +387,11 @@ pub async fn get_server_compile_time_info( ...@@ -379,7 +387,11 @@ pub async fn get_server_compile_time_info(
.await?, .await?,
) )
.defines(next_server_defines(define_env).to_resolved().await?) .defines(next_server_defines(define_env).to_resolved().await?)
.free_var_references(next_server_free_vars(define_env).to_resolved().await?) .free_var_references(
next_server_free_vars(define_env, report_system_env_inlining)
.to_resolved()
.await?,
)
.cell() .cell()
.await .await
} }
......
...@@ -5,13 +5,17 @@ use bincode::{Decode, Encode}; ...@@ -5,13 +5,17 @@ use bincode::{Decode, Encode};
use next_taskless::{expand_next_js_template, expand_next_js_template_no_imports}; use next_taskless::{expand_next_js_template, expand_next_js_template_no_imports};
use serde::{Deserialize, de::DeserializeOwned}; use serde::{Deserialize, de::DeserializeOwned};
use turbo_rcstr::{RcStr, rcstr}; use turbo_rcstr::{RcStr, rcstr};
use turbo_tasks::{FxIndexMap, NonLocalValue, TaskInput, Vc, trace::TraceRawVcs}; use turbo_tasks::{FxIndexMap, NonLocalValue, TaskInput, Vc, fxindexset, trace::TraceRawVcs};
use turbo_tasks_fs::{File, FileContent, FileJsonContent, FileSystem, FileSystemPath, rope::Rope}; use turbo_tasks_fs::{File, FileContent, FileJsonContent, FileSystem, FileSystemPath, rope::Rope};
use turbopack::module_options::RuleCondition; use turbopack::module_options::RuleCondition;
use turbopack_core::{ use turbopack_core::{
asset::AssetContent, asset::AssetContent,
compile_time_info::{CompileTimeDefineValue, CompileTimeDefines, DefinableNameSegment}, compile_time_info::{
CompileTimeDefineValue, CompileTimeDefines, DefinableNameSegment, FreeVarReference,
FreeVarReferences,
},
condition::ContextCondition, condition::ContextCondition,
issue::IssueSeverity,
source::Source, source::Source,
virtual_source::VirtualSource, virtual_source::VirtualSource,
}; };
...@@ -58,6 +62,137 @@ pub fn defines(define_env: &FxIndexMap<RcStr, Option<RcStr>>) -> CompileTimeDefi ...@@ -58,6 +62,137 @@ pub fn defines(define_env: &FxIndexMap<RcStr, Option<RcStr>>) -> CompileTimeDefi
CompileTimeDefines(defines) CompileTimeDefines(defines)
} }
/// Emits warnings or errors when inlining frequently changing Vercel system env vars
pub fn free_var_references_with_vercel_system_env_warnings(
defines: CompileTimeDefines,
severity: IssueSeverity,
) -> FreeVarReferences {
// List of system env vars:
// not available as NEXT_PUBLIC_* anyway:
// CI
// VERCEL
// VERCEL_SKEW_PROTECTION_ENABLED
// VERCEL_AUTOMATION_BYPASS_SECRET
// VERCEL_GIT_PROVIDER
// VERCEL_GIT_REPO_SLUG
// VERCEL_GIT_REPO_OWNER
// VERCEL_GIT_REPO_ID
// VERCEL_OIDC_TOKEN
//
// constant:
// VERCEL_PROJECT_PRODUCTION_URL
// VERCEL_REGION
// VERCEL_PROJECT_ID
//
// suboptimal (changes production main branch VS preview branches):
// VERCEL_ENV
// VERCEL_TARGET_ENV
//
// bad (changes per branch):
// VERCEL_BRANCH_URL
// VERCEL_GIT_COMMIT_REF
// VERCEL_GIT_PULL_REQUEST_ID
//
// catastrophic (changes per commit):
// NEXT_DEPLOYMENT_ID
// VERCEL_URL
// VERCEL_DEPLOYMENT_ID
// VERCEL_GIT_COMMIT_SHA
// VERCEL_GIT_COMMIT_MESSAGE
// VERCEL_GIT_COMMIT_AUTHOR_LOGIN
// VERCEL_GIT_COMMIT_AUTHOR_NAME
// VERCEL_GIT_PREVIOUS_SHA
let entries = defines
.0
.into_iter()
.map(|(k, value)| (k, FreeVarReference::Value(value)));
fn wrap_report_next_public_usage(
public_env_var: &str,
inner: Option<Box<FreeVarReference>>,
severity: IssueSeverity,
) -> FreeVarReference {
let message = match public_env_var {
"NEXT_PUBLIC_NEXT_DEPLOYMENT_ID" | "NEXT_PUBLIC_VERCEL_DEPLOYMENT_ID" => {
rcstr!(
"The deployment id is being inlined. Use `process.env.NEXT_DEPLOYMENT_ID` \
instead to access the same value without inlining, for faster deploy times \
and better browser client-side caching."
)
}
"NEXT_PUBLIC_VERCEL_BRANCH_URL" | "NEXT_PUBLIC_VERCEL_URL" => format!(
"The deployment url system environment variable is being inlined. This variable \
changes frequently, causing slower deploy times and worse browser client-side \
caching. For server-side code, replace with `process.env.{}` and for browser \
code, read `location.origin` instead.",
public_env_var.strip_prefix("NEXT_PUBLIC_").unwrap(),
)
.into(),
_ => format!(
"A system environment variable is being inlined. This variable changes on every \
deployment, causing slower deploy times and worse browser client-side caching. \
For server-side code, replace with `process.env.{}` and for browser code, try to \
remove it.",
public_env_var.strip_prefix("NEXT_PUBLIC_").unwrap(),
)
.into(),
};
FreeVarReference::ReportUsage {
message,
severity,
inner,
}
}
let mut list = fxindexset!(
"NEXT_PUBLIC_NEXT_DEPLOYMENT_ID",
"NEXT_PUBLIC_VERCEL_BRANCH_URL",
"NEXT_PUBLIC_VERCEL_DEPLOYMENT_ID",
"NEXT_PUBLIC_VERCEL_GIT_COMMIT_AUTHOR_LOGIN",
"NEXT_PUBLIC_VERCEL_GIT_COMMIT_AUTHOR_NAME",
"NEXT_PUBLIC_VERCEL_GIT_COMMIT_MESSAGE",
"NEXT_PUBLIC_VERCEL_GIT_COMMIT_REF",
"NEXT_PUBLIC_VERCEL_GIT_COMMIT_SHA",
"NEXT_PUBLIC_VERCEL_GIT_PREVIOUS_SHA",
"NEXT_PUBLIC_VERCEL_GIT_PULL_REQUEST_ID",
"NEXT_PUBLIC_VERCEL_URL",
);
let mut entries: FxIndexMap<_, _> = entries
.map(|(k, value)| {
let value = if let &[
DefinableNameSegment::Name(a),
DefinableNameSegment::Name(b),
DefinableNameSegment::Name(public_env_var),
] = &&*k
&& a == "process"
&& b == "env"
&& list.swap_remove(&**public_env_var)
{
wrap_report_next_public_usage(public_env_var, Some(Box::new(value)), severity)
} else {
value
};
(k, value)
})
.collect();
// For the remaining ones, still add a warning, but without replacement
for public_env_var in list {
entries.insert(
vec![
rcstr!("process").into(),
rcstr!("env").into(),
DefinableNameSegment::Name(public_env_var.into()),
],
wrap_report_next_public_usage(public_env_var, None, severity),
);
}
FreeVarReferences(entries)
}
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, TaskInput, TraceRawVcs, Encode, Decode)] #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, TaskInput, TraceRawVcs, Encode, Decode)]
pub enum PathType { pub enum PathType {
PagesPage, PagesPage,
......
...@@ -372,6 +372,7 @@ export const experimentalSchema = { ...@@ -372,6 +372,7 @@ export const experimentalSchema = {
devCacheControlNoCache: z.boolean().optional(), devCacheControlNoCache: z.boolean().optional(),
deferredEntries: z.array(z.string()).optional(), deferredEntries: z.array(z.string()).optional(),
onBeforeDeferredEntries: z.function().returns(z.promise(z.void())).optional(), onBeforeDeferredEntries: z.function().returns(z.promise(z.void())).optional(),
reportSystemEnvInlining: z.enum(['warn', 'error']).optional(),
} }
export const configSchema: zod.ZodType<NextConfig> = z.lazy(() => export const configSchema: zod.ZodType<NextConfig> = z.lazy(() =>
......
...@@ -938,6 +938,12 @@ export interface ExperimentalConfig { ...@@ -938,6 +938,12 @@ export interface ExperimentalConfig {
* This callback runs after all non-deferred entries have been compiled. * This callback runs after all non-deferred entries have been compiled.
*/ */
onBeforeDeferredEntries?: () => Promise<void> onBeforeDeferredEntries?: () => Promise<void>
/**
* Whether to report inlined system environment variables as warnings or errors.
* Only supported for Turbopack.
*/
reportSystemEnvInlining?: 'error' | 'warn'
} }
export type ExportPathMap = { export type ExportPathMap = {
......
export function Foo() {
return <p>{process.env.NEXT_PUBLIC_VERCEL_GIT_COMMIT_SHA}</p>
}
import { ReactNode } from 'react'
export default function Root({ children }: { children: ReactNode }) {
return (
<html>
<body>{children}</body>
</html>
)
}
import { Foo } from './foo'
export default function Page() {
return <Foo />
}
/**
* @type {import('next').NextConfig}
*/
const nextConfig = {
experimental: {
reportSystemEnvInlining: 'error',
},
}
module.exports = nextConfig
import { nextTestSetup } from 'e2e-utils'
// Only implemented in Turbopack
import { getRedboxSource, waitForRedbox } from 'next-test-utils'
;(process.env.IS_TURBOPACK_TEST ? describe : describe.skip)(
'report-system-env-var-inlining',
() => {
const { next } = nextTestSetup({
files: __dirname,
})
it('should report when inlining system env vars', async () => {
const browser = await next.browser('/')
await waitForRedbox(browser)
const error = await getRedboxSource(browser)
expect(error).toMatchInlineSnapshot(`
"./app/foo.tsx (2:14)
error TP1202 A system environment variable is being inlined. This variable changes on every deployment, causing slower deploy times and worse browser client-side caching. For server-side code, replace with \`process.env.VERCEL_GIT_COMMIT_SHA\` and for browser code, try to remove it.
1 | export function Foo() {
> 2 | return <p>{process.env.NEXT_PUBLIC_VERCEL_GIT_COMMIT_SHA}</p>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3 | }
4 |
Import trace:
Server Component:
./app/foo.tsx
./app/page.tsx"
`)
})
}
)
...@@ -392,6 +392,15 @@ impl FreeVarReferences { ...@@ -392,6 +392,15 @@ impl FreeVarReferences {
} }
} }
impl IntoIterator for FreeVarReferences {
type Item = (Vec<DefinableNameSegment>, FreeVarReference);
type IntoIter = indexmap::map::IntoIter<Vec<DefinableNameSegment>, FreeVarReference>;
fn into_iter(self) -> Self::IntoIter {
self.0.into_iter()
}
}
#[turbo_tasks::value(shared)] #[turbo_tasks::value(shared)]
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
pub struct CompileTimeInfo { pub struct CompileTimeInfo {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment