Unverified Commit 451ca9c7 authored by Shu Ding's avatar Shu Ding Committed by GitHub

Remove the `actionBrowser` to RSC `client` layering issue (#57842)

You can read the removed comments to get some context here. Based on the community feedback, we're removing this compile-time error and instead, it will be a runtime error only when it gets accessed by React and found it missing in the manifest.

In the future, we'll need:
- Converting the client references created this way to be specific errors. So they'll only throw in that certain case.
- Or have a prepass compilation to collect all the references globally. This way we can support any kind of layer change.

Related: https://twitter.com/trashh_dev/status/1719016700191150550.
parent 3241b557
import { import { RSC_MOD_REF_PROXY_ALIAS } from '../../../../lib/constants'
RSC_MOD_REF_PROXY_ALIAS,
WEBPACK_LAYERS,
} from '../../../../lib/constants'
import { RSC_MODULE_TYPES } from '../../../../shared/lib/constants' import { RSC_MODULE_TYPES } from '../../../../shared/lib/constants'
import { warnOnce } from '../../../../shared/lib/utils/warn-once' import { warnOnce } from '../../../../shared/lib/utils/warn-once'
import { getRSCModuleInformation } from '../../../analysis/get-page-static-info' import { getRSCModuleInformation } from '../../../analysis/get-page-static-info'
...@@ -29,31 +26,10 @@ export default function transformSource( ...@@ -29,31 +26,10 @@ export default function transformSource(
// A client boundary. // A client boundary.
if (buildInfo.rsc?.type === RSC_MODULE_TYPES.client) { if (buildInfo.rsc?.type === RSC_MODULE_TYPES.client) {
const issuerLayer = this._module.layer
const sourceType = this._module?.parser?.sourceType const sourceType = this._module?.parser?.sourceType
const detectedClientEntryType = buildInfo.rsc.clientEntryType const detectedClientEntryType = buildInfo.rsc.clientEntryType
const clientRefs = buildInfo.rsc.clientRefs! const clientRefs = buildInfo.rsc.clientRefs!
if (issuerLayer === WEBPACK_LAYERS.actionBrowser) {
// You're importing a Server Action module ("use server") from a client module
// (hence you're on the actionBrowser layer), and you're trying to import a
// client module again from it. This is not allowed because of cyclic module
// graph.
// We need to only error for user code, not for node_modules/Next.js internals.
// Things like `next/navigation` exports both `cookies()` and `useRouter()`
// and we shouldn't error for that. In the future we might want to find a way
// to only throw when it's used.
if (!this.resourcePath.includes('node_modules')) {
this.callback(
new Error(
`You're importing a Client Component ("use client") from another Client Component imported Server Action file ("use server"). This is not allowed due to cyclic module graph between Server and Client.\nYou can work around it by defining and passing this Server Action from a Server Component into the Client Component via props.`
)
)
return
}
}
// It's tricky to detect the type of a client boundary, but we should always // It's tricky to detect the type of a client boundary, but we should always
// use the `module` type when we can, to support `export *` and `export from` // use the `module` type when we can, to support `export *` and `export from`
// syntax in other modules that import this client boundary. // syntax in other modules that import this client boundary.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment