Unverified Commit 481dee6e authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

codemod: install core deps based on package.json group (#71265)

parent 8388d234
...@@ -51,6 +51,23 @@ function endMessage() { ...@@ -51,6 +51,23 @@ function endMessage() {
) )
} }
function addDependencyIfNeeded(
packageName: string,
version: string,
appPackageJson: any,
dependenciesToInstall: string[],
devDependenciesToInstall: string[]
) {
const specifiedDependency = `${packageName}@${version}`
// First check if it's dev dependencies, then add into dev deps;
// If it's not, fallback into dependencies.
if (appPackageJson.devDependencies?.[packageName]) {
devDependenciesToInstall.push(specifiedDependency)
} else if (appPackageJson.dependencies?.[packageName]) {
dependenciesToInstall.push(specifiedDependency)
}
}
export async function runUpgrade( export async function runUpgrade(
revision: string | undefined, revision: string | undefined,
options: { verbose: boolean } options: { verbose: boolean }
...@@ -172,19 +189,32 @@ export async function runUpgrade( ...@@ -172,19 +189,32 @@ export async function runUpgrade(
fs.writeFileSync(appPackageJsonPath, JSON.stringify(appPackageJson, null, 2)) fs.writeFileSync(appPackageJsonPath, JSON.stringify(appPackageJson, null, 2))
const nextDependency = `next@${targetNextVersion}` const dependenciesToInstall = []
const dependenciesToInstall = [
`react@${targetReactVersion}`,
`react-dom@${targetReactVersion}`,
]
const devDependenciesToInstall = [] const devDependenciesToInstall = []
const corePackageNameVersionMapping = {
react: targetReactVersion,
'react-dom': targetReactVersion,
next: targetNextVersion,
}
for (const packageName of Object.keys(corePackageNameVersionMapping)) {
addDependencyIfNeeded(
packageName,
corePackageNameVersionMapping[packageName],
appPackageJson,
dependenciesToInstall,
devDependenciesToInstall
)
}
if ( if (
targetReactVersion.startsWith('19.0.0-canary') || targetReactVersion.startsWith('19.0.0-canary') ||
targetReactVersion.startsWith('19.0.0-beta') || targetReactVersion.startsWith('19.0.0-beta') ||
targetReactVersion.startsWith('19.0.0-rc') targetReactVersion.startsWith('19.0.0-rc')
) { ) {
devDependenciesToInstall.push(`@types/react@npm:types-react@rc`) corePackageNameVersionMapping['@types/react'] = 'npm:types-react@rc'
devDependenciesToInstall.push(`@types/react-dom@npm:types-react-dom@rc`) corePackageNameVersionMapping['@types/react-dom'] = 'npm:types-react-dom@rc'
} else { } else {
const [targetReactTypesVersion, targetReactDOMTypesVersion] = const [targetReactTypesVersion, targetReactDOMTypesVersion] =
await Promise.all([ await Promise.all([
...@@ -195,17 +225,16 @@ export async function runUpgrade( ...@@ -195,17 +225,16 @@ export async function runUpgrade(
`@types/react-dom@${targetNextPackageJson.peerDependencies['react']}` `@types/react-dom@${targetNextPackageJson.peerDependencies['react']}`
), ),
]) ])
devDependenciesToInstall.push(`@types/react@${targetReactTypesVersion}`) corePackageNameVersionMapping['@types/react'] = targetReactTypesVersion
devDependenciesToInstall.push( corePackageNameVersionMapping['@types/react-dom'] =
`@types/react-dom@${targetReactDOMTypesVersion}` targetReactDOMTypesVersion
)
} }
console.log( console.log(
`Upgrading your project to ${pc.blue('Next.js ' + targetNextVersion)}...\n` `Upgrading your project to ${pc.blue('Next.js ' + targetNextVersion)}...\n`
) )
installPackages([nextDependency, ...dependenciesToInstall], { installPackages(dependenciesToInstall, {
packageManager, packageManager,
silent: !verbose, silent: !verbose,
}) })
......
...@@ -76,6 +76,8 @@ export function installPackages( ...@@ -76,6 +76,8 @@ export function installPackages(
dev?: boolean dev?: boolean
} = {} } = {}
) { ) {
if (packageToInstall.length === 0) return
const { const {
packageManager = getPkgManager(process.cwd()), packageManager = getPkgManager(process.cwd()),
silent = false, silent = false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment