Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
481dee6e
Unverified
Commit
481dee6e
authored
Oct 14, 2024
by
Jiachi Liu
Committed by
GitHub
Oct 14, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
codemod: install core deps based on package.json group (#71265)
parent
8388d234
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
43 additions
and
12 deletions
+43
-12
upgrade.ts
packages/next-codemod/bin/upgrade.ts
+41
-12
handle-package.ts
packages/next-codemod/lib/handle-package.ts
+2
-0
No files found.
packages/next-codemod/bin/upgrade.ts
View file @
481dee6e
...
@@ -51,6 +51,23 @@ function endMessage() {
...
@@ -51,6 +51,23 @@ function endMessage() {
)
)
}
}
function
addDependencyIfNeeded
(
packageName
:
string
,
version
:
string
,
appPackageJson
:
any
,
dependenciesToInstall
:
string
[],
devDependenciesToInstall
:
string
[]
)
{
const
specifiedDependency
=
`
${
packageName
}
@
${
version
}
`
// First check if it's dev dependencies, then add into dev deps;
// If it's not, fallback into dependencies.
if
(
appPackageJson
.
devDependencies
?.[
packageName
])
{
devDependenciesToInstall
.
push
(
specifiedDependency
)
}
else
if
(
appPackageJson
.
dependencies
?.[
packageName
])
{
dependenciesToInstall
.
push
(
specifiedDependency
)
}
}
export
async
function
runUpgrade
(
export
async
function
runUpgrade
(
revision
:
string
|
undefined
,
revision
:
string
|
undefined
,
options
:
{
verbose
:
boolean
}
options
:
{
verbose
:
boolean
}
...
@@ -172,19 +189,32 @@ export async function runUpgrade(
...
@@ -172,19 +189,32 @@ export async function runUpgrade(
fs
.
writeFileSync
(
appPackageJsonPath
,
JSON
.
stringify
(
appPackageJson
,
null
,
2
))
fs
.
writeFileSync
(
appPackageJsonPath
,
JSON
.
stringify
(
appPackageJson
,
null
,
2
))
const
nextDependency
=
`next@
${
targetNextVersion
}
`
const
dependenciesToInstall
=
[]
const
dependenciesToInstall
=
[
`react@
${
targetReactVersion
}
`
,
`react-dom@
${
targetReactVersion
}
`
,
]
const
devDependenciesToInstall
=
[]
const
devDependenciesToInstall
=
[]
const
corePackageNameVersionMapping
=
{
react
:
targetReactVersion
,
'react-dom'
:
targetReactVersion
,
next
:
targetNextVersion
,
}
for
(
const
packageName
of
Object
.
keys
(
corePackageNameVersionMapping
))
{
addDependencyIfNeeded
(
packageName
,
corePackageNameVersionMapping
[
packageName
],
appPackageJson
,
dependenciesToInstall
,
devDependenciesToInstall
)
}
if
(
if
(
targetReactVersion
.
startsWith
(
'19.0.0-canary'
)
||
targetReactVersion
.
startsWith
(
'19.0.0-canary'
)
||
targetReactVersion
.
startsWith
(
'19.0.0-beta'
)
||
targetReactVersion
.
startsWith
(
'19.0.0-beta'
)
||
targetReactVersion
.
startsWith
(
'19.0.0-rc'
)
targetReactVersion
.
startsWith
(
'19.0.0-rc'
)
)
{
)
{
devDependenciesToInstall
.
push
(
`@types/react@npm:types-react@rc`
)
corePackageNameVersionMapping
[
'@types/react'
]
=
'npm:types-react@rc'
devDependenciesToInstall
.
push
(
`@types/react-dom@npm:types-react-dom@rc`
)
corePackageNameVersionMapping
[
'@types/react-dom'
]
=
'npm:types-react-dom@rc'
}
else
{
}
else
{
const
[
targetReactTypesVersion
,
targetReactDOMTypesVersion
]
=
const
[
targetReactTypesVersion
,
targetReactDOMTypesVersion
]
=
await
Promise
.
all
([
await
Promise
.
all
([
...
@@ -195,17 +225,16 @@ export async function runUpgrade(
...
@@ -195,17 +225,16 @@ export async function runUpgrade(
`@types/react-dom@
${
targetNextPackageJson
.
peerDependencies
[
'react'
]}
`
`@types/react-dom@
${
targetNextPackageJson
.
peerDependencies
[
'react'
]}
`
),
),
])
])
devDependenciesToInstall
.
push
(
`@types/react@
${
targetReactTypesVersion
}
`
)
corePackageNameVersionMapping
[
'@types/react'
]
=
targetReactTypesVersion
devDependenciesToInstall
.
push
(
corePackageNameVersionMapping
[
'@types/react-dom'
]
=
`@types/react-dom@
${
targetReactDOMTypesVersion
}
`
targetReactDOMTypesVersion
)
}
}
console
.
log
(
console
.
log
(
`Upgrading your project to
${
pc
.
blue
(
'Next.js '
+
targetNextVersion
)}
...\n`
`Upgrading your project to
${
pc
.
blue
(
'Next.js '
+
targetNextVersion
)}
...\n`
)
)
installPackages
(
[
nextDependency
,
...
dependenciesToInstall
]
,
{
installPackages
(
dependenciesToInstall
,
{
packageManager
,
packageManager
,
silent
:
!
verbose
,
silent
:
!
verbose
,
})
})
...
...
packages/next-codemod/lib/handle-package.ts
View file @
481dee6e
...
@@ -76,6 +76,8 @@ export function installPackages(
...
@@ -76,6 +76,8 @@ export function installPackages(
dev
?:
boolean
dev
?:
boolean
}
=
{}
}
=
{}
)
{
)
{
if
(
packageToInstall
.
length
===
0
)
return
const
{
const
{
packageManager
=
getPkgManager
(
process
.
cwd
()),
packageManager
=
getPkgManager
(
process
.
cwd
()),
silent
=
false
,
silent
=
false
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment