Unverified Commit 50ff54ee authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

Use summary_large_image as twitter card if images present by default (#53919)

This is an improvement for twitter card, if there's image present we could use `summary_large_image` to make the twitter card look better instead of using `summary` by default, so that users could benefit from the large image card display on twitter
parent 9e1e9bf3
...@@ -145,9 +145,9 @@ export const resolveTwitter: FieldResolverExtraArgs< ...@@ -145,9 +145,9 @@ export const resolveTwitter: FieldResolverExtraArgs<
[ResolvedMetadata['metadataBase'], string | null] [ResolvedMetadata['metadataBase'], string | null]
> = (twitter, metadataBase, titleTemplate) => { > = (twitter, metadataBase, titleTemplate) => {
if (!twitter) return null if (!twitter) return null
let card = 'card' in twitter ? twitter.card : undefined
const resolved = { const resolved = {
...twitter, ...twitter,
card: 'card' in twitter ? twitter.card : 'summary',
title: resolveTitle(twitter.title, titleTemplate), title: resolveTitle(twitter.title, titleTemplate),
} as ResolvedTwitterMetadata } as ResolvedTwitterMetadata
for (const infoKey of TwitterBasicInfoKeys) { for (const infoKey of TwitterBasicInfoKeys) {
...@@ -156,6 +156,9 @@ export const resolveTwitter: FieldResolverExtraArgs< ...@@ -156,6 +156,9 @@ export const resolveTwitter: FieldResolverExtraArgs<
const imageMetadataBase = getSocialImageFallbackMetadataBase(metadataBase) const imageMetadataBase = getSocialImageFallbackMetadataBase(metadataBase)
resolved.images = resolveImages(twitter.images, imageMetadataBase) resolved.images = resolveImages(twitter.images, imageMetadataBase)
card = card || (resolved.images?.length ? 'summary_large_image' : 'summary')
resolved.card = card
if ('card' in resolved) { if ('card' in resolved) {
switch (resolved.card) { switch (resolved.card) {
case 'player': { case 'player': {
......
export default function page() { export default function page() {
return 'twitter summary_large_image' return 'twitter no image'
} }
export const metadata = { export const metadata = {
twitter: { twitter: {
card: 'summary_large_image',
title: 'Twitter Title', title: 'Twitter Title',
description: 'Twitter Description', description: 'Twitter Description',
siteId: 'siteId', siteId: 'siteId',
creator: 'creator', creator: 'creator',
creatorId: 'creatorId', creatorId: 'creatorId',
images: { images: undefined,
url: 'https://twitter.com/large-image.png',
alt: 'image-alt',
},
}, },
} }
...@@ -458,7 +458,7 @@ createNextDescribe( ...@@ -458,7 +458,7 @@ createNextDescribe(
}) })
await matchMultiDom('meta', 'name', 'content', { await matchMultiDom('meta', 'name', 'content', {
'twitter:card': 'summary', 'twitter:card': 'summary_large_image',
'twitter:title': 'My custom title', 'twitter:title': 'My custom title',
'twitter:description': 'My custom description', 'twitter:description': 'My custom description',
'twitter:image': [ 'twitter:image': [
...@@ -763,7 +763,7 @@ createNextDescribe( ...@@ -763,7 +763,7 @@ createNextDescribe(
}) })
describe('twitter', () => { describe('twitter', () => {
it('should support default twitter summary card', async () => { it('should support twitter card summary_large_image when image present', async () => {
const browser = await next.browser('/twitter') const browser = await next.browser('/twitter')
const matchMultiDom = createMultiDomMatcher(browser) const matchMultiDom = createMultiDomMatcher(browser)
...@@ -775,12 +775,12 @@ createNextDescribe( ...@@ -775,12 +775,12 @@ createNextDescribe(
'twitter:creator:id': 'creatorId', 'twitter:creator:id': 'creatorId',
'twitter:image': 'https://twitter.com/image.png', 'twitter:image': 'https://twitter.com/image.png',
'twitter:image:secure_url': 'https://twitter.com/secure.png', 'twitter:image:secure_url': 'https://twitter.com/secure.png',
'twitter:card': 'summary', 'twitter:card': 'summary_large_image',
}) })
}) })
it('should support default twitter summary_large_image card', async () => { it('should render twitter card summary when image is not present', async () => {
const browser = await next.browser('/twitter/large-image') const browser = await next.browser('/twitter/no-image')
const matchMultiDom = createMultiDomMatcher(browser) const matchMultiDom = createMultiDomMatcher(browser)
await matchMultiDom('meta', 'name', 'content', { await matchMultiDom('meta', 'name', 'content', {
...@@ -789,9 +789,7 @@ createNextDescribe( ...@@ -789,9 +789,7 @@ createNextDescribe(
'twitter:site:id': 'siteId', 'twitter:site:id': 'siteId',
'twitter:creator': 'creator', 'twitter:creator': 'creator',
'twitter:creator:id': 'creatorId', 'twitter:creator:id': 'creatorId',
'twitter:image': 'https://twitter.com/large-image.png', 'twitter:card': 'summary',
'twitter:image:alt': 'image-alt',
'twitter:card': 'summary_large_image',
}) })
}) })
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment