Unverified Commit 55ff46bc authored by Sebastian "Sebbie" Silbermann's avatar Sebastian "Sebbie" Silbermann Committed by GitHub

Stop testing `react-dom/server` in RSCs (#69139)

parent 49ef9782
import React from 'react' import React from 'react'
import ReactDOM from 'react-dom' import ReactDOM from 'react-dom'
import ReactDOMServer from 'react-dom/server.edge'
import ClientReact from './client-react' import ClientReact from './client-react'
export default function Page() { export default function Page() {
...@@ -8,9 +7,6 @@ export default function Page() { ...@@ -8,9 +7,6 @@ export default function Page() {
<div> <div>
<p id="react">{'React.version=' + React.version}</p> <p id="react">{'React.version=' + React.version}</p>
<p id="react-dom">{'ReactDOM.version=' + ReactDOM.version}</p> <p id="react-dom">{'ReactDOM.version=' + ReactDOM.version}</p>
<p id="react-dom-server">
{'ReactDOMServer.version=' + ReactDOMServer.version}
</p>
<ClientReact /> <ClientReact />
</div> </div>
) )
......
...@@ -545,14 +545,12 @@ describe('app dir - rsc basics', () => { ...@@ -545,14 +545,12 @@ describe('app dir - rsc basics', () => {
const [ const [
ssrReact, ssrReact,
ssrReactDOM, ssrReactDOM,
ssrReactDOMServer,
ssrClientReact, ssrClientReact,
ssrClientReactDOM, ssrClientReactDOM,
ssrClientReactDOMServer, ssrClientReactDOMServer,
] = [ ] = [
resPages$('#react').text(), resPages$('#react').text(),
resPages$('#react-dom').text(), resPages$('#react-dom').text(),
resPages$('#react-dom-server').text(),
resPages$('#client-react').text(), resPages$('#client-react').text(),
resPages$('#client-react-dom').text(), resPages$('#client-react-dom').text(),
resPages$('#client-react-dom-server').text(), resPages$('#client-react-dom-server').text(),
...@@ -560,14 +558,12 @@ describe('app dir - rsc basics', () => { ...@@ -560,14 +558,12 @@ describe('app dir - rsc basics', () => {
expect({ expect({
ssrReact, ssrReact,
ssrReactDOM, ssrReactDOM,
ssrReactDOMServer,
ssrClientReact, ssrClientReact,
ssrClientReactDOM, ssrClientReactDOM,
ssrClientReactDOMServer, ssrClientReactDOMServer,
}).toEqual({ }).toEqual({
ssrReact: expect.stringMatching(bundledReactVersionPattern), ssrReact: expect.stringMatching(bundledReactVersionPattern),
ssrReactDOM: expect.stringMatching(bundledReactVersionPattern), ssrReactDOM: expect.stringMatching(bundledReactVersionPattern),
ssrReactDOMServer: expect.stringMatching(bundledReactVersionPattern),
ssrClientReact: expect.stringMatching(bundledReactVersionPattern), ssrClientReact: expect.stringMatching(bundledReactVersionPattern),
ssrClientReactDOM: expect.stringMatching(bundledReactVersionPattern), ssrClientReactDOM: expect.stringMatching(bundledReactVersionPattern),
ssrClientReactDOMServer: expect.stringMatching( ssrClientReactDOMServer: expect.stringMatching(
...@@ -579,7 +575,6 @@ describe('app dir - rsc basics', () => { ...@@ -579,7 +575,6 @@ describe('app dir - rsc basics', () => {
const [ const [
browserReact, browserReact,
browserReactDOM, browserReactDOM,
browserReactDOMServer,
browserClientReact, browserClientReact,
browserClientReactDOM, browserClientReactDOM,
browserClientReactDOMServer, browserClientReactDOMServer,
...@@ -587,7 +582,6 @@ describe('app dir - rsc basics', () => { ...@@ -587,7 +582,6 @@ describe('app dir - rsc basics', () => {
[ [
document.querySelector('#react').innerText, document.querySelector('#react').innerText,
document.querySelector('#react-dom').innerText, document.querySelector('#react-dom').innerText,
document.querySelector('#react-dom-server').innerText,
document.querySelector('#client-react').innerText, document.querySelector('#client-react').innerText,
document.querySelector('#client-react-dom').innerText, document.querySelector('#client-react-dom').innerText,
document.querySelector('#client-react-dom-server').innerText, document.querySelector('#client-react-dom-server').innerText,
...@@ -596,14 +590,12 @@ describe('app dir - rsc basics', () => { ...@@ -596,14 +590,12 @@ describe('app dir - rsc basics', () => {
expect({ expect({
browserReact, browserReact,
browserReactDOM, browserReactDOM,
browserReactDOMServer,
browserClientReact, browserClientReact,
browserClientReactDOM, browserClientReactDOM,
browserClientReactDOMServer, browserClientReactDOMServer,
}).toEqual({ }).toEqual({
browserReact: expect.stringMatching(bundledReactVersionPattern), browserReact: expect.stringMatching(bundledReactVersionPattern),
browserReactDOM: expect.stringMatching(bundledReactVersionPattern), browserReactDOM: expect.stringMatching(bundledReactVersionPattern),
browserReactDOMServer: expect.stringMatching(bundledReactVersionPattern),
browserClientReact: expect.stringMatching(bundledReactVersionPattern), browserClientReact: expect.stringMatching(bundledReactVersionPattern),
browserClientReactDOM: expect.stringMatching(bundledReactVersionPattern), browserClientReactDOM: expect.stringMatching(bundledReactVersionPattern),
browserClientReactDOMServer: expect.stringMatching( browserClientReactDOMServer: expect.stringMatching(
...@@ -701,14 +693,12 @@ describe('app dir - rsc basics', () => { ...@@ -701,14 +693,12 @@ describe('app dir - rsc basics', () => {
const [ const [
ssrReact, ssrReact,
ssrReactDOM, ssrReactDOM,
ssrReactDOMServer,
ssrClientReact, ssrClientReact,
ssrClientReactDOM, ssrClientReactDOM,
ssrClientReactDOMServer, ssrClientReactDOMServer,
] = [ ] = [
resPages$('#react').text(), resPages$('#react').text(),
resPages$('#react-dom').text(), resPages$('#react-dom').text(),
resPages$('#react-dom-server').text(),
resPages$('#client-react').text(), resPages$('#client-react').text(),
resPages$('#client-react-dom').text(), resPages$('#client-react-dom').text(),
resPages$('#client-react-dom-server').text(), resPages$('#client-react-dom-server').text(),
...@@ -716,14 +706,12 @@ describe('app dir - rsc basics', () => { ...@@ -716,14 +706,12 @@ describe('app dir - rsc basics', () => {
expect({ expect({
ssrReact, ssrReact,
ssrReactDOM, ssrReactDOM,
ssrReactDOMServer,
ssrClientReact, ssrClientReact,
ssrClientReactDOM, ssrClientReactDOM,
ssrClientReactDOMServer, ssrClientReactDOMServer,
}).toEqual({ }).toEqual({
ssrReact: expect.stringMatching('-experimental-'), ssrReact: expect.stringMatching('-experimental-'),
ssrReactDOM: expect.stringMatching('-experimental-'), ssrReactDOM: expect.stringMatching('-experimental-'),
ssrReactDOMServer: expect.stringMatching('-experimental-'),
ssrClientReact: expect.stringMatching('-experimental-'), ssrClientReact: expect.stringMatching('-experimental-'),
ssrClientReactDOM: expect.stringMatching('-experimental-'), ssrClientReactDOM: expect.stringMatching('-experimental-'),
ssrClientReactDOMServer: expect.stringMatching('-experimental-'), ssrClientReactDOMServer: expect.stringMatching('-experimental-'),
...@@ -733,7 +721,6 @@ describe('app dir - rsc basics', () => { ...@@ -733,7 +721,6 @@ describe('app dir - rsc basics', () => {
const [ const [
browserReact, browserReact,
browserReactDOM, browserReactDOM,
browserReactDOMServer,
browserClientReact, browserClientReact,
browserClientReactDOM, browserClientReactDOM,
browserClientReactDOMServer, browserClientReactDOMServer,
...@@ -741,7 +728,6 @@ describe('app dir - rsc basics', () => { ...@@ -741,7 +728,6 @@ describe('app dir - rsc basics', () => {
[ [
document.querySelector('#react').innerText, document.querySelector('#react').innerText,
document.querySelector('#react-dom').innerText, document.querySelector('#react-dom').innerText,
document.querySelector('#react-dom-server').innerText,
document.querySelector('#client-react').innerText, document.querySelector('#client-react').innerText,
document.querySelector('#client-react-dom').innerText, document.querySelector('#client-react-dom').innerText,
document.querySelector('#client-react-dom-server').innerText, document.querySelector('#client-react-dom-server').innerText,
...@@ -750,14 +736,12 @@ describe('app dir - rsc basics', () => { ...@@ -750,14 +736,12 @@ describe('app dir - rsc basics', () => {
expect({ expect({
browserReact, browserReact,
browserReactDOM, browserReactDOM,
browserReactDOMServer,
browserClientReact, browserClientReact,
browserClientReactDOM, browserClientReactDOM,
browserClientReactDOMServer, browserClientReactDOMServer,
}).toEqual({ }).toEqual({
browserReact: expect.stringMatching('-experimental-'), browserReact: expect.stringMatching('-experimental-'),
browserReactDOM: expect.stringMatching('-experimental-'), browserReactDOM: expect.stringMatching('-experimental-'),
browserReactDOMServer: expect.stringMatching('-experimental-'),
browserClientReact: expect.stringMatching('-experimental-'), browserClientReact: expect.stringMatching('-experimental-'),
browserClientReactDOM: expect.stringMatching('-experimental-'), browserClientReactDOM: expect.stringMatching('-experimental-'),
browserClientReactDOMServer: browserClientReactDOMServer:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment