Unverified Commit 5778f9ff authored by Maia Teegarden's avatar Maia Teegarden Committed by GitHub

Remove error that is too strict in next/dynamic swc transform (#29511)

parent cee573f5
This diff is collapsed.
...@@ -16,12 +16,11 @@ path-clean = "0.1" ...@@ -16,12 +16,11 @@ path-clean = "0.1"
regex = "1.5" regex = "1.5"
serde = "1" serde = "1"
serde_json = "1" serde_json = "1"
swc = "0.59.1" swc = "0.60"
swc_atoms = "0.2" swc_atoms = "0.2"
swc_common = { version = "0.13.0", features = ["concurrent", "sourcemap"] } swc_common = { version = "0.13", features = ["concurrent", "sourcemap"] }
swc_css = "0.8.2" swc_css = "0.8.2"
swc_css_codegen = "0.6.0" swc_ecmascript = { version = "0.68", features = ["codegen", "minifier", "optimization", "parser", "react", "transforms", "typescript", "utils", "visit"] }
swc_ecmascript = { version = "0.67.0", features = ["codegen", "minifier", "optimization", "parser", "react", "transforms", "typescript", "utils", "visit"] }
swc_ecma_preset_env = "0.46.0" swc_ecma_preset_env = "0.46.0"
swc_node_base = "0.4.0" swc_node_base = "0.4.0"
swc_stylis = "0.5.0" swc_stylis = "0.5.0"
......
...@@ -92,15 +92,6 @@ impl Fold for NextDynamicPatcher { ...@@ -92,15 +92,6 @@ impl Fold for NextDynamicPatcher {
self.is_next_dynamic_first_arg = false; self.is_next_dynamic_first_arg = false;
if let None = self.dynamically_imported_specifier { if let None = self.dynamically_imported_specifier {
HANDLER.with(|handler| {
handler
.struct_span_err(
identifier.span,
"First argument for next/dynamic must be an arrow function returning a valid \
dynamic import call e.g. `dynamic(() => import('../some-component'))`",
)
.emit()
});
return expr; return expr;
} }
......
...@@ -2,12 +2,12 @@ use easy_error::{bail, Error}; ...@@ -2,12 +2,12 @@ use easy_error::{bail, Error};
use std::panic; use std::panic;
use swc_common::{source_map::Pos, BytePos, Span, SyntaxContext, DUMMY_SP}; use swc_common::{source_map::Pos, BytePos, Span, SyntaxContext, DUMMY_SP};
use swc_css::ast::*; use swc_css::ast::*;
use swc_css::parser::{parse_str, parse_tokens, parser::ParserConfig}; use swc_css::codegen::{
use swc_css::visit::{VisitMut, VisitMutWith};
use swc_css_codegen::{
writer::basic::{BasicCssWriter, BasicCssWriterConfig}, writer::basic::{BasicCssWriter, BasicCssWriterConfig},
CodegenConfig, Emit, CodeGenerator, CodegenConfig, Emit,
}; };
use swc_css::parser::{parse_str, parse_tokens, parser::ParserConfig};
use swc_css::visit::{VisitMut, VisitMutWith};
use swc_ecmascript::ast::{Expr, Str, StrKind, Tpl, TplElement}; use swc_ecmascript::ast::{Expr, Str, StrKind, Tpl, TplElement};
use swc_ecmascript::utils::HANDLER; use swc_ecmascript::utils::HANDLER;
use swc_stylis::prefixer::prefixer; use swc_stylis::prefixer::prefixer;
...@@ -63,7 +63,7 @@ pub fn transform_css( ...@@ -63,7 +63,7 @@ pub fn transform_css(
let mut s = String::new(); let mut s = String::new();
{ {
let mut wr = BasicCssWriter::new(&mut s, BasicCssWriterConfig { indent: " " }); let mut wr = BasicCssWriter::new(&mut s, BasicCssWriterConfig { indent: " " });
let mut gen = swc_css_codegen::CodeGenerator::new(&mut wr, CodegenConfig { minify: true }); let mut gen = CodeGenerator::new(&mut wr, CodegenConfig { minify: true });
gen.emit(&ss).unwrap(); gen.emit(&ss).unwrap();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment