Unverified Commit 580d01a2 authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

[metadata] remove falsy dynamicParams approach (#84405)

parent 28b64e2f
...@@ -291,7 +291,6 @@ async fn dynamic_sitemap_route_with_generate_source( ...@@ -291,7 +291,6 @@ async fn dynamic_sitemap_route_with_generate_source(
const paramsPromise = ctx.params const paramsPromise = ctx.params
const idPromise = paramsPromise.then(params => params?.__metadata_id__) const idPromise = paramsPromise.then(params => params?.__metadata_id__)
if (process.env.NODE_ENV !== 'production') {{
const id = await idPromise const id = await idPromise
const hasXmlExtension = id ? id.endsWith('.xml') : false const hasXmlExtension = id ? id.endsWith('.xml') : false
const sitemaps = await generateSitemaps() const sitemaps = await generateSitemaps()
...@@ -310,7 +309,6 @@ async fn dynamic_sitemap_route_with_generate_source( ...@@ -310,7 +309,6 @@ async fn dynamic_sitemap_route_with_generate_source(
status: 404, status: 404,
}}) }})
}} }}
}}
const targetIdPromise = idPromise.then(id => {{ const targetIdPromise = idPromise.then(id => {{
const hasXmlExtension = id ? id.endsWith('.xml') : false const hasXmlExtension = id ? id.endsWith('.xml') : false
...@@ -329,7 +327,6 @@ async fn dynamic_sitemap_route_with_generate_source( ...@@ -329,7 +327,6 @@ async fn dynamic_sitemap_route_with_generate_source(
export * from {resource_path} export * from {resource_path}
export const dynamicParams = false
export async function generateStaticParams() {{ export async function generateStaticParams() {{
const sitemaps = await generateSitemaps() const sitemaps = await generateSitemaps()
const params = [] const params = []
...@@ -446,7 +443,6 @@ async fn dynamic_image_route_with_metadata_source( ...@@ -446,7 +443,6 @@ async fn dynamic_image_route_with_metadata_source(
return rest return rest
}}) }})
if (process.env.NODE_ENV !== 'production') {{
const restParams = await restParamsPromise const restParams = await restParamsPromise
const __metadata_id__ = await idPromise const __metadata_id__ = await idPromise
const imageMetadata = await generateImageMetadata({{ params: restParams }}) const imageMetadata = await generateImageMetadata({{ params: restParams }})
...@@ -463,14 +459,12 @@ async fn dynamic_image_route_with_metadata_source( ...@@ -463,14 +459,12 @@ async fn dynamic_image_route_with_metadata_source(
status: 404, status: 404,
}}) }})
}} }}
}}
return handler({{ params: restParamsPromise, id: idPromise }}) return handler({{ params: restParamsPromise, id: idPromise }})
}} }}
export * from {resource_path} export * from {resource_path}
export const dynamicParams = false
export async function generateStaticParams({{ params }}) {{ export async function generateStaticParams({{ params }}) {{
const imageMetadata = await generateImageMetadata({{ params }}) const imageMetadata = await generateImageMetadata({{ params }})
const staticParams = [] const staticParams = []
......
...@@ -177,8 +177,6 @@ export async function GET(_, ctx) { ...@@ -177,8 +177,6 @@ export async function GET(_, ctx) {
return rest return rest
}) })
${/* we need a dev assertion for id since dynamicParams=false won't work well in dev */ ''}
if (process.env.NODE_ENV !== 'production') {
const restParams = await restParamsPromise const restParams = await restParamsPromise
const __metadata_id__ = await idPromise const __metadata_id__ = await idPromise
const imageMetadata = await generateImageMetadata({ params: restParams }) const imageMetadata = await generateImageMetadata({ params: restParams })
...@@ -195,12 +193,10 @@ export async function GET(_, ctx) { ...@@ -195,12 +193,10 @@ export async function GET(_, ctx) {
status: 404, status: 404,
}) })
} }
}
return handler({ params: restParamsPromise, id: idPromise }) return handler({ params: restParamsPromise, id: idPromise })
} }
export const dynamicParams = false
export async function generateStaticParams({ params }) { export async function generateStaticParams({ params }) {
const imageMetadata = await generateImageMetadata({ params }) const imageMetadata = await generateImageMetadata({ params })
const staticParams = [] const staticParams = []
...@@ -303,7 +299,6 @@ export async function GET(_, ctx) { ...@@ -303,7 +299,6 @@ export async function GET(_, ctx) {
const paramsPromise = ctx.params const paramsPromise = ctx.params
const idPromise = paramsPromise.then(params => params?.__metadata_id__) const idPromise = paramsPromise.then(params => params?.__metadata_id__)
if (process.env.NODE_ENV !== 'production') {
const id = await idPromise const id = await idPromise
const hasXmlExtension = id ? id.endsWith('.xml') : false const hasXmlExtension = id ? id.endsWith('.xml') : false
const sitemaps = await generateSitemaps() const sitemaps = await generateSitemaps()
...@@ -323,7 +318,6 @@ export async function GET(_, ctx) { ...@@ -323,7 +318,6 @@ export async function GET(_, ctx) {
status: 404, status: 404,
}) })
} }
}
const targetIdPromise = idPromise.then(id => { const targetIdPromise = idPromise.then(id => {
const hasXmlExtension = id ? id.endsWith('.xml') : false const hasXmlExtension = id ? id.endsWith('.xml') : false
...@@ -340,7 +334,6 @@ export async function GET(_, ctx) { ...@@ -340,7 +334,6 @@ export async function GET(_, ctx) {
}) })
} }
export const dynamicParams = false
export async function generateStaticParams() { export async function generateStaticParams() {
const sitemaps = await generateSitemaps() const sitemaps = await generateSitemaps()
const params = [] const params = []
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment