Unverified Commit 5ca02a87 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Fix actions redirect handling (#49483)

This ensures we properly strip conflicting headers from being forwarded
when handling the redirect request/response in actions.

x-ref: [slack
thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1683218335368759)

Fixes: 

```sh
failed to get redirect response TypeError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:11413:11) {
  cause: RequestContentLengthMismatchError: Request body length does not match content-length header
      at write (node:internal/deps/undici/undici:9907:41)
      at _resume (node:internal/deps/undici/undici:9885:33)
      at resume (node:internal/deps/undici/undici:9787:7)
      at connect (node:internal/deps/undici/undici:9776:7) {
    code: 'UND_ERR_REQ_CONTENT_LENGTH_MISMATCH'
  }
}
```
parent b20d5f2d
...@@ -21,6 +21,7 @@ import { StaticGenerationStore } from '../../client/components/static-generation ...@@ -21,6 +21,7 @@ import { StaticGenerationStore } from '../../client/components/static-generation
import { FlightRenderResult } from './flight-render-result' import { FlightRenderResult } from './flight-render-result'
import { ActionResult } from './types' import { ActionResult } from './types'
import { ActionAsyncStorage } from '../../client/components/action-async-storage' import { ActionAsyncStorage } from '../../client/components/action-async-storage'
import { filterReqHeaders, forbiddenHeaders } from '../lib/server-ipc/utils'
function nodeToWebReadableStream(nodeReadable: import('stream').Readable) { function nodeToWebReadableStream(nodeReadable: import('stream').Readable) {
if (process.env.NEXT_RUNTIME !== 'edge') { if (process.env.NEXT_RUNTIME !== 'edge') {
...@@ -90,10 +91,10 @@ function getForwardedHeaders( ...@@ -90,10 +91,10 @@ function getForwardedHeaders(
}) })
// Merge request and response headers // Merge request and response headers
const mergedHeaders = { const mergedHeaders = filterReqHeaders({
...nodeHeadersToRecord(requestHeaders), ...nodeHeadersToRecord(requestHeaders),
...nodeHeadersToRecord(responseHeaders), ...nodeHeadersToRecord(responseHeaders),
} }) as Record<string, string>
// Merge cookies // Merge cookies
const mergedCookies = requestCookies.split('; ').concat(setCookies).join('; ') const mergedCookies = requestCookies.split('; ').concat(setCookies).join('; ')
...@@ -177,13 +178,16 @@ async function createRedirectRenderResult( ...@@ -177,13 +178,16 @@ async function createRedirectRenderResult(
}) })
// copy the headers from the redirect response to the response we're sending // copy the headers from the redirect response to the response we're sending
for (const [key, value] of response.headers) { for (const [key, value] of response.headers) {
if (!forbiddenHeaders.includes(key)) {
res.setHeader(key, value) res.setHeader(key, value)
} }
}
return new FlightRenderResult(response.body!) return new FlightRenderResult(response.body!)
} }
} catch (err) { } catch (err) {
// we couldn't stream the redirect response, so we'll just do a normal redirect // we couldn't stream the redirect response, so we'll just do a normal redirect
console.error(`failed to get redirect response`, err)
} }
} }
return new RenderResult(JSON.stringify({})) return new RenderResult(JSON.stringify({}))
......
const forbiddenHeaders = [ export const forbiddenHeaders = [
'accept-encoding', 'accept-encoding',
'content-length', 'content-length',
'keepalive', 'keepalive',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment