Unverified Commit 69acc33f authored by Sebastian "Sebbie" Silbermann's avatar Sebastian "Sebbie" Silbermann Committed by GitHub

[ci] Make automatic native binding install opt-in (#95114)

A `pnpm install` installs native bindings for Next.js by default. This
makes sense for local development where half of the team doesn't work on
native code and just needs the most recent bindings. However, CI almost
exclusively wants to test with bindings that are built from the current
commit. The rest doesn't need native bindings at all.

The only exception is `test_examples` which is likely not functional.
Though we still support it by allowing to opt-into automatically
installing native bindings in CI.

## test plan

- [x] fetch test timings still skips:
https://github.com/vercel/next.js/actions/runs/28087707205/job/83157705446?pr=95114#step:7:228
parent 3c64106f
...@@ -136,9 +136,6 @@ jobs: ...@@ -136,9 +136,6 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
env: env:
NEXT_TELEMETRY_DISABLED: 1 NEXT_TELEMETRY_DISABLED: 1
# we build a dev binary for use in CI so skip downloading
# canary next-swc binaries in the monorepo
NEXT_SKIP_NATIVE_POSTINSTALL: 1
steps: steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with: with:
......
...@@ -147,8 +147,6 @@ jobs: ...@@ -147,8 +147,6 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: ['changes'] needs: ['changes']
if: ${{ needs.changes.outputs.docs-only == 'false' }} if: ${{ needs.changes.outputs.docs-only == 'false' }}
env:
NEXT_SKIP_NATIVE_POSTINSTALL: 1
steps: steps:
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
......
...@@ -123,8 +123,10 @@ env: ...@@ -123,8 +123,10 @@ env:
TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }} TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
NEXT_TELEMETRY_DISABLED: 1 NEXT_TELEMETRY_DISABLED: 1
# allow not skipping install-native postinstall script if we don't have a binary available already # `skipNativeInstall: 'no'` must force the download even though CI otherwise
NEXT_SKIP_NATIVE_POSTINSTALL: ${{ inputs.skipNativeInstall == 'yes' && '1' || '' }} # skips it by default (see scripts/install-native.mjs), so emit an explicit
# '0' rather than an empty value.
NEXT_SKIP_NATIVE_POSTINSTALL: ${{ inputs.skipNativeInstall == 'yes' && '1' || '0' }}
DATADOG_API_KEY: ${{ secrets.DATA_DOG_API_KEY }} DATADOG_API_KEY: ${{ secrets.DATA_DOG_API_KEY }}
NEXT_JUNIT_TEST_REPORT: 'true' NEXT_JUNIT_TEST_REPORT: 'true'
DD_ENV: 'ci' DD_ENV: 'ci'
......
...@@ -24,9 +24,6 @@ jobs: ...@@ -24,9 +24,6 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
env: env:
NEXT_TELEMETRY_DISABLED: 1 NEXT_TELEMETRY_DISABLED: 1
# we build a dev binary for use in CI so skip downloading
# canary next-swc binaries in the monorepo
NEXT_SKIP_NATIVE_POSTINSTALL: 1
steps: steps:
- name: Setup node - name: Setup node
......
...@@ -23,9 +23,6 @@ env: ...@@ -23,9 +23,6 @@ env:
TURBO_CACHE: 'local:rw,remote:rw' TURBO_CACHE: 'local:rw,remote:rw'
TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }} TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
NEXT_TELEMETRY_DISABLED: 1 NEXT_TELEMETRY_DISABLED: 1
# we build a dev binary for use in CI so skip downloading
# canary next-swc binaries in the monorepo
NEXT_SKIP_NATIVE_POSTINSTALL: 1
# Vercel KV Store for test timings # Vercel KV Store for test timings
KV_REST_API_URL: ${{ secrets.KV_REST_API_URL }} KV_REST_API_URL: ${{ secrets.KV_REST_API_URL }}
KV_REST_API_TOKEN: ${{ secrets.KV_REST_API_TOKEN }} KV_REST_API_TOKEN: ${{ secrets.KV_REST_API_TOKEN }}
......
...@@ -22,6 +22,10 @@ jobs: ...@@ -22,6 +22,10 @@ jobs:
timeout-minutes: 120 timeout-minutes: 120
env: env:
NEXT_TELEMETRY_DISABLED: 1 NEXT_TELEMETRY_DISABLED: 1
# This job runs `pnpm build` (JS only) and runs the example apps, so it
# needs the published next-swc binary. Opt back into the download since CI
# skips it by default (see scripts/install-native.mjs).
NEXT_SKIP_NATIVE_POSTINSTALL: 0
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
......
...@@ -42,9 +42,6 @@ jobs: ...@@ -42,9 +42,6 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
env: env:
NEXT_TELEMETRY_DISABLED: 1 NEXT_TELEMETRY_DISABLED: 1
# we build a dev binary for use in CI so skip downloading
# canary next-swc binaries in the monorepo
NEXT_SKIP_NATIVE_POSTINSTALL: 1
steps: steps:
- name: Setup node - name: Setup node
......
...@@ -13,11 +13,6 @@ permissions: ...@@ -13,11 +13,6 @@ permissions:
actions: read actions: read
contents: read contents: read
env:
# Not needed. Just breaks the job needlessly while a new canary version is
# being published.
NEXT_SKIP_NATIVE_POSTINSTALL: 1
jobs: jobs:
upload: upload:
name: Upload preview tarballs to Blob name: Upload preview tarballs to Blob
......
...@@ -5,9 +5,17 @@ import fs from 'fs' ...@@ -5,9 +5,17 @@ import fs from 'fs'
import fsp from 'fs/promises' import fsp from 'fs/promises'
import { outdent } from 'outdent' import { outdent } from 'outdent'
;(async function () { ;(async function () {
if (process.env.NEXT_SKIP_NATIVE_POSTINSTALL) { // Automatically installing native bindings is opt-in in CI and opt-out in local development.
// Most CI jobs use native bindings built from the commit they run on anyway.
const rawSkip = process.env.NEXT_SKIP_NATIVE_POSTINSTALL
const skipNativePostinstall =
rawSkip == null || rawSkip === ''
? process.env.CI === 'true'
: rawSkip !== '0' && rawSkip !== 'false'
if (skipNativePostinstall) {
console.log( console.log(
`Skipping next-swc postinstall due to NEXT_SKIP_NATIVE_POSTINSTALL env` `Skipping next-swc postinstall (NEXT_SKIP_NATIVE_POSTINSTALL=${String(JSON.stringify(rawSkip))}, CI=${String(JSON.stringify(process.env.CI))})`
) )
return return
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment