Unverified Commit 6f76e91d authored by Sebastian "Sebbie" Silbermann's avatar Sebastian "Sebbie" Silbermann Committed by GitHub

[dev-overlay] Remove unused `onError` in /pages (#79982)

Every implementation is a no-op and we don't have any plans.
Can use the same pattern as App Router when we need it.
parent 5a4a08fd
...@@ -27,16 +27,8 @@ export const usePagesDevOverlay = () => { ...@@ -27,16 +27,8 @@ export const usePagesDevOverlay = () => {
} }
}, [dispatch]) }, [dispatch])
const onComponentError = React.useCallback(
(_error: Error, _componentStack: string | null) => {
// TODO: special handling
},
[]
)
return { return {
state, state,
onComponentError,
dispatch, dispatch,
} }
} }
...@@ -2,7 +2,6 @@ import React from 'react' ...@@ -2,7 +2,6 @@ import React from 'react'
type PagesDevOverlayErrorBoundaryProps = { type PagesDevOverlayErrorBoundaryProps = {
children?: React.ReactNode children?: React.ReactNode
onError: (error: Error, componentStack: string | null) => void
} }
type PagesDevOverlayErrorBoundaryState = { error: Error | null } type PagesDevOverlayErrorBoundaryState = { error: Error | null }
...@@ -16,13 +15,7 @@ export class PagesDevOverlayErrorBoundary extends React.PureComponent< ...@@ -16,13 +15,7 @@ export class PagesDevOverlayErrorBoundary extends React.PureComponent<
return { error } return { error }
} }
componentDidCatch( componentDidCatch(error: Error) {
error: Error,
// Loosely typed because it depends on the React version and was
// accidentally excluded in some versions.
errorInfo?: { componentStack?: string | null }
) {
this.props.onError(error, errorInfo?.componentStack || null)
this.setState({ error }) this.setState({ error })
} }
......
...@@ -13,11 +13,11 @@ interface PagesDevOverlayProps { ...@@ -13,11 +13,11 @@ interface PagesDevOverlayProps {
} }
export function PagesDevOverlay({ children }: PagesDevOverlayProps) { export function PagesDevOverlay({ children }: PagesDevOverlayProps) {
const { state, dispatch, onComponentError } = usePagesDevOverlay() const { state, dispatch } = usePagesDevOverlay()
return ( return (
<> <>
<PagesDevOverlayErrorBoundary onError={onComponentError}> <PagesDevOverlayErrorBoundary>
{children ?? null} {children ?? null}
</PagesDevOverlayErrorBoundary> </PagesDevOverlayErrorBoundary>
......
...@@ -105,7 +105,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -105,7 +105,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Mismatch> <Mismatch>
...@@ -211,7 +211,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -211,7 +211,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Mismatch> <Mismatch>
...@@ -302,7 +302,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -302,7 +302,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Mismatch> <Mismatch>
...@@ -378,7 +378,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -378,7 +378,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Mismatch> <Mismatch>
...@@ -449,7 +449,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -449,7 +449,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Mismatch> <Mismatch>
...@@ -539,7 +539,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -539,7 +539,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
"componentStack": "... "componentStack": "...
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Page> <Page>
...@@ -628,7 +628,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -628,7 +628,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Page> <Page>
...@@ -722,7 +722,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -722,7 +722,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
{ {
"componentStack": "... "componentStack": "...
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Mismatch> <Mismatch>
...@@ -846,7 +846,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -846,7 +846,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Page> <Page>
...@@ -940,7 +940,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -940,7 +940,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
"componentStack": "... "componentStack": "...
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Page> <Page>
...@@ -1026,7 +1026,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -1026,7 +1026,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Page> <Page>
...@@ -1120,7 +1120,7 @@ describe('Error overlay for hydration errors in Pages router', () => { ...@@ -1120,7 +1120,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
<AppContainer> <AppContainer>
<Container fn={function fn}> <Container fn={function fn}>
<PagesDevOverlay> <PagesDevOverlay>
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}> <PagesDevOverlayErrorBoundary>
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}> <PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}> <App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
<Page> <Page>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment