Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
72baaebb
Unverified
Commit
72baaebb
authored
Jan 30, 2023
by
Hannes Bornö
Committed by
GitHub
Jan 30, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move error recovery test to new file (#45407)
parent
c7deecfd
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
513 additions
and
609 deletions
+513
-609
ReactRefreshLogBox.test.ts
test/development/acceptance-app/ReactRefreshLogBox.test.ts
+0
-493
ReactRefreshLogBox.test.ts.snap
...eptance-app/__snapshots__/ReactRefreshLogBox.test.ts.snap
+0
-116
error-recovery.test.ts
test/development/acceptance-app/error-recovery.test.ts
+504
-0
page.js
...ceptance-app/fixtures/default-template/app/client/page.js
+5
-0
page.js
...ceptance-app/fixtures/default-template/app/server/page.js
+4
-0
No files found.
test/development/acceptance-app/ReactRefreshLogBox.test.ts
View file @
72baaebb
...
...
@@ -53,372 +53,6 @@ for (const variant of ['default', 'turbo']) {
await
cleanup
()
})
test
(
'logbox: can recover from a syntax error without losing state'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
'index.js'
,
`
import { useCallback, useState } from 'react'
export default function Index() {
const [count, setCount] = useState(0)
const increment = useCallback(() => setCount(c => c + 1), [setCount])
return (
<main>
<p>{count}</p>
<button onClick={increment}>Increment</button>
</main>
)
}
`
)
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'button'
).
click
())
expect
(
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'1'
)
await
session
.
patch
(
'index.js'
,
`export default () => <div/`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
await
session
.
patch
(
'index.js'
,
`
import { useCallback, useState } from 'react'
export default function Index() {
const [count, setCount] = useState(0)
const increment = useCallback(() => setCount(c => c + 1), [setCount])
return (
<main>
<p>Count: {count}</p>
<button onClick={increment}>Increment</button>
</main>
)
}
`
)
await
check
(
()
=>
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
),
/Count: 1/
)
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
await
cleanup
()
})
test
(
'logbox: can recover from a event handler error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
'index.js'
,
`
import { useCallback, useState } from 'react'
export default function Index() {
const [count, setCount] = useState(0)
const increment = useCallback(() => {
setCount(c => c + 1)
throw new Error('oops')
}, [setCount])
return (
<main>
<p>{count}</p>
<button onClick={increment}>Increment</button>
</main>
)
}
`
)
expect
(
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'0'
)
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'button'
).
click
())
expect
(
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'1'
)
await
session
.
waitForAndOpenRuntimeError
()
if
(
process
.
platform
===
'win32'
)
{
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
}
else
{
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
}
await
session
.
patch
(
'index.js'
,
`
import { useCallback, useState } from 'react'
export default function Index() {
const [count, setCount] = useState(0)
const increment = useCallback(() => setCount(c => c + 1), [setCount])
return (
<main>
<p>Count: {count}</p>
<button onClick={increment}>Increment</button>
</main>
)
}
`
)
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
expect
(
await
session
.
hasErrorToast
()).
toBe
(
false
)
expect
(
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'Count: 1'
)
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'button'
).
click
())
expect
(
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'Count: 2'
)
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
expect
(
await
session
.
hasErrorToast
()).
toBe
(
false
)
await
cleanup
()
})
test
(
'logbox: can recover from a component error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
write
(
'child.js'
,
`
export default function Child() {
return <p>Hello</p>;
}
`
)
await
session
.
patch
(
'index.js'
,
`
import Child from './child'
export default function Index() {
return (
<main>
<Child />
</main>
)
}
`
)
expect
(
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'Hello'
)
await
session
.
patch
(
'child.js'
,
`
// hello
export default function Child() {
throw new Error('oops')
}
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
// TODO-APP: re-enable when error recovery doesn't reload the page.
/* const didNotReload = */
await
session
.
patch
(
'child.js'
,
`
export default function Child() {
return <p>Hello</p>;
}
`
)
// TODO-APP: re-enable when error recovery doesn't reload the page.
// expect(didNotReload).toBe(true)
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
expect
(
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'Hello'
)
await
cleanup
()
})
test
(
'server component can recover from syntax error'
,
async
()
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
next
,
new
Map
([
[
'app/page.js'
,
`
export default function Page() {
return <p>Hello world</p>
}
`
,
],
])
)
// Add syntax error
await
session
.
patch
(
'app/page.js'
,
`
export default function Page() {
return <p>Hello world</p>
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
// Fix syntax error
await
session
.
patch
(
'app/page.js'
,
`
export default function Page() {
return <p>Hello world 2</p>
}
`
)
await
check
(()
=>
browser
.
elementByCss
(
'p'
).
text
(),
'Hello world 2'
)
await
cleanup
()
})
test
(
'server component can recover from component error'
,
async
()
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
next
,
new
Map
([
[
'app/page.js'
,
`
export default function Page() {
return <p>Hello world</p>
}
`
,
],
])
)
// Add component error
await
session
.
patch
(
'app/page.js'
,
`
export default function Page() {
throw new Error("boom")
return <p>Hello world</p>
}
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
// Fix component error
await
session
.
patch
(
'app/page.js'
,
`
export default function Page() {
return <p>Hello world 2</p>
}
`
)
expect
(
await
browser
.
waitForElementByCss
(
'p'
).
text
()).
toBe
(
'Hello world 2'
)
await
cleanup
()
})
// https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/3#issuecomment-554137262
test
(
'render error not shown right after syntax error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
// Starting here:
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
class ClassDefault extends React.Component {
render() {
return <h1>Default Export</h1>;
}
}
export default ClassDefault;
`
)
expect
(
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'h1'
).
textContent
)
).
toBe
(
'Default Export'
)
// Break it with a syntax error:
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
class ClassDefault extends React.Component {
render()
return <h1>Default Export</h1>;
}
}
export default ClassDefault;
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
// Now change the code to introduce a runtime error without fixing the syntax error:
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
class ClassDefault extends React.Component {
render()
throw new Error('nooo');
return <h1>Default Export</h1>;
}
}
export default ClassDefault;
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
// Now fix the syntax error:
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
class ClassDefault extends React.Component {
render() {
throw new Error('nooo');
return <h1>Default Export</h1>;
}
}
export default ClassDefault;
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
await
check
(
async
()
=>
{
const
source
=
await
session
.
getRedboxSource
()
return
source
?.
length
>
1
?
'success'
:
source
},
'success'
)
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
await
cleanup
()
})
// https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/3#issuecomment-554137807
test
(
'module init error not shown'
,
async
()
=>
{
// Start here:
...
...
@@ -468,133 +102,6 @@ for (const variant of ['default', 'turbo']) {
await
cleanup
()
})
// https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/3#issuecomment-554144016
test
(
'stuck error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
// We start here.
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
function FunctionDefault() {
return <h1>Default Export Function</h1>;
}
export default FunctionDefault;
`
)
// We add a new file. Let's call it Foo.js.
await
session
.
write
(
'Foo.js'
,
`
// intentionally skips export
export default function Foo() {
return React.createElement('h1', null, 'Foo');
}
`
)
// We edit our first file to use it.
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
import Foo from './Foo';
function FunctionDefault() {
return <Foo />;
}
export default FunctionDefault;
`
)
// We get an error because Foo didn't import React. Fair.
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
// Let's add that to Foo.
await
session
.
patch
(
'Foo.js'
,
`
import * as React from 'react';
export default function Foo() {
return React.createElement('h1', null, 'Foo');
}
`
)
// Expected: this fixes the problem
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
await
cleanup
()
})
// https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/3#issuecomment-554150098
test
(
'syntax > runtime error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
// Start here.
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
export default function FunctionNamed() {
return <div />
}
`
)
// TODO: this acts weird without above step
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
let i = 0
setInterval(() => {
i++
throw Error('no ' + i)
}, 1000)
export default function FunctionNamed() {
return <div />
}
`
)
await
new
Promise
((
resolve
)
=>
setTimeout
(
resolve
,
1000
))
await
session
.
waitForAndOpenRuntimeError
()
if
(
process
.
platform
===
'win32'
)
{
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
}
else
{
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
}
// Make a syntax error.
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
let i = 0
setInterval(() => {
i++
throw Error('no ' + i)
}, 1000)
export default function FunctionNamed() {`
)
await
new
Promise
((
resolve
)
=>
setTimeout
(
resolve
,
1000
))
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
// Test that runtime error does not take over:
await
new
Promise
((
resolve
)
=>
setTimeout
(
resolve
,
2000
))
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toMatchSnapshot
()
await
cleanup
()
})
// https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/3#issuecomment-554152127
test
(
'boundaries'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
...
...
test/development/acceptance-app/__snapshots__/ReactRefreshLogBox.test.ts.snap
View file @
72baaebb
...
...
@@ -76,45 +76,6 @@ exports[`ReactRefreshLogBox app default logbox: anchors links in error messages
exports[`ReactRefreshLogBox app default logbox: anchors links in error messages 9`] = `"http://example.com/"`;
exports[`ReactRefreshLogBox app default logbox: can recover from a component error 1`] = `
"child.js (4:16) @ Child
2 | // hello
3 | export default function Child() {
> 4 | throw new Error('oops')
| ^
5 | }
6 | "
`;
exports[`ReactRefreshLogBox app default logbox: can recover from a event handler error 1`] = `
"index.js (8:18) @ eval
6 | const increment = useCallback(() => {
7 | setCount(c => c + 1)
> 8 | throw new Error('oops')
| ^
9 | }, [setCount])
10 | return (
11 | <main>"
`;
exports[`ReactRefreshLogBox app default logbox: can recover from a syntax error without losing state 1`] = `
"./index.js
Error:
x Unexpected eof
,----
1 | export default () => <div/
\`----
Caused by:
Syntax Error
Import trace for requested module:
./index.js
./app/page.js"
`;
exports[`ReactRefreshLogBox app default module init error not shown 1`] = `
"index.js (4:14) @ eval
...
...
@@ -127,18 +88,6 @@ exports[`ReactRefreshLogBox app default module init error not shown 1`] = `
7 | return <h1>Default Export</h1>;"
`;
exports[`ReactRefreshLogBox app default render error not shown right after syntax error 1`] = `
"index.js (6:18) @ ClassDefault.render
4 | class ClassDefault extends React.Component {
5 | render() {
> 6 | throw new Error('nooo');
| ^
7 | return <h1>Default Export</h1>;
8 | }
9 | }"
`;
exports[`ReactRefreshLogBox app default should strip whitespace correctly with newline 1`] = `
"index.js (9:34) @ onClick
...
...
@@ -151,71 +100,6 @@ exports[`ReactRefreshLogBox app default should strip whitespace correctly with n
12 | </a>"
`;
exports[`ReactRefreshLogBox app default stuck error 1`] = `
"Foo.js (4:10) @ Foo
2 | // intentionally skips export
3 | export default function Foo() {
> 4 | return React.createElement('h1', null, 'Foo');
| ^
5 | }
6 | "
`;
exports[`ReactRefreshLogBox app default syntax > runtime error 1`] = `
"index.js (6:16) @ Error
4 | setInterval(() => {
5 | i++
> 6 | throw Error('no ' + i)
| ^
7 | }, 1000)
8 | export default function FunctionNamed() {
9 | return <div />"
`;
exports[`ReactRefreshLogBox app default syntax > runtime error 2`] = `
"./index.js
Error:
x Expected '}', got '<eof>'
,-[5:1]
5 | i++
6 | throw Error('no ' + i)
7 | }, 1000)
8 | export default function FunctionNamed() {
: ^
\`----
Caused by:
0: error was recoverable, but proceeding would result in wrong codegen
1: Syntax Error
Import trace for requested module:
./index.js
./app/page.js"
`;
exports[`ReactRefreshLogBox app default syntax > runtime error 3`] = `
"./index.js
Error:
x Expected '}', got '<eof>'
,-[5:1]
5 | i++
6 | throw Error('no ' + i)
7 | }, 1000)
8 | export default function FunctionNamed() {
: ^
\`----
Caused by:
0: error was recoverable, but proceeding would result in wrong codegen
1: Syntax Error
Import trace for requested module:
./index.js
./app/page.js"
`;
exports[`ReactRefreshLogBox app default unterminated JSX 1`] = `
"./index.js
Error:
...
...
test/development/acceptance-app/error-recovery.test.ts
0 → 100644
View file @
72baaebb
/* eslint-env jest */
import
{
sandbox
}
from
'./helpers'
import
{
createNextDescribe
,
FileRef
}
from
'e2e-utils'
import
{
check
,
getSnapshotTestDescribe
}
from
'next-test-utils'
import
path
from
'path'
for
(
const
variant
of
[
'default'
,
'turbo'
])
{
getSnapshotTestDescribe
(
variant
)(
`Error recovery app
${
variant
}
`
,
()
=>
{
createNextDescribe
(
'Error recovery with overlay'
,
{
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)
),
dependencies
:
{
react
:
'latest'
,
'react-dom'
:
'latest'
,
},
skipStart
:
true
,
},
({
next
})
=>
{
test
(
'can recover from a syntax error without losing state'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
'index.js'
,
`
import { useCallback, useState } from 'react'
export default function Index() {
const [count, setCount] = useState(0)
const increment = useCallback(() => setCount(c => c + 1), [setCount])
return (
<main>
<p>{count}</p>
<button onClick={increment}>Increment</button>
</main>
)
}
`
)
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'button'
).
click
())
expect
(
await
session
.
evaluate
(
()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'1'
)
await
session
.
patch
(
'index.js'
,
`export default () => <div/`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toInclude
(
'export default () => <div/'
)
await
session
.
patch
(
'index.js'
,
`
import { useCallback, useState } from 'react'
export default function Index() {
const [count, setCount] = useState(0)
const increment = useCallback(() => setCount(c => c + 1), [setCount])
return (
<main>
<p>Count: {count}</p>
<button onClick={increment}>Increment</button>
</main>
)
}
`
)
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
await
check
(
()
=>
session
.
evaluate
(()
=>
document
.
querySelector
(
'p'
).
textContent
),
/Count: 1/
)
await
cleanup
()
})
test
.
each
([[
'client'
],
[
'server'
]])(
'%s component can recover from syntax error'
,
async
(
type
:
string
)
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
next
,
undefined
,
'/'
+
type
)
// Add syntax error
await
session
.
patch
(
`app/
${
type
}
/page.js`
,
`
export default function Page() {
return <p>Hello world</p>
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
// Fix syntax error
await
session
.
patch
(
`app/
${
type
}
/page.js`
,
`
export default function Page() {
return <p>Hello world 2</p>
}
`
)
await
check
(()
=>
browser
.
elementByCss
(
'p'
).
text
(),
'Hello world 2'
)
await
cleanup
()
}
)
test
(
'can recover from a event handler error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
'index.js'
,
`
import { useCallback, useState } from 'react'
export default function Index() {
const [count, setCount] = useState(0)
const increment = useCallback(() => {
setCount(c => c + 1)
throw new Error('oops')
}, [setCount])
return (
<main>
<p>{count}</p>
<button onClick={increment}>Increment</button>
</main>
)
}
`
)
expect
(
await
session
.
evaluate
(
()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'0'
)
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'button'
).
click
())
expect
(
await
session
.
evaluate
(
()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'1'
)
await
session
.
waitForAndOpenRuntimeError
()
expect
(
await
session
.
getRedboxSource
()).
toMatchInlineSnapshot
(
`
"index.js (8:22) @ eval
6 | const increment = useCallback(() => {
7 | setCount(c => c + 1)
> 8 | throw new Error('oops')
| ^
9 | }, [setCount])
10 | return (
11 | <main>"
`
)
await
session
.
patch
(
'index.js'
,
`
import { useCallback, useState } from 'react'
export default function Index() {
const [count, setCount] = useState(0)
const increment = useCallback(() => setCount(c => c + 1), [setCount])
return (
<main>
<p>Count: {count}</p>
<button onClick={increment}>Increment</button>
</main>
)
}
`
)
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
expect
(
await
session
.
hasErrorToast
()).
toBe
(
false
)
expect
(
await
session
.
evaluate
(
()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'Count: 1'
)
await
session
.
evaluate
(()
=>
document
.
querySelector
(
'button'
).
click
())
expect
(
await
session
.
evaluate
(
()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'Count: 2'
)
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
expect
(
await
session
.
hasErrorToast
()).
toBe
(
false
)
await
cleanup
()
})
test
.
each
([[
'client'
],
[
'server'
]])(
'%s component can recover from a component error'
,
async
(
type
:
string
)
=>
{
const
{
session
,
cleanup
,
browser
}
=
await
sandbox
(
next
,
undefined
,
'/'
+
type
)
await
session
.
write
(
'child.js'
,
`
export default function Child() {
return <p>Hello</p>;
}
`
)
await
session
.
patch
(
'index.js'
,
`
import Child from './child'
export default function Index() {
return (
<main>
<Child />
</main>
)
}
`
)
expect
(
await
browser
.
elementByCss
(
'p'
).
text
()).
toBe
(
'Hello'
)
await
session
.
patch
(
'child.js'
,
`
// hello
export default function Child() {
throw new Error('oops')
}
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toInclude
(
'export default function Child()'
)
// TODO-APP: re-enable when error recovery doesn't reload the page.
/* const didNotReload = */
await
session
.
patch
(
'child.js'
,
`
export default function Child() {
return <p>Hello</p>;
}
`
)
// TODO-APP: re-enable when error recovery doesn't reload the page.
// expect(didNotReload).toBe(true)
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
expect
(
await
session
.
evaluate
(
()
=>
document
.
querySelector
(
'p'
).
textContent
)
).
toBe
(
'Hello'
)
await
cleanup
()
}
)
// https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/3#issuecomment-554150098
test
(
'syntax > runtime error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
// Start here.
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
export default function FunctionNamed() {
return <div />
}
`
)
// TODO: this acts weird without above step
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
let i = 0
setInterval(() => {
i++
throw Error('no ' + i)
}, 1000)
export default function FunctionNamed() {
return <div />
}
`
)
await
new
Promise
((
resolve
)
=>
setTimeout
(
resolve
,
1000
))
await
session
.
waitForAndOpenRuntimeError
()
expect
(
await
session
.
getRedboxSource
()).
not
.
toInclude
(
"Expected '}', got '<eof>'"
)
// Make a syntax error.
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
let i = 0
setInterval(() => {
i++
throw Error('no ' + i)
}, 1000)
export default function FunctionNamed() {`
)
await
new
Promise
((
resolve
)
=>
setTimeout
(
resolve
,
1000
))
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toInclude
(
"Expected '}', got '<eof>'"
)
// Test that runtime error does not take over:
await
new
Promise
((
resolve
)
=>
setTimeout
(
resolve
,
2000
))
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toInclude
(
"Expected '}', got '<eof>'"
)
await
cleanup
()
})
// https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/3#issuecomment-554144016
test
(
'stuck error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
// We start here.
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
function FunctionDefault() {
return <h1>Default Export Function</h1>;
}
export default FunctionDefault;
`
)
// We add a new file. Let's call it Foo.js.
await
session
.
write
(
'Foo.js'
,
`
// intentionally skips export
export default function Foo() {
return React.createElement('h1', null, 'Foo');
}
`
)
// We edit our first file to use it.
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
import Foo from './Foo';
function FunctionDefault() {
return <Foo />;
}
export default FunctionDefault;
`
)
// We get an error because Foo didn't import React. Fair.
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
getRedboxSource
()).
toInclude
(
"return React.createElement('h1', null, 'Foo');"
)
// Let's add that to Foo.
await
session
.
patch
(
'Foo.js'
,
`
import * as React from 'react';
export default function Foo() {
return React.createElement('h1', null, 'Foo');
}
`
)
// Expected: this fixes the problem
expect
(
await
session
.
hasRedbox
(
false
)).
toBe
(
false
)
await
cleanup
()
})
// https://github.com/pmmmwh/react-refresh-webpack-plugin/pull/3#issuecomment-554137262
test
(
'render error not shown right after syntax error'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
// Starting here:
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
class ClassDefault extends React.Component {
render() {
return <h1>Default Export</h1>;
}
}
export default ClassDefault;
`
)
expect
(
await
session
.
evaluate
(
()
=>
document
.
querySelector
(
'h1'
).
textContent
)
).
toBe
(
'Default Export'
)
// Break it with a syntax error:
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
class ClassDefault extends React.Component {
render()
return <h1>Default Export</h1>;
}
}
export default ClassDefault;
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
// Now change the code to introduce a runtime error without fixing the syntax error:
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
class ClassDefault extends React.Component {
render()
throw new Error('nooo');
return <h1>Default Export</h1>;
}
}
export default ClassDefault;
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
// Now fix the syntax error:
await
session
.
patch
(
'index.js'
,
`
import * as React from 'react';
class ClassDefault extends React.Component {
render() {
throw new Error('nooo');
return <h1>Default Export</h1>;
}
}
export default ClassDefault;
`
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
await
check
(
async
()
=>
{
const
source
=
await
session
.
getRedboxSource
()
return
source
?.
includes
(
'render() {'
)
?
'success'
:
source
},
'success'
)
expect
(
await
session
.
getRedboxSource
()).
toInclude
(
"throw new Error('nooo');"
)
await
cleanup
()
})
}
)
})
}
test/development/acceptance-app/fixtures/default-template/app/client/page.js
0 → 100644
View file @
72baaebb
'use client'
import
Component
from
'../../index'
export
default
function
Page
()
{
return
<
Component
/>
}
test/development/acceptance-app/fixtures/default-template/app/server/page.js
0 → 100644
View file @
72baaebb
import
Component
from
'../../index'
export
default
function
Page
()
{
return
<
Component
/>
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment