Unverified Commit 75ba27c2 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Generate middlewareManifestPath only once (#55489)

Ensures the `join()` is skipped for each request. Did a load test and this increases throughput by about ~150RPS at minimum.
parent 0bfd4801
...@@ -145,6 +145,7 @@ function getMiddlewareMatcher( ...@@ -145,6 +145,7 @@ function getMiddlewareMatcher(
} }
export default class NextNodeServer extends BaseServer { export default class NextNodeServer extends BaseServer {
protected middlewareManifestPath: string
private _serverDistDir: string | undefined private _serverDistDir: string | undefined
private imageResponseCache?: ResponseCache private imageResponseCache?: ResponseCache
protected renderWorkersPromises?: Promise<void> protected renderWorkersPromises?: Promise<void>
...@@ -231,6 +232,8 @@ export default class NextNodeServer extends BaseServer { ...@@ -231,6 +232,8 @@ export default class NextNodeServer extends BaseServer {
const { interceptTestApis } = require('../experimental/testmode/server') const { interceptTestApis } = require('../experimental/testmode/server')
interceptTestApis() interceptTestApis()
} }
this.middlewareManifestPath = join(this.serverDistDir, MIDDLEWARE_MANIFEST)
} }
protected async handleUpgrade(): Promise<void> { protected async handleUpgrade(): Promise<void> {
...@@ -1335,10 +1338,7 @@ export default class NextNodeServer extends BaseServer { ...@@ -1335,10 +1338,7 @@ export default class NextNodeServer extends BaseServer {
protected getMiddlewareManifest(): MiddlewareManifest | null { protected getMiddlewareManifest(): MiddlewareManifest | null {
if (this.minimalMode) return null if (this.minimalMode) return null
const manifest: MiddlewareManifest = require(join( const manifest: MiddlewareManifest = require(this.middlewareManifestPath)
this.serverDistDir,
MIDDLEWARE_MANIFEST
))
return manifest return manifest
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment