Unverified Commit 7ab9f98b authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Turbopack build: Skip Babel specific test (#68838)

## What?

Skips the last Babel specific test as it is only supported when adding
babel-loader manually in Turbopack.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
parent 608ece13
...@@ -31,7 +31,10 @@ describe('TypeScript basic', () => { ...@@ -31,7 +31,10 @@ describe('TypeScript basic', () => {
expect(html).toContain('hello world') expect(html).toContain('hello world')
}) })
it('should work with babel', async () => { // Turbopack doesn't support Babel built-in.
;(process.env.TURBOPACK ? it.skip : it)(
'should work with babel',
async () => {
await next.stop() await next.stop()
await next.patchFile( await next.patchFile(
'.babelrc', '.babelrc',
...@@ -40,6 +43,8 @@ describe('TypeScript basic', () => { ...@@ -40,6 +43,8 @@ describe('TypeScript basic', () => {
await next.start() await next.start()
const html = await renderViaHTTP(next.url, '/') const html = await renderViaHTTP(next.url, '/')
// eslint-disable-next-line jest/no-standalone-expect
expect(html).toContain('hello world') expect(html).toContain('hello world')
}) }
)
}) })
...@@ -16486,8 +16486,8 @@ ...@@ -16486,8 +16486,8 @@
"TypeScript basic have built and started correctly", "TypeScript basic have built and started correctly",
"TypeScript basic should not have eslint setup started" "TypeScript basic should not have eslint setup started"
], ],
"failed": ["TypeScript basic should work with babel"], "failed": [],
"pending": [], "pending": ["TypeScript basic should work with babel"],
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment