Unverified Commit 7ff17dd1 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

trace-build: Add missing spans (#84080)

## What?

Follow-up to #83949

While testing the changes I ran Turbopack builds and all time was
captured, but for webpack there was some missing time related to tracing
outputs (Turbopack does the tracing internally). This PR adds the
missing spans to trace-build.
parent b82f1db2
...@@ -1734,13 +1734,18 @@ export default async function build( ...@@ -1734,13 +1734,18 @@ export default async function build(
} }
) as Worker & typeof import('./collect-build-traces') ) as Worker & typeof import('./collect-build-traces')
buildTracesPromise = buildTraceWorker buildTracesPromise = nextBuildSpan
.traceChild('collect-build-traces')
.traceAsyncFn(() => {
return buildTraceWorker
.collectBuildTraces({ .collectBuildTraces({
dir, dir,
config, config,
distDir, distDir,
// Serialize Map as this is sent to the worker. // Serialize Map as this is sent to the worker.
edgeRuntimeRoutes: collectRoutesUsingEdgeRuntime(new Map()), edgeRuntimeRoutes: collectRoutesUsingEdgeRuntime(
new Map()
),
staticPages: [], staticPages: [],
hasSsrAmpPages: false, hasSsrAmpPages: false,
buildTraceContext, buildTraceContext,
...@@ -1750,6 +1755,7 @@ export default async function build( ...@@ -1750,6 +1755,7 @@ export default async function build(
console.error(err) console.error(err)
process.exit(1) process.exit(1)
}) })
})
} }
}) })
if (!runServerAndEdgeInParallel) { if (!runServerAndEdgeInParallel) {
...@@ -2610,7 +2616,10 @@ export default async function build( ...@@ -2610,7 +2616,10 @@ export default async function build(
await writeFunctionsConfigManifest(distDir, functionsConfigManifest) await writeFunctionsConfigManifest(distDir, functionsConfigManifest)
if (!isTurbopack && !isGenerateMode && !buildTracesPromise) { if (!isTurbopack && !isGenerateMode && !buildTracesPromise) {
buildTracesPromise = collectBuildTraces({ buildTracesPromise = nextBuildSpan
.traceChild('collect-build-traces')
.traceAsyncFn(() => {
return collectBuildTraces({
dir, dir,
config, config,
distDir, distDir,
...@@ -2624,6 +2633,7 @@ export default async function build( ...@@ -2624,6 +2633,7 @@ export default async function build(
console.error(err) console.error(err)
process.exit(1) process.exit(1)
}) })
})
} }
if (serverPropsPages.size > 0 || ssgPages.size > 0) { if (serverPropsPages.size > 0 || ssgPages.size > 0) {
...@@ -4083,7 +4093,11 @@ export default async function build( ...@@ -4083,7 +4093,11 @@ export default async function build(
}) })
} }
if (config.experimental.adapterPath) { const adapterPath = config.experimental.adapterPath
if (adapterPath) {
await nextBuildSpan
.traceChild('adapter-handle-build-complete')
.traceAsyncFn(async () => {
await handleBuildComplete({ await handleBuildComplete({
dir, dir,
distDir, distDir,
...@@ -4093,7 +4107,7 @@ export default async function build( ...@@ -4093,7 +4107,7 @@ export default async function build(
tracingRoot: outputFileTracingRoot, tracingRoot: outputFileTracingRoot,
hasNodeMiddleware, hasNodeMiddleware,
hasInstrumentationHook, hasInstrumentationHook,
adapterPath: config.experimental.adapterPath, adapterPath,
pageKeys: pageKeys.pages, pageKeys: pageKeys.pages,
appPageKeys: denormalizedAppPages, appPageKeys: denormalizedAppPages,
routesManifest, routesManifest,
...@@ -4103,9 +4117,13 @@ export default async function build( ...@@ -4103,9 +4117,13 @@ export default async function build(
hasStatic404: useStaticPages404, hasStatic404: useStaticPages404,
requiredServerFiles: requiredServerFilesManifest.files, requiredServerFiles: requiredServerFilesManifest.files,
}) })
})
} }
if (config.output === 'standalone') { if (config.output === 'standalone') {
await nextBuildSpan
.traceChild('output-standalone')
.traceAsyncFn(async () => {
await writeStandaloneDirectory( await writeStandaloneDirectory(
nextBuildSpan, nextBuildSpan,
distDir, distDir,
...@@ -4120,6 +4138,7 @@ export default async function build( ...@@ -4120,6 +4138,7 @@ export default async function build(
loadedEnvFiles, loadedEnvFiles,
appDir appDir
) )
})
} }
if (postBuildSpinner) postBuildSpinner.stopAndPersist() if (postBuildSpinner) postBuildSpinner.stopAndPersist()
......
...@@ -81,8 +81,12 @@ const allowlistedEvents = new Set([ ...@@ -81,8 +81,12 @@ const allowlistedEvents = new Set([
'run-typescript', 'run-typescript',
'run-eslint', 'run-eslint',
'static-check', 'static-check',
'collect-build-traces',
'static-generation', 'static-generation',
'output-export-full-static-export', 'output-export-full-static-export',
'adapter-handle-build-complete',
'output-standalone',
'telemetry-flush',
]) ])
function reportToJsonBuild(event: TraceEvent) { function reportToJsonBuild(event: TraceEvent) {
......
...@@ -119,19 +119,48 @@ describe('trace-build-file', () => { ...@@ -119,19 +119,48 @@ describe('trace-build-file', () => {
const traceBuildPath = join(next.testDir, '.next/trace-build') const traceBuildPath = join(next.testDir, '.next/trace-build')
const traceStructure = parseTraceFile(traceBuildPath) const traceStructure = parseTraceFile(traceBuildPath)
const allowlistedEvents = new Set([ // const allowlistedEvents = new Set([
'next-build', // 'next-build',
'run-turbopack', // 'run-turbopack',
'run-webpack', // 'run-webpack',
'run-typescript', // 'run-typescript',
'run-eslint', // 'run-eslint',
'static-check', // 'static-check',
'static-generation', // 'static-generation',
'output-export-full-static-export', // 'output-export-full-static-export',
]) // ])
const foundEvents = new Set<string>()
for (const event of traceStructure.events) { for (const event of traceStructure.events) {
expect(allowlistedEvents.has(event.name)).toBe(true) foundEvents.add(event.name)
}
if (process.env.IS_TURBOPACK_TEST) {
expect([...foundEvents].sort()).toMatchInlineSnapshot(`
[
"next-build",
"run-eslint",
"run-turbopack",
"run-typescript",
"static-check",
"static-generation",
"telemetry-flush",
]
`)
} else {
expect([...foundEvents].sort()).toMatchInlineSnapshot(`
[
"collect-build-traces",
"next-build",
"run-eslint",
"run-typescript",
"run-webpack",
"static-check",
"static-generation",
"telemetry-flush",
]
`)
} }
}) })
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment