Unverified Commit c72fc330 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Ensure we only handle app nav failure for actual error (#68285)

We were seeing `null` errors in the app navigation failure handling so
this ensures we check the error is a truthy value and only handle for
that case.

![CleanShot 2024-07-29 at 11 45
42@2x](https://github.com/user-attachments/assets/91d0e9ad-bedd-4c4b-9e0e-dc8b2e589671)
parent bb0e6722
...@@ -91,7 +91,7 @@ export class ErrorBoundaryHandler extends React.Component< ...@@ -91,7 +91,7 @@ export class ErrorBoundaryHandler extends React.Component<
// the error boundary and instead should fallback // the error boundary and instead should fallback
// to a hard navigation to attempt recovering // to a hard navigation to attempt recovering
if (process.env.__NEXT_APP_NAV_FAIL_HANDLING) { if (process.env.__NEXT_APP_NAV_FAIL_HANDLING) {
if (handleHardNavError(error)) { if (error && handleHardNavError(error)) {
// clear error so we don't render anything // clear error so we don't render anything
return { return {
error: null, error: null,
......
...@@ -3,6 +3,7 @@ import { createHrefFromUrl } from './router-reducer/create-href-from-url' ...@@ -3,6 +3,7 @@ import { createHrefFromUrl } from './router-reducer/create-href-from-url'
export function handleHardNavError(error: unknown): boolean { export function handleHardNavError(error: unknown): boolean {
if ( if (
error &&
typeof window !== 'undefined' && typeof window !== 'undefined' &&
window.next.__pendingUrl && window.next.__pendingUrl &&
createHrefFromUrl(new URL(window.location.href)) !== createHrefFromUrl(new URL(window.location.href)) !==
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment