Unverified Commit ce973905 authored by Shu Ding's avatar Shu Ding Committed by GitHub

Add code comments (#58529)

The code comments added in https://github.com/vercel/next.js/commit/2dc0ba4bd9712e2b5931eb6e00156761384ff44d are missing somehow. These are very necessary to understand the code as it looks confusing.
parent 32875e4f
...@@ -353,10 +353,17 @@ export async function handleAction({ ...@@ -353,10 +353,17 @@ export async function handleAction({
if (isFetchAction) { if (isFetchAction) {
res.statusCode = 500 res.statusCode = 500
await Promise.all(staticGenerationStore.pendingRevalidates || []) await Promise.all(staticGenerationStore.pendingRevalidates || [])
const promise = Promise.reject(error) const promise = Promise.reject(error)
try { try {
// we need to await the promise to trigger the rejection early
// so that it's already handled by the time we call
// the RSC runtime. Otherwise, it will throw an unhandled
// promise rejection error in the renderer.
await promise await promise
} catch {} } catch {
// swallow error, it's gonna be handled on the client
}
return { return {
type: 'done', type: 'done',
...@@ -608,8 +615,14 @@ To configure the body size limit for Server Actions, see: https://nextjs.org/doc ...@@ -608,8 +615,14 @@ To configure the body size limit for Server Actions, see: https://nextjs.org/doc
if (isFetchAction) { if (isFetchAction) {
const promise = Promise.reject(err) const promise = Promise.reject(err)
try { try {
// we need to await the promise to trigger the rejection early
// so that it's already handled by the time we call
// the RSC runtime. Otherwise, it will throw an unhandled
// promise rejection error in the renderer.
await promise await promise
} catch {} } catch {
// swallow error, it's gonna be handled on the client
}
return { return {
type: 'done', type: 'done',
result: await generateFlight(ctx, { result: await generateFlight(ctx, {
...@@ -629,8 +642,14 @@ To configure the body size limit for Server Actions, see: https://nextjs.org/doc ...@@ -629,8 +642,14 @@ To configure the body size limit for Server Actions, see: https://nextjs.org/doc
await Promise.all(staticGenerationStore.pendingRevalidates || []) await Promise.all(staticGenerationStore.pendingRevalidates || [])
const promise = Promise.reject(err) const promise = Promise.reject(err)
try { try {
// we need to await the promise to trigger the rejection early
// so that it's already handled by the time we call
// the RSC runtime. Otherwise, it will throw an unhandled
// promise rejection error in the renderer.
await promise await promise
} catch {} } catch {
// swallow error, it's gonna be handled on the client
}
return { return {
type: 'done', type: 'done',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment