Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
d257d445
Unverified
Commit
d257d445
authored
May 20, 2020
by
Gerald Monaco
Committed by
GitHub
May 20, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove dead events (#13156)
parent
91b1548d
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
30 deletions
+0
-30
index.js
packages/next/client/index.js
+0
-8
next-dev.js
packages/next/client/next-dev.js
+0
-22
No files found.
packages/next/client/index.js
View file @
d257d445
...
@@ -514,12 +514,6 @@ async function doRender({ App, Component, props, err }) {
...
@@ -514,12 +514,6 @@ async function doRender({ App, Component, props, err }) {
// lastAppProps has to be set before ReactDom.render to account for ReactDom throwing an error.
// lastAppProps has to be set before ReactDom.render to account for ReactDom throwing an error.
lastAppProps
=
appProps
lastAppProps
=
appProps
emitter
.
emit
(
'before-reactdom-render'
,
{
Component
,
ErrorComponent
,
appProps
,
})
const
elem
=
(
const
elem
=
(
<
AppContainer
>
<
AppContainer
>
<
App
{...
appProps
}
/
>
<
App
{...
appProps
}
/
>
...
@@ -535,6 +529,4 @@ async function doRender({ App, Component, props, err }) {
...
@@ -535,6 +529,4 @@ async function doRender({ App, Component, props, err }) {
),
),
appElement
appElement
)
)
emitter
.
emit
(
'after-reactdom-render'
,
{
Component
,
ErrorComponent
,
appProps
})
}
}
packages/next/client/next-dev.js
View file @
d257d445
...
@@ -43,28 +43,6 @@ initNext({ webpackHMR })
...
@@ -43,28 +43,6 @@ initNext({ webpackHMR })
displayContent
(()
=>
{
displayContent
(()
=>
{
render
(
renderCtx
)
render
(
renderCtx
)
})
})
let
lastScroll
emitter
.
on
(
'before-reactdom-render'
,
({
Component
,
ErrorComponent
})
=>
{
// Remember scroll when ErrorComponent is being rendered to later restore it
if
(
!
lastScroll
&&
Component
===
ErrorComponent
)
{
const
{
pageXOffset
,
pageYOffset
}
=
window
lastScroll
=
{
x
:
pageXOffset
,
y
:
pageYOffset
,
}
}
})
emitter
.
on
(
'after-reactdom-render'
,
({
Component
,
ErrorComponent
})
=>
{
if
(
lastScroll
&&
Component
!==
ErrorComponent
)
{
// Restore scroll after ErrorComponent was replaced with a page component by HMR
const
{
x
,
y
}
=
lastScroll
window
.
scroll
(
x
,
y
)
lastScroll
=
null
}
})
})
})
.
catch
((
err
)
=>
{
.
catch
((
err
)
=>
{
console
.
error
(
'Error was not caught'
,
err
)
console
.
error
(
'Error was not caught'
,
err
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment