Unverified Commit da1b259f authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Remove Turbopack test skip for scss test (#63649)

## What?

Verified this passes now with Turbopack in dev even.


<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-2907
parent 27469901
...@@ -10,7 +10,6 @@ describe('Dynamic Route CSS Module Usage', () => { ...@@ -10,7 +10,6 @@ describe('Dynamic Route CSS Module Usage', () => {
sass: '1.54.0', sass: '1.54.0',
}, },
}) })
;(process.env.TURBOPACK ? describe.skip : describe)('production mode', () => {
it('should apply styles correctly', async () => { it('should apply styles correctly', async () => {
const browser = await next.browser('/post-1') const browser = await next.browser('/post-1')
...@@ -20,5 +19,4 @@ describe('Dynamic Route CSS Module Usage', () => { ...@@ -20,5 +19,4 @@ describe('Dynamic Route CSS Module Usage', () => {
expect(background).toMatch(colorToRgb('red')) expect(background).toMatch(colorToRgb('red'))
}) })
})
}) })
...@@ -33,9 +33,9 @@ describe('Graceful Shutdown', () => { ...@@ -33,9 +33,9 @@ describe('Graceful Shutdown', () => {
runTests(true) runTests(true)
}) })
;(process.env.TURBOPACK ? describe.skip : describe)( ;(process.env.TURBOPACK && !process.env.TURBOPACK_BUILD
'production (next start)', ? describe.skip
() => { : describe)('production (next start)', () => {
beforeAll(async () => { beforeAll(async () => {
await nextBuild(appDir) await nextBuild(appDir)
}) })
...@@ -46,11 +46,10 @@ describe('Graceful Shutdown', () => { ...@@ -46,11 +46,10 @@ describe('Graceful Shutdown', () => {
afterEach(() => killApp(app)) afterEach(() => killApp(app))
runTests() runTests()
} })
) ;(process.env.TURBOPACK && !process.env.TURBOPACK_BUILD
;(process.env.TURBOPACK ? describe.skip : describe)( ? describe.skip
'production (standalone mode)', : describe)('production (standalone mode)', () => {
() => {
let next: NextInstance let next: NextInstance
let serverFile let serverFile
...@@ -111,8 +110,7 @@ describe('Graceful Shutdown', () => { ...@@ -111,8 +110,7 @@ describe('Graceful Shutdown', () => {
afterAll(() => next.destroy()) afterAll(() => next.destroy())
runTests() runTests()
} })
)
}) })
function runTests(dev = false) { function runTests(dev = false) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment