Unverified Commit de7ce396 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Node.js streams: Fork points (#92252)

### What?

Implements native Node.js stream support for the RSC / HTML rendering.
This first step does not include cacheComponents / static generation.

Instead of converting between Node.js Readable streams and Web
ReadableStreams at every boundary, the rendering pipeline now uses
native Node.js `Transform`/`PassThrough`/`Readable` streams end-to-end
when the useNodeStreams experimental flag is enabled.

### Why?

The current rendering pipeline has a bottleneck on Web Streams. Each
step adds overhead: buffering, scheduling mismatches, and unnecessary
memory copies. Node.js streams are the native I/O primitive on the
server. Using them directly eliminates these conversion and
scheduling/promise costs.

This is the foundational plumbing needed to run the full app render
pipeline on native Node.js streams, which improves server-side rendering
throughput.

### How?

**Stream transform reimplementation** (`stream-ops.node.ts`):

All web `TransformStream`-based transforms have been reimplemented as
Node.js `Transform` streams:

- `createBufferedTransformStream` — coalesces chunks written in the same
microtask into a single `Uint8Array`
- `createFlightDataInjectionTransform` — interleaves RSC flight data
chunks with the HTML stream
- `createHeadInsertionTransform` — inserts server-generated HTML
(polyfills, scripts) before `</head>`
- `createMetadataTransform` — finds and replaces the `«nxt-icon»` meta
mark
- `createDeferredSuffixTransform` — appends the document suffix after
the first HTML chunk
- `createMoveSuffixTransform` — moves `</body></html>` to the end of the
stream
- `createHtmlDataDplIdTransform` — inserts a `data-dpl-id` attribute on
the opening `<html>` tag
- `createRootLayoutValidatorTransform` — validates `<html>` and `<body>`
tags are present (dev only)

**`ReplayableNodeStream`** (`app-render-prerender-utils.ts`):

New class that buffers all chunks from a source `Readable` and allows
creating multiple independent replay streams via `createReplayStream()`.
This replaces the web stream `tee()` operation for `ReactServerResult`
when using Node.js streams. Uses pull-based delivery (`_read()`) to
avoid AsyncLocalStorage context issues — chunks are only delivered when
the consumer reads, keeping them inside the correct ALS scope during
Fizz's `performWork`. Includes 392 lines of unit tests covering
buffering, live replay, error propagation, multiple independent replays,
subscriber cleanup, and dispose behavior.

**Native rendering functions**:

- `renderToNodeFlightStream` — calls React's `renderToPipeableStream`
directly, pipes to a `PassThrough`
- `renderToNodeFizzStream` — calls `renderToPipeableStream` for HTML
rendering without the web stream wrapper
- `createNodeInlinedDataStream` — wraps RSC flight data in `<script>`
tags using `Buffer` operations and `isUtf8()` for encoding detection

**`continueFizzStream` rewritten for Node.js**:

Instead of converting to web streams and delegating to
`webContinueFizzStream`, the Node.js path pipes through a chain of
native `Transform` streams directly: buffer → dpl-id → metadata →
deferred suffix → flight data injection → root layout validator → move
suffix → head insertion.

**API renames for clarity**:

- `renderToFlightStream` → `renderToWebFlightStream` /
`renderToNodeFlightStream`
- `renderToFizzStream` → `renderToWebFizzStream` /
`renderToNodeFizzStream`
- `createInlinedDataStream` → `createWebInlinedDataStream` /
`createNodeInlinedDataStream`
- `createDebugChannel` → `createWebDebugChannel` /
`createNodeDebugChannel`

**`app-render.tsx` fork points**:

The main render function now branches on
`process.env.__NEXT_USE_NODE_STREAMS` at two key points:
1. RSC rendering — uses `renderToNodeFlightStream` +
`createNodeDebugChannel`
2. HTML rendering — uses `renderToNodeFizzStream` + native
`continueFizzStream` with `createNodeInlinedDataStream`

All pre-render, cache components, and dev staged-render paths continue
to use web streams.

**CI updates** (`.github/workflows/build_and_test.yml`):

The `use-node-streams` test jobs now run without
`__NEXT_CACHE_COMPONENTS` / `__NEXT_EXPERIMENTAL_CACHED_NAVIGATIONS` /
`__NEXT_EXPERIMENTAL_APP_NEW_SCROLL_HANDLER` to isolate the Node.js
streams path.
parent e75d006d
...@@ -1180,13 +1180,12 @@ jobs: ...@@ -1180,13 +1180,12 @@ jobs:
with: with:
afterBuild: | afterBuild: |
export __NEXT_USE_NODE_STREAMS=true export __NEXT_USE_NODE_STREAMS=true
export __NEXT_CACHE_COMPONENTS=true
export __NEXT_EXPERIMENTAL_CACHED_NAVIGATIONS=true
export __NEXT_EXPERIMENTAL_APP_NEW_SCROLL_HANDLER=true
export NEXT_EXTERNAL_TESTS_FILTERS="test/cache-components-tests-manifest.json,test/use-node-streams-tests-manifest.json" export NEXT_EXTERNAL_TESTS_FILTERS="test/cache-components-tests-manifest.json,test/use-node-streams-tests-manifest.json"
export NEXT_TEST_MODE=dev export NEXT_TEST_MODE=dev
export IS_TURBOPACK_TEST=1 export IS_TURBOPACK_TEST=1
export TURBOPACK_DEV=1 export TURBOPACK_DEV=1
export __NEXT_EXPERIMENTAL_STRICT_ROUTE_TYPES=true
export RUST_BACKTRACE=1
node run-tests.js \ node run-tests.js \
--timings \ --timings \
...@@ -1208,13 +1207,12 @@ jobs: ...@@ -1208,13 +1207,12 @@ jobs:
with: with:
afterBuild: | afterBuild: |
export __NEXT_USE_NODE_STREAMS=true export __NEXT_USE_NODE_STREAMS=true
export __NEXT_CACHE_COMPONENTS=true
export __NEXT_EXPERIMENTAL_CACHED_NAVIGATIONS=true
export __NEXT_EXPERIMENTAL_APP_NEW_SCROLL_HANDLER=true
export NEXT_EXTERNAL_TESTS_FILTERS="test/cache-components-tests-manifest.json,test/use-node-streams-tests-manifest.json" export NEXT_EXTERNAL_TESTS_FILTERS="test/cache-components-tests-manifest.json,test/use-node-streams-tests-manifest.json"
export NEXT_TEST_MODE=start export NEXT_TEST_MODE=start
export IS_TURBOPACK_TEST=1 export IS_TURBOPACK_TEST=1
export TURBOPACK_BUILD=1 export TURBOPACK_BUILD=1
export __NEXT_EXPERIMENTAL_STRICT_ROUTE_TYPES=true
export RUST_BACKTRACE=1
node run-tests.js \ node run-tests.js \
--timings \ --timings \
......
...@@ -1150,5 +1150,9 @@ ...@@ -1150,5 +1150,9 @@
"1149": "Node.js Readable cannot be teed in the edge runtime", "1149": "Node.js Readable cannot be teed in the edge runtime",
"1150": "Node.js Readable cannot be converted to a web stream in the edge runtime", "1150": "Node.js Readable cannot be converted to a web stream in the edge runtime",
"1151": "%s is being parsed as a normalized route, but it has a route group segment.", "1151": "%s is being parsed as a normalized route, but it has a route group segment.",
"1152": "%s is being parsed as a normalized route, but it has a parallel route segment." "1152": "%s is being parsed as a normalized route, but it has a parallel route segment.",
"1153": "renderToPipeableStream is not implemented",
"1154": "not implemented",
"1155": "Not implemented",
"1156": "Cannot create a replay stream after the ReplayableNodeStream has been disposed."
} }
...@@ -13,12 +13,23 @@ function isWebStream(stream: AnyStream): stream is ReadableStream<Uint8Array> { ...@@ -13,12 +13,23 @@ function isWebStream(stream: AnyStream): stream is ReadableStream<Uint8Array> {
// in one that doesn't close even when the underlying is complete. // in one that doesn't close even when the underlying is complete.
export class ReactServerResult { export class ReactServerResult {
private _stream: null | AnyStream private _stream: null | AnyStream
private _replayable: ReplayableNodeStream | null
constructor(stream: AnyStream) { constructor(stream: AnyStream) {
if (process.env.__NEXT_USE_NODE_STREAMS && !isWebStream(stream)) {
this._stream = null
this._replayable = new ReplayableNodeStream(stream as Readable)
} else {
this._stream = stream this._stream = stream
this._replayable = null
}
} }
tee(): AnyStream { tee(): AnyStream {
if (this._replayable) {
return this._replayable.createReplayStream()
}
if (this._stream === null) { if (this._stream === null) {
throw new Error( throw new Error(
'Cannot tee a ReactServerResult that has already been consumed' 'Cannot tee a ReactServerResult that has already been consumed'
...@@ -56,6 +67,13 @@ export class ReactServerResult { ...@@ -56,6 +67,13 @@ export class ReactServerResult {
} }
consume(): AnyStream { consume(): AnyStream {
if (this._replayable) {
const stream = this._replayable.createReplayStream()
this._replayable.dispose()
this._replayable = null
return stream
}
if (this._stream === null) { if (this._stream === null) {
throw new Error( throw new Error(
'Cannot consume a ReactServerResult that has already been consumed' 'Cannot consume a ReactServerResult that has already been consumed'
...@@ -67,6 +85,147 @@ export class ReactServerResult { ...@@ -67,6 +85,147 @@ export class ReactServerResult {
} }
} }
type ReplayableStreamSubscriber = {
onChunk: (chunk: Uint8Array) => void
onEnd: () => void
onError: (err: Error) => void
}
/**
* Buffers all chunks from a Node.js Readable stream and allows creating new
* Readable streams that replay the buffered chunks plus any subsequent chunks
* from the source. Multiple replay streams can be created independently.
*/
export class ReplayableNodeStream {
private _chunks: Array<Uint8Array> | null
private _done: boolean
private _error: Error | null
private _subscribers: Set<ReplayableStreamSubscriber>
constructor(stream: Readable) {
this._chunks = []
this._done = false
this._error = null
this._subscribers = new Set()
stream.on('data', (chunk: Buffer | Uint8Array) => {
const buf = chunk instanceof Uint8Array ? chunk : new Uint8Array(chunk)
if (this._chunks !== null) {
this._chunks.push(buf)
}
for (const sub of this._subscribers) {
sub.onChunk(buf)
}
})
stream.on('end', () => {
this._done = true
for (const sub of this._subscribers) {
sub.onEnd()
}
this._subscribers.clear()
})
stream.on('error', (err: Error) => {
this._error = err
for (const sub of this._subscribers) {
sub.onError(err)
}
this._subscribers.clear()
})
}
/**
* Creates a new Node.js Readable stream that first emits all buffered chunks,
* then forwards any new chunks from the source as they arrive.
*
* Buffered chunks are delivered via _read() (pull-based) rather than pushed
* eagerly. This is critical because createReplayStream() is called outside
* of AsyncLocalStorage context, and eagerly pushing chunks triggers internal
* Node.js stream scheduling (process.nextTick for maybeReadMore) that
* captures the empty ALS context. By deferring to _read(), chunks are only
* delivered when the consumer reads, which happens inside the correct ALS
* scope (e.g. during Fizz's performWork).
*/
createReplayStream(): Readable {
if (this._chunks === null) {
throw new InvariantError(
'Cannot create a replay stream after the ReplayableNodeStream has been disposed.'
)
}
let ReadableCtor: typeof import('node:stream').Readable
if (process.env.TURBOPACK) {
ReadableCtor = (require('node:stream') as typeof import('node:stream'))
.Readable
} else if (process.env.__NEXT_BUNDLER === 'Webpack') {
ReadableCtor = (
__non_webpack_require__('node:stream') as typeof import('node:stream')
).Readable
} else {
ReadableCtor = (require('node:stream') as typeof import('node:stream'))
.Readable
}
const bufferedChunks = this._chunks.slice()
let bufferIndex = 0
let bufferDrained = false
const isDone = this._done
const sourceError = this._error
const stream = new ReadableCtor({
read() {
if (!bufferDrained) {
bufferDrained = true
for (let i = bufferIndex; i < bufferedChunks.length; i++) {
this.push(bufferedChunks[i])
}
bufferIndex = bufferedChunks.length
if (isDone) {
this.push(null)
}
}
},
})
if (sourceError) {
stream.destroy(sourceError)
return stream
}
if (isDone) {
return stream
}
const subscriber: ReplayableStreamSubscriber = {
onChunk: (chunk) => {
stream.push(chunk)
},
onEnd: () => {
stream.push(null)
},
onError: (err) => {
stream.destroy(err)
},
}
this._subscribers.add(subscriber)
stream.on('close', () => {
this._subscribers.delete(subscriber)
})
return stream
}
/**
* Clears the buffered chunks and all subscriber references. After calling
* this, no new replay streams can be created.
*/
dispose(): void {
this._chunks = null
}
}
export type ReactServerPrerenderResolveToType = { export type ReactServerPrerenderResolveToType = {
prelude: ReadableStream<Uint8Array> prelude: ReadableStream<Uint8Array>
} }
......
...@@ -6,14 +6,14 @@ ...@@ -6,14 +6,14 @@
import { PassThrough, Writable } from 'node:stream' import { PassThrough, Writable } from 'node:stream'
import type { DebugChannelPair } from './debug-channel-server.web' import type { DebugChannelPair } from './debug-channel-server.web'
export function createDebugChannel(): DebugChannelPair | undefined { export { createWebDebugChannel } from './debug-channel-server.web'
if (process.env.NODE_ENV === 'production') {
return undefined
}
return createNodeDebugChannel()
}
function createNodeDebugChannel(): DebugChannelPair { /**
* Creates a debug channel using Node.js streams.
* Use with renderToNodeFlightStream (React's renderToPipeableStream),
* which expects debugChannel to be a Node.js stream with a .write() method.
*/
export function createNodeDebugChannel(): DebugChannelPair {
const readable = new PassThrough() const readable = new PassThrough()
// Use a plain Writable instead of exposing the PassThrough directly. // Use a plain Writable instead of exposing the PassThrough directly.
......
...@@ -8,9 +8,11 @@ export type { ...@@ -8,9 +8,11 @@ export type {
DebugChannelPair, DebugChannelPair,
DebugChannelServer, DebugChannelServer,
} from './debug-channel-server.web' } from './debug-channel-server.web'
import type { DebugChannelPair } from './debug-channel-server.web'
type DebugChannelMod = { type DebugChannelMod = {
createDebugChannel: typeof import('./debug-channel-server.web').createDebugChannel createWebDebugChannel: typeof import('./debug-channel-server.web').createWebDebugChannel
createNodeDebugChannel: typeof import('./debug-channel-server.web').createNodeDebugChannel
} }
let _m: DebugChannelMod let _m: DebugChannelMod
...@@ -22,4 +24,18 @@ if (process.env.__NEXT_USE_NODE_STREAMS) { ...@@ -22,4 +24,18 @@ if (process.env.__NEXT_USE_NODE_STREAMS) {
require('./debug-channel-server.web') as typeof import('./debug-channel-server.web') require('./debug-channel-server.web') as typeof import('./debug-channel-server.web')
} }
export const createDebugChannel = _m.createDebugChannel export function createWebDebugChannel(): DebugChannelPair | undefined {
if (process.env.NODE_ENV === 'production') {
return undefined
}
return _m.createWebDebugChannel()
}
export function createNodeDebugChannel(): DebugChannelPair | undefined {
if (process.env.NODE_ENV === 'production') {
return undefined
}
return _m.createNodeDebugChannel()
}
...@@ -10,22 +10,17 @@ export type DebugChannelPair = { ...@@ -10,22 +10,17 @@ export type DebugChannelPair = {
clientSide: DebugChannelClient clientSide: DebugChannelClient
} }
// Opaque: PassThrough on node, { writable: WritableStream } on web.
// Each React render API handles its own variant.
export type DebugChannelServer = any export type DebugChannelServer = any
type DebugChannelClient = { type DebugChannelClient = {
readable: AnyStream readable: AnyStream
} }
export function createDebugChannel(): DebugChannelPair | undefined { /**
if (process.env.NODE_ENV === 'production') { * Creates a debug channel using web WritableStream/ReadableStream.
return undefined * Use with renderToWebFlightStream (React's renderToReadableStream),
} * which expects debugChannel = { writable: WritableStream }.
return createWebDebugChannel() */
}
export function createWebDebugChannel(): DebugChannelPair { export function createWebDebugChannel(): DebugChannelPair {
let readableController: ReadableStreamDefaultController | undefined let readableController: ReadableStreamDefaultController | undefined
...@@ -52,3 +47,12 @@ export function createWebDebugChannel(): DebugChannelPair { ...@@ -52,3 +47,12 @@ export function createWebDebugChannel(): DebugChannelPair {
clientSide: { readable: clientSideReadable }, clientSide: { readable: clientSideReadable },
} }
} }
/**
* Creates a debug channel using Node.js streams.
* Use with renderToNodeFlightStream (React's renderToPipeableStream),
* which expects debugChannel to be a Node.js stream with a .write() method.
*/
export function createNodeDebugChannel(): DebugChannelPair {
throw new Error('not implemented')
}
...@@ -41,7 +41,7 @@ import { ...@@ -41,7 +41,7 @@ import {
createNodeStreamWithLateRelease, createNodeStreamWithLateRelease,
createNodeStreamFromChunks, createNodeStreamFromChunks,
} from './stream-utils' } from './stream-utils'
import { createDebugChannel } from '../debug-channel-server' import { createWebDebugChannel } from '../debug-channel-server'
import type { FlightComponentMod } from '../stream-ops' import type { FlightComponentMod } from '../stream-ops'
// eslint-disable-next-line import/no-extraneous-dependencies // eslint-disable-next-line import/no-extraneous-dependencies
...@@ -297,7 +297,7 @@ export async function collectStagedSegmentData( ...@@ -297,7 +297,7 @@ export async function collectStagedSegmentData(
cacheEntry: SegmentCacheItem cacheEntry: SegmentCacheItem
): Promise<void> => { ): Promise<void> => {
const segmentDebugChannel = cacheEntry.debugChunks const segmentDebugChannel = cacheEntry.debugChunks
? createDebugChannel() ? createWebDebugChannel()
: undefined : undefined
const itemStream = renderFlightStream( const itemStream = renderFlightStream(
...@@ -536,7 +536,7 @@ export async function createCombinedPayloadStream( ...@@ -536,7 +536,7 @@ export async function createCombinedPayloadStream(
const allChunks: Uint8Array[] = [] const allChunks: Uint8Array[] = []
const debugChunks: Uint8Array[] | null = isDebugChannelEnabled ? [] : null const debugChunks: Uint8Array[] | null = isDebugChannelEnabled ? [] : null
const debugChannel = isDebugChannelEnabled ? createDebugChannel() : null const debugChannel = isDebugChannelEnabled ? createWebDebugChannel() : null
let streamFinished: Promise<any> let streamFinished: Promise<any>
......
...@@ -84,6 +84,7 @@ export function makeGetServerInsertedHTML({ ...@@ -84,6 +84,7 @@ export function makeGetServerInsertedHTML({
return '' return ''
} }
// TODO: This should use Node streams when __NEXT_USE_NODE_STREAMS is true
const stream = await renderToReadableStream( const stream = await renderToReadableStream(
<> <>
{polyfillTags} {polyfillTags}
......
...@@ -40,13 +40,16 @@ export const streamToBuffer = _m.streamToBuffer ...@@ -40,13 +40,16 @@ export const streamToBuffer = _m.streamToBuffer
export const chainStreams = _m.chainStreams export const chainStreams = _m.chainStreams
export const createDocumentClosingStream = _m.createDocumentClosingStream export const createDocumentClosingStream = _m.createDocumentClosingStream
export const processPrelude = _m.processPrelude export const processPrelude = _m.processPrelude
export const createInlinedDataStream = _m.createInlinedDataStream export const createWebInlinedDataStream = _m.createWebInlinedDataStream
export const createNodeInlinedDataStream = _m.createNodeInlinedDataStream
export const createPendingStream = _m.createPendingStream export const createPendingStream = _m.createPendingStream
export const createOnHeadersCallback = _m.createOnHeadersCallback export const createOnHeadersCallback = _m.createOnHeadersCallback
export const resumeAndAbort = _m.resumeAndAbort export const resumeAndAbort = _m.resumeAndAbort
export const renderToFlightStream = _m.renderToFlightStream export const renderToWebFlightStream = _m.renderToWebFlightStream
export const renderToNodeFlightStream = _m.renderToNodeFlightStream
export const streamToString = _m.streamToString export const streamToString = _m.streamToString
export const renderToFizzStream = _m.renderToFizzStream export const renderToWebFizzStream = _m.renderToWebFizzStream
export const renderToNodeFizzStream = _m.renderToNodeFizzStream
export const resumeToFizzStream = _m.resumeToFizzStream export const resumeToFizzStream = _m.resumeToFizzStream
export const getServerPrerender = _m.getServerPrerender export const getServerPrerender = _m.getServerPrerender
export const getClientPrerender = _m.getClientPrerender export const getClientPrerender = _m.getClientPrerender
......
...@@ -176,7 +176,7 @@ export async function processPrelude( ...@@ -176,7 +176,7 @@ export async function processPrelude(
// Composed helpers // Composed helpers
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
export function createInlinedDataStream( export function createWebInlinedDataStream(
source: AnyStream, source: AnyStream,
nonce: string | undefined, nonce: string | undefined,
formState: unknown | null formState: unknown | null
...@@ -188,6 +188,14 @@ export function createInlinedDataStream( ...@@ -188,6 +188,14 @@ export function createInlinedDataStream(
) )
} }
export function createNodeInlinedDataStream(
_source: AnyStream,
_nonce: string | undefined,
_formState: unknown | null
): AnyStream {
throw new Error('not implemented')
}
export function createPendingStream(): AnyStream { export function createPendingStream(): AnyStream {
return new ReadableStream<Uint8Array>() return new ReadableStream<Uint8Array>()
} }
...@@ -214,7 +222,16 @@ export async function resumeAndAbort( ...@@ -214,7 +222,16 @@ export async function resumeAndAbort(
) )
} }
export function renderToFlightStream( export function renderToNodeFlightStream(
_ComponentMod: FlightComponentMod,
_payload: FlightPayload,
_clientModules: FlightClientModules,
_opts: FlightRenderOptions
): AnyStream {
throw new Error('not implemented')
}
export function renderToWebFlightStream(
ComponentMod: FlightComponentMod, ComponentMod: FlightComponentMod,
payload: FlightPayload, payload: FlightPayload,
clientModules: FlightClientModules, clientModules: FlightClientModules,
...@@ -227,7 +244,7 @@ export async function streamToString(stream: AnyStream): Promise<string> { ...@@ -227,7 +244,7 @@ export async function streamToString(stream: AnyStream): Promise<string> {
return webStreamToString(stream as ReadableStream<Uint8Array>) return webStreamToString(stream as ReadableStream<Uint8Array>)
} }
export async function renderToFizzStream( export async function renderToWebFizzStream(
element: React.ReactElement, element: React.ReactElement,
streamOptions: any streamOptions: any
): Promise<FizzStreamResult> { ): Promise<FizzStreamResult> {
...@@ -239,6 +256,13 @@ export async function renderToFizzStream( ...@@ -239,6 +256,13 @@ export async function renderToFizzStream(
return { stream, allReady: stream.allReady, abort: undefined } return { stream, allReady: stream.allReady, abort: undefined }
} }
export async function renderToNodeFizzStream(
_element: React.ReactElement,
_streamOptions: any
): Promise<FizzStreamResult> {
throw new Error('Not implemented')
}
export async function resumeToFizzStream( export async function resumeToFizzStream(
element: React.ReactElement, element: React.ReactElement,
postponedState: PostponedState, postponedState: PostponedState,
......
...@@ -343,7 +343,7 @@ export function renderToInitialFizzStream({ ...@@ -343,7 +343,7 @@ export function renderToInitialFizzStream({
) )
} }
function createMetadataTransformStream( export function createMetadataTransformStream(
insert: () => Promise<string> | string insert: () => Promise<string> | string
): TransformStream<Uint8Array, Uint8Array> { ): TransformStream<Uint8Array, Uint8Array> {
let chunkIndex = -1 let chunkIndex = -1
...@@ -444,7 +444,7 @@ function createMetadataTransformStream( ...@@ -444,7 +444,7 @@ function createMetadataTransformStream(
}) })
} }
function createHeadInsertionTransformStream( export function createHeadInsertionTransformStream(
insert: () => Promise<string> insert: () => Promise<string>
): TransformStream<Uint8Array, Uint8Array> { ): TransformStream<Uint8Array, Uint8Array> {
let inserted = false let inserted = false
...@@ -668,7 +668,7 @@ export function createInstantTestScriptInsertionTransformStream( ...@@ -668,7 +668,7 @@ export function createInstantTestScriptInsertionTransformStream(
// Suffix after main body content - scripts before </body>, // Suffix after main body content - scripts before </body>,
// but wait for the major chunks to be enqueued. // but wait for the major chunks to be enqueued.
function createDeferredSuffixStream( export function createDeferredSuffixStream(
suffix: string suffix: string
): TransformStream<Uint8Array, Uint8Array> { ): TransformStream<Uint8Array, Uint8Array> {
let flushed = false let flushed = false
...@@ -713,7 +713,7 @@ function createDeferredSuffixStream( ...@@ -713,7 +713,7 @@ function createDeferredSuffixStream(
}) })
} }
function createFlightDataInjectionTransformStream( export function createFlightDataInjectionTransformStream(
stream: ReadableStream<Uint8Array>, stream: ReadableStream<Uint8Array>,
delayDataUntilFirstHtmlChunk: boolean delayDataUntilFirstHtmlChunk: boolean
): TransformStream<Uint8Array, Uint8Array> { ): TransformStream<Uint8Array, Uint8Array> {
...@@ -793,14 +793,17 @@ function createFlightDataInjectionTransformStream( ...@@ -793,14 +793,17 @@ function createFlightDataInjectionTransformStream(
}) })
} }
const CLOSE_TAG = '</body></html>' export const CLOSE_TAG = '</body></html>'
/** /**
* This transform stream moves the suffix to the end of the stream, so results * This transform stream moves the suffix to the end of the stream, so results
* like `</body></html><script>...</script>` will be transformed to * like `</body></html><script>...</script>` will be transformed to
* `<script>...</script></body></html>`. * `<script>...</script></body></html>`.
*/ */
function createMoveSuffixStream(): TransformStream<Uint8Array, Uint8Array> { export function createMoveSuffixStream(): TransformStream<
Uint8Array,
Uint8Array
> {
let foundSuffix = false let foundSuffix = false
return new TransformStream({ return new TransformStream({
...@@ -875,7 +878,7 @@ function createStripDocumentClosingTagsTransform(): TransformStream< ...@@ -875,7 +878,7 @@ function createStripDocumentClosingTagsTransform(): TransformStream<
}) })
} }
function createHtmlDataDplIdTransformStream( export function createHtmlDataDplIdTransformStream(
dplId: string dplId: string
): TransformStream<Uint8Array, Uint8Array> { ): TransformStream<Uint8Array, Uint8Array> {
let didTransform = false let didTransform = false
...@@ -973,7 +976,7 @@ export function createRootLayoutValidatorStream(): TransformStream< ...@@ -973,7 +976,7 @@ export function createRootLayoutValidatorStream(): TransformStream<
}) })
} }
function chainTransformers<T>( export function chainTransformers<T>(
readable: ReadableStream<T>, readable: ReadableStream<T>,
transformers: ReadonlyArray<TransformStream<T, T> | null> transformers: ReadonlyArray<TransformStream<T, T> | null>
): ReadableStream<T> { ): ReadableStream<T> {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment