Unverified Commit e2d766f9 authored by Jamiboy Mohammad's avatar Jamiboy Mohammad Committed by GitHub

Enable empty generateStaticParams deploy diagnostics (#99406)

## Summary

Enable `empty-generate-static-params` in deploy mode by giving its
literal and computed empty-array cases independent test instances. Each
instance selects its route with `--debug-build-paths` and preserves
`--debug-prerender`, then checks the failed build's diagnostic through
rejected startup and retained build logs.

Keep the existing dev overlay assertions and all four bundler-specific
production snapshots unchanged. Add separate Turbopack deploy snapshots
from the observed CI output, preserving Vercel's stack and code-frame
formatting without normalizing whitespace. Both cases continue to assert
the full diagnostic, source location, and caret position.

## Verification

- Both tests and their snapshots passed locally in dev and production
with Turbopack and Webpack; both production modes were rerun after
adding the deploy snapshots.
- Compared the two new snapshots exactly against the recorded failures
from both standard and Cache Components deploy CI. Confirmed all six
existing dev/production snapshots are unchanged.
- Local deployment creation remains blocked by Vercel project
permissions. The updated deployment assertions await the next CI run.

<!-- NEXT_JS_LLM -->
parent dc671ee5
import { nextTestSetup } from 'e2e-utils' import { isNextDev, nextTestSetup } from 'e2e-utils'
// @force-gate !deploy
describe('empty-generate-static-params', () => { describe('empty-generate-static-params', () => {
const { next, isNextDev, isTurbopack, skipped } = nextTestSetup({
files: __dirname,
skipStart: true,
})
if (skipped) {
return
}
function errorBlock(cliOutput: string) { function errorBlock(cliOutput: string) {
return cliOutput.slice( return cliOutput.slice(
cliOutput.indexOf('When using Cache Components'), cliOutput.indexOf('When using Cache Components'),
...@@ -19,7 +9,7 @@ describe('empty-generate-static-params', () => { ...@@ -19,7 +9,7 @@ describe('empty-generate-static-params', () => {
} }
if (isNextDev) { if (isNextDev) {
beforeAll(() => next.start()) const { next } = nextTestSetup({ files: __dirname })
it('points the redbox at a literal empty array', async () => { it('points the redbox at a literal empty array', async () => {
const browser = await next.browser('/foo') const browser = await next.browser('/foo')
...@@ -59,19 +49,38 @@ describe('empty-generate-static-params', () => { ...@@ -59,19 +49,38 @@ describe('empty-generate-static-params', () => {
`) `)
}) })
} else { } else {
// Build one page at a time so each route's build error is isolated and can describe('literal empty array', () => {
// be asserted individually. const { next, isTurbopack, isNextDeploy } = nextTestSetup({
async function buildPage(page: string) { files: __dirname,
const { exitCode, cliOutput } = await next.build({ skipStart: true,
args: ['--debug-prerender', '--debug-build-paths', page], // Isolate this route's diagnostic and preserve its source code frame.
buildArgs: [
'--debug-prerender',
'--debug-build-paths',
'app/[slug]/page.tsx',
],
}) })
expect(exitCode).not.toBe(0)
return errorBlock(cliOutput)
}
it('points the literal empty array build error at the array', async () => { it('points the literal empty array build error at the array', async () => {
const block = await buildPage('app/[slug]/page.tsx') await expect(next.start()).rejects.toThrow()
if (isTurbopack) { const block = errorBlock(next.cliOutput)
if (isTurbopack && isNextDeploy) {
// Vercel build logs omit leading indentation from stack and code frames.
expect(block).toMatchInlineSnapshot(`
"When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
Learn more: https://nextjs.org/docs/messages/empty-generate-static-params
at generateStaticParams (app/[slug]/page.tsx:10:10)
8 |
9 | export async function generateStaticParams() {
> 10 | return []
| ^
11 | }
12 |
> "
`)
} else if (isTurbopack) {
expect(block).toMatchInlineSnapshot(` expect(block).toMatchInlineSnapshot(`
"When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error. "When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
...@@ -102,11 +111,42 @@ describe('empty-generate-static-params', () => { ...@@ -102,11 +111,42 @@ describe('empty-generate-static-params', () => {
> " > "
`) `)
} }
}, 240_000)
})
describe('computed empty array', () => {
const { next, isTurbopack, isNextDeploy } = nextTestSetup({
files: __dirname,
skipStart: true,
// Isolate this route's diagnostic and preserve its source code frame.
buildArgs: [
'--debug-prerender',
'--debug-build-paths',
'app/computed/[slug]/page.tsx',
],
}) })
it('points the computed empty array build error at the declaration', async () => { it('points the computed empty array build error at the declaration', async () => {
const block = await buildPage('app/computed/[slug]/page.tsx') await expect(next.start()).rejects.toThrow()
if (isTurbopack) { const block = errorBlock(next.cliOutput)
if (isTurbopack && isNextDeploy) {
// Vercel build logs omit leading indentation from stack and code frames.
expect(block).toMatchInlineSnapshot(`
"When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
Learn more: https://nextjs.org/docs/messages/empty-generate-static-params
at generateStaticParams (app/computed/[slug]/page.tsx:9:8)
7 | }
8 |
> 9 | export async function generateStaticParams() {
| ^
10 | // Empty at runtime but not statically analyzable, so it falls back to the
11 | // factory stack anchored at the declaration.
12 | const items: string[] = []
> "
`)
} else if (isTurbopack) {
expect(block).toMatchInlineSnapshot(` expect(block).toMatchInlineSnapshot(`
"When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error. "When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
...@@ -139,6 +179,7 @@ describe('empty-generate-static-params', () => { ...@@ -139,6 +179,7 @@ describe('empty-generate-static-params', () => {
> " > "
`) `)
} }
}, 240_000)
}) })
} }
}) })
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment