Unverified Commit e56e53c9 authored by Jamiboy Mohammad's avatar Jamiboy Mohammad Committed by GitHub

ci: only declare a Vercel deploy target for webpack runs without a custom script (#100479)

## Summary

`test_e2e_deploy_release.yml` can be dispatched with a custom deploy
script to run the deploy suite against another platform's adapter. The
webpack job still set `NEXT_TEST_DEPLOY_TARGET_VERCEL=1` in that case,
so tests gated on the `vercel` condition from #99837 ran against the
other platform instead of being skipped.

The webpack job now sets it only when no custom deploy script is given,
as the Turbopack job already does. The adapter job is unchanged: it
doesn't accept custom scripts, so it always deploys to Vercel.

## Verification

- The webpack and Turbopack jobs now use the same
`NEXT_TEST_DEPLOY_TARGET_VERCEL` expression, and the workflow still
parses.
- Not run: a dispatched `test-e2e-deploy-release` run
(`workflow_dispatch` only).

<!-- NEXT_JS_LLM -->
parent 68f20d1c
...@@ -190,7 +190,7 @@ jobs: ...@@ -190,7 +190,7 @@ jobs:
NEXT_TEST_MODE=deploy \ NEXT_TEST_MODE=deploy \
IS_WEBPACK_TEST=1 \ IS_WEBPACK_TEST=1 \
NEXT_ENABLE_ADAPTER=0 \ NEXT_ENABLE_ADAPTER=0 \
NEXT_TEST_DEPLOY_TARGET_VERCEL=1 \ NEXT_TEST_DEPLOY_TARGET_VERCEL="${{ github.event.inputs.deployScriptPath == '' && '1' || '' }}" \
NEXT_EXTERNAL_TESTS_FILTERS="test/deploy-tests-manifest.json" \ NEXT_EXTERNAL_TESTS_FILTERS="test/deploy-tests-manifest.json" \
NEXT_TEST_VERSION="${{ needs.setup.outputs.next-version }}" \ NEXT_TEST_VERSION="${{ needs.setup.outputs.next-version }}" \
VERCEL_CLI_VERSION="${{ github.event.inputs.vercelCliVersion || 'vercel@latest' }}" \ VERCEL_CLI_VERSION="${{ github.event.inputs.vercelCliVersion || 'vercel@latest' }}" \
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment