Unverified Commit f7069c02 authored by Shu Ding's avatar Shu Ding Committed by GitHub

Fix unused CSS module imports are tracked on the server (#40996)

Reported by @hanneslund, when a CSS modules file gets imported in server
components, during `collectClientComponentsAndCSSForDependency` in our
client entry plugin it will always be collected no matter it is used or
not. Due to the restriction that we have to collect these imports to
create the client entry, it has to run in the `finishMake` compiler
phase and at that time, module optimization hasn't started yet.

To fix that issue, we run another pass in `afterOptimizeModules` just to
collect CSS imports for the server style manifest and we can filter out
unused modules there.

## Bug

- [ ] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
Co-authored-by: 's avatarkodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
parent 5831097c
...@@ -14,6 +14,7 @@ import type { ...@@ -14,6 +14,7 @@ import type {
import { APP_DIR_ALIAS } from '../../../lib/constants' import { APP_DIR_ALIAS } from '../../../lib/constants'
import { import {
COMPILER_NAMES, COMPILER_NAMES,
EDGE_RUNTIME_WEBPACK,
FLIGHT_SERVER_CSS_MANIFEST, FLIGHT_SERVER_CSS_MANIFEST,
} from '../../../shared/lib/constants' } from '../../../shared/lib/constants'
import { FlightCSSManifest, traverseModules } from './flight-manifest-plugin' import { FlightCSSManifest, traverseModules } from './flight-manifest-plugin'
...@@ -84,8 +85,16 @@ export class FlightClientEntryPlugin { ...@@ -84,8 +85,16 @@ export class FlightClientEntryPlugin {
ReturnType<typeof this.injectClientEntryAndSSRModules> ReturnType<typeof this.injectClientEntryAndSSRModules>
> = [] > = []
// For each SC server compilation entry, we need to create its corresponding // Loop over all the entry modules.
// client component entry. function forEachEntryModule(
callback: ({
name,
entryModule,
}: {
name: string
entryModule: any
}) => void
) {
for (const [name, entry] of compilation.entries.entries()) { for (const [name, entry] of compilation.entries.entries()) {
// Check if the page entry is a server component or not. // Check if the page entry is a server component or not.
const entryDependency: webpack.NormalModule | undefined = const entryDependency: webpack.NormalModule | undefined =
...@@ -108,11 +117,19 @@ export class FlightClientEntryPlugin { ...@@ -108,11 +117,19 @@ export class FlightClientEntryPlugin {
entryModule.dependencies.forEach((dependency) => { entryModule.dependencies.forEach((dependency) => {
const modRequest: string | undefined = (dependency as any).request const modRequest: string | undefined = (dependency as any).request
if (modRequest?.includes('next-app-loader')) { if (modRequest?.includes('next-app-loader')) {
entryModule = compilation.moduleGraph.getResolvedModule(dependency) entryModule =
compilation.moduleGraph.getResolvedModule(dependency)
} }
}) })
} }
callback({ name, entryModule })
}
}
// For each SC server compilation entry, we need to create its corresponding
// client component entry.
forEachEntryModule(({ name, entryModule }) => {
const internalClientComponentEntryImports = new Set< const internalClientComponentEntryImports = new Set<
ClientComponentImports[0] ClientComponentImports[0]
>() >()
...@@ -123,15 +140,13 @@ export class FlightClientEntryPlugin { ...@@ -123,15 +140,13 @@ export class FlightClientEntryPlugin {
const layoutOrPageDependency = connection.dependency const layoutOrPageDependency = connection.dependency
const layoutOrPageRequest = connection.dependency.request const layoutOrPageRequest = connection.dependency.request
const [clientComponentImports, cssImports] = const [clientComponentImports] =
this.collectClientComponentsAndCSSForDependency({ this.collectClientComponentsAndCSSForDependency({
layoutOrPageRequest, layoutOrPageRequest,
compilation, compilation,
dependency: layoutOrPageDependency, dependency: layoutOrPageDependency,
}) })
Object.assign(flightCSSManifest, cssImports)
const isAbsoluteRequest = layoutOrPageRequest[0] === '/' const isAbsoluteRequest = layoutOrPageRequest[0] === '/'
// Next.js internals are put into a separate entry. // Next.js internals are put into a separate entry.
...@@ -170,7 +185,28 @@ export class FlightClientEntryPlugin { ...@@ -170,7 +185,28 @@ export class FlightClientEntryPlugin {
bundlePath: 'app-internals', bundlePath: 'app-internals',
}) })
) )
})
// After optimizing all the modules, we collect the CSS that are still used.
compilation.hooks.afterOptimizeModules.tap(PLUGIN_NAME, () => {
forEachEntryModule(({ entryModule }) => {
for (const connection of compilation.moduleGraph.getOutgoingConnections(
entryModule
)) {
const layoutOrPageDependency = connection.dependency
const layoutOrPageRequest = connection.dependency.request
const [, cssImports] =
this.collectClientComponentsAndCSSForDependency({
layoutOrPageRequest,
compilation,
dependency: layoutOrPageDependency,
})
Object.assign(flightCSSManifest, cssImports)
} }
})
})
compilation.hooks.processAssets.tap( compilation.hooks.processAssets.tap(
{ {
...@@ -261,6 +297,21 @@ export class FlightClientEntryPlugin { ...@@ -261,6 +297,21 @@ export class FlightClientEntryPlugin {
const isClientComponent = isClientComponentModule(mod) const isClientComponent = isClientComponentModule(mod)
if (isCSS) { if (isCSS) {
const sideEffectFree =
mod.factoryMeta && (mod.factoryMeta as any).sideEffectFree
if (sideEffectFree) {
const unused = !compilation.moduleGraph
.getExportsInfo(mod)
.isModuleUsed(
this.isEdgeServer ? EDGE_RUNTIME_WEBPACK : 'webpack-runtime'
)
if (unused) {
return
}
}
serverCSSImports[layoutOrPageRequest] = serverCSSImports[layoutOrPageRequest] =
serverCSSImports[layoutOrPageRequest] || [] serverCSSImports[layoutOrPageRequest] || []
serverCSSImports[layoutOrPageRequest].push(modRequest) serverCSSImports[layoutOrPageRequest].push(modRequest)
......
import './style.css' import './style.css'
import styles from './style.module.css' import styles from './style.module.css'
export default function Page() { export default function Page() {
......
import { styles } from './styles'
export default function Page() {
return (
<>
<h1>Page</h1>
<div id="cssm" className={styles.mod}>
CSSM
</div>
</>
)
}
import unused from './unused.module.css'
import styles from '../style.module.css'
export { unused, styles }
.this_should_not_be_included {
color: red;
}
...@@ -1186,6 +1186,17 @@ describe('app dir', () => { ...@@ -1186,6 +1186,17 @@ describe('app dir', () => {
) )
).toBe('rgb(0, 0, 255)') ).toBe('rgb(0, 0, 255)')
}) })
if (!isDev) {
it('should not include unused css modules in the page in prod', async () => {
const browser = await webdriver(next.url, '/css/css-page')
expect(
await browser.eval(
`[...document.styleSheets].some(({ rules }) => [...rules].some(rule => rule.selectorText.includes('this_should_not_be_included')))`
)
).toBe(false)
})
}
}) })
describe('client layouts', () => { describe('client layouts', () => {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment