Unverified Commit f9987b09 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Add tracing for css-loader (#28756)

Co-authored-by: 's avatarkodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: 's avatarSteven <steven@ceriously.com>
parent dc1e906e
...@@ -30,14 +30,16 @@ export default async function loader(content, map, meta) { ...@@ -30,14 +30,16 @@ export default async function loader(content, map, meta) {
const plugins = [] const plugins = []
const callback = this.async() const callback = this.async()
const loaderSpan = this.currentTraceSpan.traceChild('css-loader')
loaderSpan
.traceAsyncFn(async () => {
let options let options
try { try {
options = normalizeOptions(rawOptions, this) options = normalizeOptions(rawOptions, this)
} catch (error) { } catch (error) {
callback(error) throw error
return
} }
const replacements = [] const replacements = []
...@@ -135,6 +137,7 @@ export default async function loader(content, map, meta) { ...@@ -135,6 +137,7 @@ export default async function loader(content, map, meta) {
if (ast && ast.type === 'postcss') { if (ast && ast.type === 'postcss') {
// eslint-disable-next-line no-param-reassign // eslint-disable-next-line no-param-reassign
content = ast.root content = ast.root
loaderSpan.setAttribute('astUsed', 'true')
} }
} }
...@@ -159,11 +162,9 @@ export default async function loader(content, map, meta) { ...@@ -159,11 +162,9 @@ export default async function loader(content, map, meta) {
this.addDependency(error.file) this.addDependency(error.file)
} }
callback( throw error.name === 'CssSyntaxError'
error.name === 'CssSyntaxError' ? new CssSyntaxError(error) : error ? new CssSyntaxError(error)
) : error
return
} }
for (const warning of result.warnings()) { for (const warning of result.warnings()) {
...@@ -189,5 +190,14 @@ export default async function loader(content, map, meta) { ...@@ -189,5 +190,14 @@ export default async function loader(content, map, meta) {
const moduleCode = getModuleCode(result, api, replacements, options, this) const moduleCode = getModuleCode(result, api, replacements, options, this)
const exportCode = getExportCode(exports, replacements, options) const exportCode = getExportCode(exports, replacements, options)
callback(null, `${importCode}${moduleCode}${exportCode}`) return `${importCode}${moduleCode}${exportCode}`
})
.then(
(code) => {
callback(null, code)
},
(err) => {
callback(err)
}
)
} }
...@@ -54,6 +54,7 @@ export default async function loader(content, sourceMap, meta) { ...@@ -54,6 +54,7 @@ export default async function loader(content, sourceMap, meta) {
// Reuse PostCSS AST from other loaders // Reuse PostCSS AST from other loaders
if (meta && meta.ast && meta.ast.type === 'postcss') { if (meta && meta.ast && meta.ast.type === 'postcss') {
;({ root } = meta.ast) ;({ root } = meta.ast)
loaderSpan.setAttribute('astUsed', 'true')
} }
let result let result
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment