Unverified Commit ffbb10fa authored by Dale Bustad's avatar Dale Bustad Committed by GitHub

Silence trace debug messages (#22988)

These messages aren't necessary in the normal course of using Next.js.  Hiding behind a flag to reduce the noise.
parent 371aa608
import { trace, Span } from './trace' import { trace, Span } from './trace'
import { debugLog } from './shared'
const stacks = new WeakMap<any, Array<Span>>() const stacks = new WeakMap<any, Array<Span>>()
const stoppedSpansSets = new WeakMap<any, Set<Span>>() const stoppedSpansSets = new WeakMap<any, Set<Span>>()
...@@ -27,7 +28,7 @@ export function stackPush(keyObj: any, spanName: string, attrs?: any): Span { ...@@ -27,7 +28,7 @@ export function stackPush(keyObj: any, spanName: string, attrs?: any): Span {
export function stackPop(keyObj: any, span: any): void { export function stackPop(keyObj: any, span: any): void {
let stack = stacks.get(keyObj) let stack = stacks.get(keyObj)
if (!stack) { if (!stack) {
console.info( debugLog(
'Attempted to pop from non-existent stack. Key reference must be bad.' 'Attempted to pop from non-existent stack. Key reference must be bad.'
) )
return return
...@@ -39,7 +40,7 @@ export function stackPop(keyObj: any, span: any): void { ...@@ -39,7 +40,7 @@ export function stackPop(keyObj: any, span: any): void {
stoppedSpansSets.set(keyObj, stoppedSpans) stoppedSpansSets.set(keyObj, stoppedSpans)
} }
if (stoppedSpans.has(span)) { if (stoppedSpans.has(span)) {
console.info( debugLog(
`Attempted to terminate tracing span that was already stopped for ${span.name}` `Attempted to terminate tracing span that was already stopped for ${span.name}`
) )
return return
...@@ -56,12 +57,12 @@ export function stackPop(keyObj: any, span: any): void { ...@@ -56,12 +57,12 @@ export function stackPop(keyObj: any, span: any): void {
} else if (poppedSpan === undefined || stack.indexOf(span) === -1) { } else if (poppedSpan === undefined || stack.indexOf(span) === -1) {
// We've either reached the top of the stack or the stack doesn't contain // We've either reached the top of the stack or the stack doesn't contain
// the span for another reason. // the span for another reason.
console.info(`Tracing span was not found in stack for: ${span.name}`) debugLog(`Tracing span was not found in stack for: ${span.name}`)
stoppedSpans.add(span) stoppedSpans.add(span)
span.stop() span.stop()
break break
} else if (stack.indexOf(span) !== -1) { } else if (stack.indexOf(span) !== -1) {
console.info( debugLog(
`Attempted to pop span that was not at top of stack for: ${span.name}` `Attempted to pop span that was not at top of stack for: ${span.name}`
) )
stoppedSpans.add(poppedSpan) stoppedSpans.add(poppedSpan)
......
...@@ -10,3 +10,7 @@ export const traceGlobals: Map<any, any> = new Map() ...@@ -10,3 +10,7 @@ export const traceGlobals: Map<any, any> = new Map()
export const setGlobal = (key: any, val: any) => { export const setGlobal = (key: any, val: any) => {
traceGlobals.set(key, val) traceGlobals.set(key, val)
} }
export const debugLog = !!process.env.TRACE_DEBUG
? console.info
: function noop() {}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment