Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
059c255c
Unverified
Commit
059c255c
authored
Mar 04, 2025
by
Sebastian "Sebbie" Silbermann
Committed by
GitHub
Mar 04, 2025
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[dev-overlay] Always show relative paths (#76742)
parent
5d53fd00
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
147 additions
and
115 deletions
+147
-115
middleware-turbopack.ts
...mponents/react-dev-overlay/server/middleware-turbopack.ts
+28
-13
middleware-webpack.ts
...components/react-dev-overlay/server/middleware-webpack.ts
+11
-1
hot-reloader-turbopack.ts
packages/next/src/server/dev/hot-reloader-turbopack.ts
+8
-8
ReactRefreshLogBox.test.ts
test/development/acceptance-app/ReactRefreshLogBox.test.ts
+18
-18
ReactRefreshLogBox.test.ts
test/development/acceptance/ReactRefreshLogBox.test.ts
+38
-37
error-recovery.test.ts
test/development/acceptance/error-recovery.test.ts
+32
-26
index.test.ts
test/development/pages-dir/client-navigation/index.test.ts
+4
-4
non-root-project-monorepo.test.ts
...n-root-project-monorepo/non-root-project-monorepo.test.ts
+8
-8
No files found.
packages/next/src/client/components/react-dev-overlay/server/middleware-turbopack.ts
View file @
059c255c
...
@@ -34,7 +34,7 @@ function shouldIgnorePath(modulePath: string): boolean {
...
@@ -34,7 +34,7 @@ function shouldIgnorePath(modulePath: string): boolean {
type
IgnorableStackFrame
=
StackFrame
&
{
ignored
:
boolean
}
type
IgnorableStackFrame
=
StackFrame
&
{
ignored
:
boolean
}
const
currentSourcesByFile
:
Map
<
string
,
Promise
<
string
|
null
>>
=
new
Map
()
const
currentSourcesByFile
:
Map
<
string
,
Promise
<
string
|
null
>>
=
new
Map
()
export
async
function
batchedTraceSource
(
async
function
batchedTraceSource
(
project
:
Project
,
project
:
Project
,
frame
:
TurbopackStackFrame
frame
:
TurbopackStackFrame
):
Promise
<
{
frame
:
IgnorableStackFrame
;
source
:
string
|
null
}
|
undefined
>
{
):
Promise
<
{
frame
:
IgnorableStackFrame
;
source
:
string
|
null
}
|
undefined
>
{
...
@@ -316,9 +316,7 @@ async function nativeTraceSource(
...
@@ -316,9 +316,7 @@ async function nativeTraceSource(
?.
replace
(
'__WEBPACK_DEFAULT_EXPORT__'
,
'default'
)
?.
replace
(
'__WEBPACK_DEFAULT_EXPORT__'
,
'default'
)
?.
replace
(
'__webpack_exports__.'
,
''
)
||
'<unknown>'
,
?.
replace
(
'__webpack_exports__.'
,
''
)
||
'<unknown>'
,
column
:
(
originalPosition
.
column
??
0
)
+
1
,
column
:
(
originalPosition
.
column
??
0
)
+
1
,
file
:
originalPosition
.
source
?.
startsWith
(
'file://'
)
file
:
originalPosition
.
source
,
?
relativeToCwd
(
originalPosition
.
source
)
:
originalPosition
.
source
,
lineNumber
:
originalPosition
.
line
??
0
,
lineNumber
:
originalPosition
.
line
??
0
,
// TODO: c&p from async createOriginalStackFrame but why not frame.arguments?
// TODO: c&p from async createOriginalStackFrame but why not frame.arguments?
arguments
:
[],
arguments
:
[],
...
@@ -335,14 +333,9 @@ async function nativeTraceSource(
...
@@ -335,14 +333,9 @@ async function nativeTraceSource(
return
undefined
return
undefined
}
}
function
relativeToCwd
(
file
:
string
):
string
{
const
relPath
=
path
.
relative
(
process
.
cwd
(),
url
.
fileURLToPath
(
file
))
// TODO(sokra) include a ./ here to make it a relative path
return
relPath
}
async
function
createOriginalStackFrame
(
async
function
createOriginalStackFrame
(
project
:
Project
,
project
:
Project
,
projectPath
:
string
,
frame
:
TurbopackStackFrame
frame
:
TurbopackStackFrame
):
Promise
<
OriginalStackFrameResponse
|
null
>
{
):
Promise
<
OriginalStackFrameResponse
|
null
>
{
const
traced
=
const
traced
=
...
@@ -354,13 +347,31 @@ async function createOriginalStackFrame(
...
@@ -354,13 +347,31 @@ async function createOriginalStackFrame(
return
null
return
null
}
}
let
normalizedStackFrameLocation
=
traced
.
frame
.
file
if
(
normalizedStackFrameLocation
!==
null
&&
normalizedStackFrameLocation
.
startsWith
(
'file://'
)
)
{
normalizedStackFrameLocation
=
path
.
relative
(
projectPath
,
url
.
fileURLToPath
(
normalizedStackFrameLocation
)
)
}
return
{
return
{
originalStackFrame
:
traced
.
frame
,
originalStackFrame
:
{
arguments
:
traced
.
frame
.
arguments
,
column
:
traced
.
frame
.
column
,
file
:
normalizedStackFrameLocation
,
ignored
:
traced
.
frame
.
ignored
,
lineNumber
:
traced
.
frame
.
lineNumber
,
methodName
:
traced
.
frame
.
methodName
,
},
originalCodeFrame
:
getOriginalCodeFrame
(
traced
.
frame
,
traced
.
source
),
originalCodeFrame
:
getOriginalCodeFrame
(
traced
.
frame
,
traced
.
source
),
}
}
}
}
export
function
getOverlayMiddleware
(
project
:
Project
)
{
export
function
getOverlayMiddleware
(
project
:
Project
,
projectPath
:
string
)
{
return
async
function
(
return
async
function
(
req
:
IncomingMessage
,
req
:
IncomingMessage
,
res
:
ServerResponse
,
res
:
ServerResponse
,
...
@@ -387,7 +398,11 @@ export function getOverlayMiddleware(project: Project) {
...
@@ -387,7 +398,11 @@ export function getOverlayMiddleware(project: Project) {
const
result
:
OriginalStackFramesResponse
=
await
Promise
.
all
(
const
result
:
OriginalStackFramesResponse
=
await
Promise
.
all
(
stackFrames
.
map
(
async
(
frame
)
=>
{
stackFrames
.
map
(
async
(
frame
)
=>
{
try
{
try
{
const
stackFrame
=
await
createOriginalStackFrame
(
project
,
frame
)
const
stackFrame
=
await
createOriginalStackFrame
(
project
,
projectPath
,
frame
)
if
(
stackFrame
===
null
)
{
if
(
stackFrame
===
null
)
{
return
{
return
{
status
:
'rejected'
,
status
:
'rejected'
,
...
...
packages/next/src/client/components/react-dev-overlay/server/middleware-webpack.ts
View file @
059c255c
...
@@ -471,9 +471,19 @@ async function getOriginalStackFrame({
...
@@ -471,9 +471,19 @@ async function getOriginalStackFrame({
},
},
})
})
let
defaultNormalizedStackFrameLocation
=
frame
.
file
if
(
defaultNormalizedStackFrameLocation
!==
null
&&
defaultNormalizedStackFrameLocation
.
startsWith
(
'file://'
)
)
{
defaultNormalizedStackFrameLocation
=
path
.
relative
(
rootDirectory
,
fileURLToPath
(
defaultNormalizedStackFrameLocation
)
)
}
// This stack frame is used for the one that couldn't locate the source or source mapped frame
// This stack frame is used for the one that couldn't locate the source or source mapped frame
const
defaultStackFrame
:
IgnorableStackFrame
=
{
const
defaultStackFrame
:
IgnorableStackFrame
=
{
file
:
frame
.
file
,
file
:
defaultNormalizedStackFrameLocation
,
lineNumber
:
frame
.
lineNumber
,
lineNumber
:
frame
.
lineNumber
,
column
:
frame
.
column
??
1
,
column
:
frame
.
column
??
1
,
methodName
:
frame
.
methodName
,
methodName
:
frame
.
methodName
,
...
...
packages/next/src/server/dev/hot-reloader-turbopack.ts
View file @
059c255c
...
@@ -161,7 +161,7 @@ export async function createHotReloaderTurbopack(
...
@@ -161,7 +161,7 @@ export async function createHotReloaderTurbopack(
):
Promise
<
NextJsHotReloaderInterface
>
{
):
Promise
<
NextJsHotReloaderInterface
>
{
const
dev
=
true
const
dev
=
true
const
buildId
=
'development'
const
buildId
=
'development'
const
{
nextConfig
,
dir
}
=
opts
const
{
nextConfig
,
dir
:
projectPath
}
=
opts
const
{
loadBindings
}
=
const
{
loadBindings
}
=
require
(
'../../build/swc'
)
as
typeof
import
(
'../../build/swc'
)
require
(
'../../build/swc'
)
as
typeof
import
(
'../../build/swc'
)
...
@@ -172,7 +172,7 @@ export async function createHotReloaderTurbopack(
...
@@ -172,7 +172,7 @@ export async function createHotReloaderTurbopack(
// works correctly. Normally `run-test` hides output so only will be visible when `--debug` flag is used.
// works correctly. Normally `run-test` hides output so only will be visible when `--debug` flag is used.
if
(
process
.
env
.
TURBOPACK
&&
isTestMode
)
{
if
(
process
.
env
.
TURBOPACK
&&
isTestMode
)
{
require
(
'console'
).
log
(
'Creating turbopack project'
,
{
require
(
'console'
).
log
(
'Creating turbopack project'
,
{
dir
,
dir
:
projectPath
,
testMode
:
isTestMode
,
testMode
:
isTestMode
,
})
})
}
}
...
@@ -207,14 +207,14 @@ export async function createHotReloaderTurbopack(
...
@@ -207,14 +207,14 @@ export async function createHotReloaderTurbopack(
const
project
=
await
bindings
.
turbo
.
createProject
(
const
project
=
await
bindings
.
turbo
.
createProject
(
{
{
projectPath
:
dir
,
projectPath
:
projectPath
,
rootPath
:
rootPath
:
opts
.
nextConfig
.
experimental
.
turbo
?.
root
||
opts
.
nextConfig
.
experimental
.
turbo
?.
root
||
opts
.
nextConfig
.
outputFileTracingRoot
||
opts
.
nextConfig
.
outputFileTracingRoot
||
dir
,
projectPath
,
distDir
,
distDir
,
nextConfig
:
opts
.
nextConfig
,
nextConfig
:
opts
.
nextConfig
,
jsConfig
:
await
getTurbopackJsConfig
(
dir
,
nextConfig
),
jsConfig
:
await
getTurbopackJsConfig
(
projectPath
,
nextConfig
),
watch
:
{
watch
:
{
enable
:
dev
,
enable
:
dev
,
pollIntervalMs
:
nextConfig
.
watchOptions
?.
pollIntervalMs
,
pollIntervalMs
:
nextConfig
.
watchOptions
?.
pollIntervalMs
,
...
@@ -244,7 +244,7 @@ export async function createHotReloaderTurbopack(
...
@@ -244,7 +244,7 @@ export async function createHotReloaderTurbopack(
}
}
)
)
setBundlerFindSourceMapImplementation
(
setBundlerFindSourceMapImplementation
(
getSourceMapFromTurbopack
.
bind
(
null
,
project
,
dir
)
getSourceMapFromTurbopack
.
bind
(
null
,
project
,
projectPath
)
)
)
opts
.
onDevServerCleanup
?.(
async
()
=>
{
opts
.
onDevServerCleanup
?.(
async
()
=>
{
setBundlerFindSourceMapImplementation
(()
=>
undefined
)
setBundlerFindSourceMapImplementation
(()
=>
undefined
)
...
@@ -634,7 +634,7 @@ export async function createHotReloaderTurbopack(
...
@@ -634,7 +634,7 @@ export async function createHotReloaderTurbopack(
)
)
const
middlewares
=
[
const
middlewares
=
[
getOverlayMiddleware
(
project
),
getOverlayMiddleware
(
project
,
projectPath
),
getSourceMapMiddleware
(
project
),
getSourceMapMiddleware
(
project
),
getNextErrorFeedbackMiddleware
(
opts
.
telemetry
),
getNextErrorFeedbackMiddleware
(
opts
.
telemetry
),
getDevOverlayFontMiddleware
(),
getDevOverlayFontMiddleware
(),
...
@@ -957,7 +957,7 @@ export async function createHotReloaderTurbopack(
...
@@ -957,7 +957,7 @@ export async function createHotReloaderTurbopack(
>
=
>
=
definition
??
definition
??
(
await
findPagePathData
(
(
await
findPagePathData
(
dir
,
projectPath
,
inputPage
,
inputPage
,
nextConfig
.
pageExtensions
,
nextConfig
.
pageExtensions
,
opts
.
pagesDir
,
opts
.
pagesDir
,
...
...
test/development/acceptance-app/ReactRefreshLogBox.test.ts
View file @
059c255c
...
@@ -115,15 +115,15 @@ describe('ReactRefreshLogBox app', () => {
...
@@ -115,15 +115,15 @@ describe('ReactRefreshLogBox app', () => {
| ^",
| ^",
"stack": [
"stack": [
"eval index.js (3:7)",
"eval index.js (3:7)",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"eval ./app/page.js",
"eval ./app/page.js",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
],
],
}
}
`
)
`
)
...
@@ -1468,10 +1468,10 @@ describe('ReactRefreshLogBox app', () => {
...
@@ -1468,10 +1468,10 @@ describe('ReactRefreshLogBox app', () => {
"stack": [
"stack": [
"eval index.js (1:7)",
"eval index.js (1:7)",
"<FIXME-next-dist-dir>",
"<FIXME-next-dist-dir>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"eval ./app/server/page.js",
"eval ./app/server/page.js",
"<FIXME-next-dist-dir>",
"<FIXME-next-dist-dir>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
],
],
}
}
`
)
`
)
...
@@ -1639,15 +1639,15 @@ export default function Home() {
...
@@ -1639,15 +1639,15 @@ export default function Home() {
| ^",
| ^",
"stack": [
"stack": [
"eval app/utils.ts (1:7)",
"eval app/utils.ts (1:7)",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"eval ./app/page.js",
"eval ./app/page.js",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
],
],
}
}
`
)
`
)
...
...
test/development/acceptance/ReactRefreshLogBox.test.ts
View file @
059c255c
...
@@ -131,9 +131,9 @@ describe('ReactRefreshLogBox', () => {
...
@@ -131,9 +131,9 @@ describe('ReactRefreshLogBox', () => {
| ^",
| ^",
"stack": [
"stack": [
"[project]/index.js [ssr] (ecmascript) index.js (3:7)",
"[project]/index.js [ssr] (ecmascript) index.js (3:7)",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
],
],
}
}
`
)
`
)
...
@@ -149,18 +149,18 @@ describe('ReactRefreshLogBox', () => {
...
@@ -149,18 +149,18 @@ describe('ReactRefreshLogBox', () => {
| ^",
| ^",
"stack": [
"stack": [
"eval index.js (3:7)",
"eval index.js (3:7)",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"eval ./pages/index.js",
"eval ./pages/index.js",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
],
],
}
}
`
)
`
)
...
@@ -178,9 +178,9 @@ describe('ReactRefreshLogBox', () => {
...
@@ -178,9 +178,9 @@ describe('ReactRefreshLogBox', () => {
| ^",
| ^",
"stack": [
"stack": [
"[project]/index.js [ssr] (ecmascript) index.js (3:7)",
"[project]/index.js [ssr] (ecmascript) index.js (3:7)",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
],
],
}
}
`
)
`
)
...
@@ -196,18 +196,18 @@ describe('ReactRefreshLogBox', () => {
...
@@ -196,18 +196,18 @@ describe('ReactRefreshLogBox', () => {
| ^",
| ^",
"stack": [
"stack": [
"eval index.js (3:7)",
"eval index.js (3:7)",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"eval ./pages/index.js",
"eval ./pages/index.js",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
],
],
}
}
`
)
`
)
...
@@ -284,8 +284,8 @@ describe('ReactRefreshLogBox', () => {
...
@@ -284,8 +284,8 @@ describe('ReactRefreshLogBox', () => {
"stack": [
"stack": [
"FunctionDefault FunctionDefault.js (1:51)",
"FunctionDefault FunctionDefault.js (1:51)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
@@ -302,8 +302,8 @@ describe('ReactRefreshLogBox', () => {
...
@@ -302,8 +302,8 @@ describe('ReactRefreshLogBox', () => {
"stack": [
"stack": [
"FunctionDefault FunctionDefault.js (1:51)",
"FunctionDefault FunctionDefault.js (1:51)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
@@ -413,7 +413,6 @@ describe('ReactRefreshLogBox', () => {
...
@@ -413,7 +413,6 @@ describe('ReactRefreshLogBox', () => {
}
}
})
})
// Module trace is only available with webpack 5
test
(
'conversion to class component (1)'
,
async
()
=>
{
test
(
'conversion to class component (1)'
,
async
()
=>
{
await
using
sandbox
=
await
createSandbox
(
next
)
await
using
sandbox
=
await
createSandbox
(
next
)
const
{
browser
,
session
}
=
sandbox
const
{
browser
,
session
}
=
sandbox
...
@@ -459,6 +458,8 @@ describe('ReactRefreshLogBox', () => {
...
@@ -459,6 +458,8 @@ describe('ReactRefreshLogBox', () => {
`
`
)
)
// TODO(veil): ignore-list Webpack runtime (https://linear.app/vercel/issue/NDX-945)
// TODO(veil): Don't bail in Turbopack for sources outside of the project (https://linear.app/vercel/issue/NDX-944)
if
(
isReact18
)
{
if
(
isReact18
)
{
await
expect
(
browser
).
toDisplayRedbox
(
`
await
expect
(
browser
).
toDisplayRedbox
(
`
{
{
...
@@ -472,8 +473,8 @@ describe('ReactRefreshLogBox', () => {
...
@@ -472,8 +473,8 @@ describe('ReactRefreshLogBox', () => {
"stack": [
"stack": [
"ClickCount.render Child.js (4:11)",
"ClickCount.render Child.js (4:11)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
@@ -490,8 +491,8 @@ describe('ReactRefreshLogBox', () => {
...
@@ -490,8 +491,8 @@ describe('ReactRefreshLogBox', () => {
"stack": [
"stack": [
"ClickCount.render Child.js (4:11)",
"ClickCount.render Child.js (4:11)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
...
test/development/acceptance/error-recovery.test.ts
View file @
059c255c
...
@@ -249,6 +249,8 @@ describe('pages/ error recovery', () => {
...
@@ -249,6 +249,8 @@ describe('pages/ error recovery', () => {
`
`
)
)
// TODO(veil): ignore-list Webpack runtime (https://linear.app/vercel/issue/NDX-945)
// TODO(veil): Don't bail in Turbopack for sources outside of the project (https://linear.app/vercel/issue/NDX-944)
// Somehow we end up with two in React 18 due to React's attempt to recover from this error.
// Somehow we end up with two in React 18 due to React's attempt to recover from this error.
if
(
isReact18
)
{
if
(
isReact18
)
{
await
expect
(
browser
).
toDisplayRedbox
(
`
await
expect
(
browser
).
toDisplayRedbox
(
`
...
@@ -263,8 +265,8 @@ describe('pages/ error recovery', () => {
...
@@ -263,8 +265,8 @@ describe('pages/ error recovery', () => {
"stack": [
"stack": [
"Child child.js (3:9)",
"Child child.js (3:9)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
@@ -281,8 +283,8 @@ describe('pages/ error recovery', () => {
...
@@ -281,8 +283,8 @@ describe('pages/ error recovery', () => {
"stack": [
"stack": [
"Child child.js (3:9)",
"Child child.js (3:9)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
@@ -527,6 +529,8 @@ describe('pages/ error recovery', () => {
...
@@ -527,6 +529,8 @@ describe('pages/ error recovery', () => {
await
expect
(
session
.
getRedboxSource
()).
resolves
.
toInclude
(
'render() {'
)
await
expect
(
session
.
getRedboxSource
()).
resolves
.
toInclude
(
'render() {'
)
})
})
// TODO(veil): ignore-list Webpack runtime (https://linear.app/vercel/issue/NDX-945)
// TODO(veil): Don't bail in Turbopack for sources outside of the project (https://linear.app/vercel/issue/NDX-944)
// Somehow we end up with two in React 18 due to React's attempt to recover from this error.
// Somehow we end up with two in React 18 due to React's attempt to recover from this error.
if
(
isReact18
)
{
if
(
isReact18
)
{
await
expect
(
browser
).
toDisplayRedbox
(
`
await
expect
(
browser
).
toDisplayRedbox
(
`
...
@@ -541,8 +545,8 @@ describe('pages/ error recovery', () => {
...
@@ -541,8 +545,8 @@ describe('pages/ error recovery', () => {
"stack": [
"stack": [
"ClassDefault.render index.js (5:11)",
"ClassDefault.render index.js (5:11)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
@@ -564,22 +568,22 @@ describe('pages/ error recovery', () => {
...
@@ -564,22 +568,22 @@ describe('pages/ error recovery', () => {
`
)
`
)
}
else
{
}
else
{
await
expect
(
browser
).
toDisplayRedbox
(
`
await
expect
(
browser
).
toDisplayRedbox
(
`
{
{
"count": 1,
"count": 1,
"description": "Error: nooo",
"description": "Error: nooo",
"environmentLabel": null,
"environmentLabel": null,
"label": "Unhandled Runtime Error",
"label": "Unhandled Runtime Error",
"source": "index.js (5:11) @ ClassDefault.render
"source": "index.js (5:11) @ ClassDefault.render
> 5 | throw new Error('nooo');
> 5 | throw new Error('nooo');
| ^",
| ^",
"stack": [
"stack": [
"ClassDefault.render index.js (5:11)",
"ClassDefault.render index.js (5:11)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
}
}
}
}
})
})
...
@@ -627,6 +631,8 @@ describe('pages/ error recovery', () => {
...
@@ -627,6 +631,8 @@ describe('pages/ error recovery', () => {
`
`
)
)
// TODO(veil): ignore-list Webpack runtime (https://linear.app/vercel/issue/NDX-945)
// TODO(veil): Don't bail in Turbopack for sources outside of the project (https://linear.app/vercel/issue/NDX-944)
// We get an error because Foo didn't import React. Fair.
// We get an error because Foo didn't import React. Fair.
// Somehow we end up with two in React 18 due to React's attempt to recover from this error.
// Somehow we end up with two in React 18 due to React's attempt to recover from this error.
if
(
isReact18
)
{
if
(
isReact18
)
{
...
@@ -642,8 +648,8 @@ describe('pages/ error recovery', () => {
...
@@ -642,8 +648,8 @@ describe('pages/ error recovery', () => {
"stack": [
"stack": [
"Foo Foo.js (3:3)",
"Foo Foo.js (3:3)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
@@ -660,8 +666,8 @@ describe('pages/ error recovery', () => {
...
@@ -660,8 +666,8 @@ describe('pages/ error recovery', () => {
"stack": [
"stack": [
"Foo Foo.js (3:3)",
"Foo Foo.js (3:3)",
"Set.forEach <anonymous> (0:0)",
"Set.forEach <anonymous> (0:0)",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
"
<FIXME-file-protocol>
",
"
${
isTurbopack
?
'<FIXME-file-protocol>'
:
'<FIXME-next-dist-dir>'
}
",
],
],
}
}
`
)
`
)
...
...
test/development/pages-dir/client-navigation/index.test.ts
View file @
059c255c
...
@@ -1482,10 +1482,10 @@ describe('Client Navigation', () => {
...
@@ -1482,10 +1482,10 @@ describe('Client Navigation', () => {
| ^",
| ^",
"stack": [
"stack": [
"eval pages/error-in-the-browser-global-scope.js (2:9)",
"eval pages/error-in-the-browser-global-scope.js (2:9)",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
"<FIXME-
file-protocol
>",
"<FIXME-
next-dist-dir
>",
],
],
}
}
`
)
`
)
...
...
test/e2e/app-dir/non-root-project-monorepo/non-root-project-monorepo.test.ts
View file @
059c255c
...
@@ -171,10 +171,10 @@ describe('non-root-project-monorepo', () => {
...
@@ -171,10 +171,10 @@ describe('non-root-project-monorepo', () => {
expect
(
normalizeStackTrace
(
await
getRedboxCallStack
(
browser
)))
expect
(
normalizeStackTrace
(
await
getRedboxCallStack
(
browser
)))
.
toMatchInlineSnapshot
(
`
.
toMatchInlineSnapshot
(
`
"eval app/separate-file.ts (1:7)
"eval app/separate-file.ts (1:7)
<FIXME-
file-protocol
>
<FIXME-
next-dist-dir
>
<FIXME-
file-protocol
>
<FIXME-
next-dist-dir
>
<FIXME-
file-protocol
>
<FIXME-
next-dist-dir
>
<FIXME-
file-protocol
>
<FIXME-
next-dist-dir
>
innerArrowFunction app/source-maps-ssr/page.tsx (16:3)
innerArrowFunction app/source-maps-ssr/page.tsx (16:3)
innerFunction app/source-maps-ssr/page.tsx (12:3)
innerFunction app/source-maps-ssr/page.tsx (12:3)
Page app/source-maps-ssr/page.tsx (6:5)"
Page app/source-maps-ssr/page.tsx (6:5)"
...
@@ -216,10 +216,10 @@ describe('non-root-project-monorepo', () => {
...
@@ -216,10 +216,10 @@ describe('non-root-project-monorepo', () => {
expect
(
normalizeStackTrace
(
await
getRedboxCallStack
(
browser
)))
expect
(
normalizeStackTrace
(
await
getRedboxCallStack
(
browser
)))
.
toMatchInlineSnapshot
(
`
.
toMatchInlineSnapshot
(
`
"eval app/separate-file.ts (1:7)
"eval app/separate-file.ts (1:7)
<FIXME-
file-protocol
>
<FIXME-
next-dist-dir
>
<FIXME-
file-protocol
>
<FIXME-
next-dist-dir
>
<FIXME-
file-protocol
>
<FIXME-
next-dist-dir
>
<FIXME-
file-protocol
>
<FIXME-
next-dist-dir
>
innerArrowFunction app/source-maps-client/page.tsx (17:3)
innerArrowFunction app/source-maps-client/page.tsx (17:3)
innerFunction app/source-maps-client/page.tsx (13:3)
innerFunction app/source-maps-client/page.tsx (13:3)
effectCallback app/source-maps-client/page.tsx (7:5)"
effectCallback app/source-maps-client/page.tsx (7:5)"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment