Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
0714c457
Unverified
Commit
0714c457
authored
Nov 19, 2024
by
Tobias Koppers
Committed by
GitHub
Nov 19, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[Turbopack] fix effects tracing (#72928)
### What? small follow-up to fix the tracing of Effects::apply
parent
fe5ef9bb
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
5 deletions
+9
-5
effect.rs
turbopack/crates/turbo-tasks/src/effect.rs
+9
-5
No files found.
turbopack/crates/turbo-tasks/src/effect.rs
View file @
0714c457
...
@@ -174,12 +174,16 @@ impl Eq for Effects {}
...
@@ -174,12 +174,16 @@ impl Eq for Effects {}
impl
Effects
{
impl
Effects
{
/// Applies all effects that have been captured by this struct.
/// Applies all effects that have been captured by this struct.
pub
async
fn
apply
(
&
self
)
->
Result
<
()
>
{
pub
async
fn
apply
(
&
self
)
->
Result
<
()
>
{
let
_span
=
tracing
::
info_span!
(
"apply effects"
,
count
=
self
.effects
.len
());
let
span
=
tracing
::
info_span!
(
"apply effects"
,
count
=
self
.effects
.len
());
let
mut
first_error
=
anyhow
::
Ok
(());
async
move
{
for
effect
in
self
.effects
.iter
()
{
let
mut
first_error
=
anyhow
::
Ok
(());
apply_effect
(
effect
,
&
mut
first_error
)
.await
;
for
effect
in
self
.effects
.iter
()
{
apply_effect
(
effect
,
&
mut
first_error
)
.await
;
}
first_error
}
}
first_error
.instrument
(
span
)
.await
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment