Add criteria for Vercel Agent code review (#100846)
Adds the criteria Vercel Agent will use to review Next.js team PRs, and
to decide whether to approve them or escalate to an area owner.
Automated approvals will only run for members of the Vercel GitHub org
who are also on an allowlist of core Next.js contributors.
REVIEW.md is the main entry point for the agent. (A suggestion to the
human reviewing this review procedure: imagine you're an agent and open
that file.) It describes the protocol, then routes the agent to the
appropriate tools and documents needed to conduct its review.
I asked an agent to analyze the codebase and split it into areas with
different owners. Each area can have its own review criteria. The
initial set of areas and owners is just a starting point. Please submit
changes, I know some of them will be wrong! The area-specific review
criteria are also mostly empty.
I seeded the agent with a starting set of "core" criteria. These are
also not set in stone. I collected them from our existing skills and my
own institutional knowledge of our team's practices. Please submit
changes if you disagree with any, or want to propose more.
**It's expected that the initial version of the review procedure will
need significant tuning.** I ran some lightweight evals on historical
PRs to check its effectiveness. We will continue to do this on a regular
basis. The goal is for 90%+ of code reviews to result in the correct
signal.
**A human is still required for merge.** We are going from 2 humans in
the loop to 1. Not 0. The quality of a PR is ultimately the
responsibility of its merger and author.
Be extra rigorous and vigilant as we iterate on this new review
procedure.
Refer to REVIEW.md for full details.
---------
Co-authored-by:
Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
Showing
REVIEW.md
0 → 100644
This diff is collapsed.
review/OWNERS
0 → 100644
This diff is collapsed.
review/README.md
0 → 100644
review/areas/_template.md
0 → 100644
review/areas/dev-overlay.md
0 → 100644
review/areas/docs.md
0 → 100644
review/areas/next-codemod.md
0 → 100644
review/areas/next-font.md
0 → 100644
review/areas/pages-router.md
0 → 100644
review/areas/test-infra.md
0 → 100644
review/areas/turbo-tasks.md
0 → 100644
review/areas/use-cache.md
0 → 100644
review/rule-changes.md
0 → 100644
review/rules/no-drive-bys.md
0 → 100644
review/rules/page-weight.md
0 → 100644
scripts/review-context.mjs
0 → 100644
This diff is collapsed.
Please
register
or
sign in
to comment