Commit 08f241fc authored by Joe Haddad's avatar Joe Haddad Committed by JJ Kasper

Switch from `defer` to `async` (#10143)

parent 53d5bd89
......@@ -570,7 +570,7 @@ export class NextScript extends Component<OriginProps> {
return (
<script
defer
async
key={bundle.file}
src={`${assetPrefix}/_next/${encodeURI(
bundle.file
......@@ -611,7 +611,7 @@ export class NextScript extends Component<OriginProps> {
file
)}${_devOnlyInvalidateCacheQueryString}`}
nonce={this.props.nonce}
defer
async
crossOrigin={this.props.crossOrigin || process.crossOrigin}
{...modernProps}
/>
......@@ -720,7 +720,7 @@ export class NextScript extends Component<OriginProps> {
const pageScript = [
<script
defer
async
data-next-page={page}
key={page}
src={
......@@ -734,7 +734,7 @@ export class NextScript extends Component<OriginProps> {
/>,
process.env.__NEXT_MODERN_BUILD && (
<script
defer
async
data-next-page={page}
key={`${page}-modern`}
src={
......@@ -753,7 +753,7 @@ export class NextScript extends Component<OriginProps> {
const appScript = [
<script
defer
async
data-next-page="/_app"
src={
assetPrefix +
......@@ -767,7 +767,7 @@ export class NextScript extends Component<OriginProps> {
/>,
process.env.__NEXT_MODERN_BUILD && (
<script
defer
async
data-next-page="/_app"
src={
assetPrefix +
......
......@@ -678,13 +678,13 @@ describe('Production Usage', () => {
}
})
it('should have defer on all script tags', async () => {
it('should have async on all script tags', async () => {
const html = await renderViaHTTP(appPort, '/')
const $ = cheerio.load(html)
let missing = false
for (const script of $('script').toArray()) {
// application/json doesn't need defer
// application/json doesn't need async
if (
script.attribs.type === 'application/json' ||
script.attribs.src.includes('polyfills')
......@@ -692,7 +692,7 @@ describe('Production Usage', () => {
continue
}
if (script.attribs.async === '' || script.attribs.defer !== '') {
if (script.attribs.defer === '' || script.attribs.async !== '') {
missing = true
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment