Unverified Commit 0d80b113 authored by Eric Matthys's avatar Eric Matthys Committed by GitHub

Warn when building a TS project with composite: true and fallback to incremental (#35270)

* Warn when building a TS project with composite: true and fallback to incremental

* lint-fix
Co-authored-by: 's avatarJJ Kasper <jj@jjsweb.site>
parent fb23f7b6
...@@ -7,6 +7,7 @@ import { getTypeScriptConfiguration } from './getTypeScriptConfiguration' ...@@ -7,6 +7,7 @@ import { getTypeScriptConfiguration } from './getTypeScriptConfiguration'
import { getRequiredConfiguration } from './writeConfigurationDefaults' import { getRequiredConfiguration } from './writeConfigurationDefaults'
import { CompileError } from '../compile-error' import { CompileError } from '../compile-error'
import { warn } from '../../build/output/log'
export interface TypeCheckResult { export interface TypeCheckResult {
hasWarnings: boolean hasWarnings: boolean
...@@ -40,6 +41,8 @@ export async function runTypeCheck( ...@@ -40,6 +41,8 @@ export async function runTypeCheck(
const options = { const options = {
...effectiveConfiguration.options, ...effectiveConfiguration.options,
...requiredConfig, ...requiredConfig,
declarationMap: false,
emitDeclarationOnly: false,
noEmit: true, noEmit: true,
} }
...@@ -47,12 +50,18 @@ export async function runTypeCheck( ...@@ -47,12 +50,18 @@ export async function runTypeCheck(
| import('typescript').Program | import('typescript').Program
| import('typescript').BuilderProgram | import('typescript').BuilderProgram
let incremental = false let incremental = false
if (options.incremental && cacheDir) { if ((options.incremental || options.composite) && cacheDir) {
if (options.composite) {
warn(
'TypeScript project references are not fully supported. Attempting to build in incremental mode.'
)
}
incremental = true incremental = true
program = ts.createIncrementalProgram({ program = ts.createIncrementalProgram({
rootNames: effectiveConfiguration.fileNames, rootNames: effectiveConfiguration.fileNames,
options: { options: {
...options, ...options,
composite: false,
incremental: true, incremental: true,
tsBuildInfoFile: path.join(cacheDir, '.tsbuildinfo'), tsBuildInfoFile: path.join(cacheDir, '.tsbuildinfo'),
}, },
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment