Unverified Commit 1058090c authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Update Turbopack workflows to have clearer names (#63407)

## What?

Small refactor to make it clearer what workflow uploads to
areweturboyet, what workflow runs tests, and what workflow runs daily.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-2836
parent 049d127e
# A workflow to run next.js integration test with turbopack for each day.
# This runs against main branch with latest Next.js release.
name: Daily Next.js integration test with turbopack
name: Daily Next.js integration test with Turbopack
on:
schedule:
......@@ -26,10 +26,8 @@ jobs:
version: ${{ inputs.version || 'canary' }}
# Upload test results to KV, but only for scheduled runs.
upload_test_results:
name: Upload test results
needs: [next_js_integration]
# if: github.repository_owner == 'vercel' && ${{ github.event_name == 'schedule' }} && always()
if: always()
uses: ./.github/workflows/upload-nextjs-integration-test-results.yml
upload_turbopack_tests_manifest:
name: Upload Turbopack tests manifest to areweturboyet.com
if: ${{ !cancelled() }}
uses: ./.github/workflows/turbopack-upload-tests-manifest.yml
secrets: inherit
......@@ -3,19 +3,7 @@
#
# Refer test.yml for how this workflow is being initialized
# - Workflow can specify `inputs.version` to specify which version of next.js to use, otherwise will use latest release version.
name: Turbopack Next.js integration test
on:
workflow_call:
inputs:
# Allow to specify Next.js version to run integration test against.
# If not specified, will use latest release version including canary.
version:
type: string
# The base of the test results to compare against. If not specified, will try to compare with latest main branch's test results.
diff_base:
type: string
default: 'main'
name: Turbopack Next.js integration tests
# Workflow-common env variables
env:
......@@ -180,7 +168,7 @@ jobs:
- 'x64'
- 'metal'
if: always()
if: ${{ !cancelled() }}
steps:
- name: Download test report artifacts
id: download-test-reports
......
......@@ -4,7 +4,7 @@ name: Update Turbopack test manifest
on:
schedule:
# Every day at 9AM https://crontab.guru/#0_9_*_*_*
- cron: '0 9 * * *'
- cron: '0 7 * * *'
workflow_dispatch:
jobs:
......
# Reusable workflow to upload next.js integration test results to KV for https://areweturboyet.com/
# This workflow assumes the `next-integration-test` workflow has been executed
# and test reports have been uploaded to the `test-results` artifact.
name: Update next.js integration test results
name: Upload Turbopack tests manifest to areweturboyet.com
on:
workflow_call:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment