Unverified Commit 1112dce6 authored by Sebastian "Sebbie" Silbermann's avatar Sebastian "Sebbie" Silbermann Committed by GitHub

[dev-overlay] Never dedupe errors with different names or messages (#84908)

parent c6a6c736
...@@ -324,6 +324,9 @@ export function useErrorOverlayReducer( ...@@ -324,6 +324,9 @@ export function useErrorOverlayReducer(
const pendingEvents = events.filter((event) => { const pendingEvents = events.filter((event) => {
// Filter out duplicate errors // Filter out duplicate errors
return ( return (
// SpiderMonkey and JavaScriptCore don't include the error message in the stack.
// We don't want to dedupe errors with different messages for which we don't have a good stack
'' + event.error !== '' + pendingEvent.error ||
(event.error.stack !== pendingEvent.error.stack && (event.error.stack !== pendingEvent.error.stack &&
// TODO: Let ReactDevTools control deduping instead? // TODO: Let ReactDevTools control deduping instead?
getStackIgnoringStrictMode(event.error.stack) !== getStackIgnoringStrictMode(event.error.stack) !==
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment