Unverified Commit 14e58aee authored by Zack Tanner's avatar Zack Tanner Committed by GitHub

[dev-overlay]: use proper labels for preferences (#76558)

Uses `label` rather than `h2` for preference options for better
accessibility.
parent 78ac4e2e
...@@ -68,7 +68,7 @@ export function UserPreferences({ ...@@ -68,7 +68,7 @@ export function UserPreferences({
<div className="preferences-container"> <div className="preferences-container">
<div className="preference-section"> <div className="preference-section">
<div className="preference-header"> <div className="preference-header">
<h2>Theme</h2> <label htmlFor="theme">Theme</label>
<p className="preference-description"> <p className="preference-description">
Select your theme preference. Select your theme preference.
</p> </p>
...@@ -78,6 +78,8 @@ export function UserPreferences({ ...@@ -78,6 +78,8 @@ export function UserPreferences({
<ThemeIcon theme={theme as 'dark' | 'light' | 'system'} /> <ThemeIcon theme={theme as 'dark' | 'light' | 'system'} />
</div> </div>
<select <select
id="theme"
name="theme"
className="select-button" className="select-button"
value={theme} value={theme}
onChange={handleThemeChange} onChange={handleThemeChange}
...@@ -91,13 +93,15 @@ export function UserPreferences({ ...@@ -91,13 +93,15 @@ export function UserPreferences({
<div className="preference-section"> <div className="preference-section">
<div className="preference-header"> <div className="preference-header">
<h2>Position</h2> <label htmlFor="position">Position</label>
<p className="preference-description"> <p className="preference-description">
Adjust the placement of your dev tools. Adjust the placement of your dev tools.
</p> </p>
</div> </div>
<div className="preference-control-select"> <div className="preference-control-select">
<select <select
id="position"
name="position"
className="select-button" className="select-button"
value={position} value={position}
onChange={handlePositionChange} onChange={handlePositionChange}
...@@ -112,13 +116,17 @@ export function UserPreferences({ ...@@ -112,13 +116,17 @@ export function UserPreferences({
<div className="preference-section"> <div className="preference-section">
<div className="preference-header"> <div className="preference-header">
<h2>Hide Dev Tools for this session</h2> <label htmlFor="hide-dev-tools">
Hide Dev Tools for this session
</label>
<p className="preference-description"> <p className="preference-description">
Hide Dev Tools until you restart your dev server, or 1 day. Hide Dev Tools until you restart your dev server, or 1 day.
</p> </p>
</div> </div>
<div className="preference-control"> <div className="preference-control">
<button <button
id="hide-dev-tools"
name="hide-dev-tools"
data-hide-dev-tools data-hide-dev-tools
className="action-button" className="action-button"
onClick={hide} onClick={hide}
...@@ -133,7 +141,7 @@ export function UserPreferences({ ...@@ -133,7 +141,7 @@ export function UserPreferences({
<div className="preference-section"> <div className="preference-section">
<div className="preference-header"> <div className="preference-header">
<h2>Disable Dev Tools for this project</h2> <label>Disable Dev Tools for this project</label>
<p className="preference-description"> <p className="preference-description">
To disable this UI completely, set{' '} To disable this UI completely, set{' '}
<code className="dev-tools-info-code">devIndicators: false</code>{' '} <code className="dev-tools-info-code">devIndicators: false</code>{' '}
...@@ -194,7 +202,7 @@ export const DEV_TOOLS_INFO_USER_PREFERENCES_STYLES = css` ...@@ -194,7 +202,7 @@ export const DEV_TOOLS_INFO_USER_PREFERENCES_STYLES = css`
flex: 1; flex: 1;
} }
.preference-header h2 { .preference-header label {
font-size: var(--size-14); font-size: var(--size-14);
font-weight: 500; font-weight: 500;
color: var(--color-gray-1000); color: var(--color-gray-1000);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment