Unverified Commit 1565d634 authored by Alex Carpenter's avatar Alex Carpenter Committed by GitHub

refactor: Improve templates layout flexibility (#89245)

### What

Switches the `create-next-app` templates (`app-tw`, `app`) to flex-based
layouts instead of `min-height: 100vh`.

### Why

At Clerk, we ship a template on top of `create-next-app` that adds a
header with sign-in/sign-up links to the root layout. The current
`min-height: 100vh` approach causes overflow as soon as you add anything
to the layout.

Here's a [minimal repo showing the overflow
issue](https://github.com/alexcarpenter/nextjs-layout-template-repo).

Using flexbox lets the page fill remaining space naturally, so
headers/footers don't force an overflow and avoids us having to modify
the `page.tsx` template.

### Changes

**Tailwind (`app-tw`):**
- Layout: `h-full` on `<html>`, `min-h-full flex flex-col` on `<body>`
- Page: `min-h-screen` → `flex flex-col flex-1`

**CSS Modules (`app`):**
- `globals.css`: `height: 100%` on html, `min-height: 100%; display:
flex; flex-direction: column` on body
- `page.module.css`: `min-height: 100vh` → `flex: 1`

The empty templates (`app-empty`, `app-tw-empty`) don't have height
styling so they're unchanged.

| BEFORE | AFTER |
|--------|--------|
| <img width="1392" height="1522" alt="Screenshot 2026-01-29 at 9 41
58 AM"
src="https://github.com/user-attachments/assets/6642de41-253b-42c0-af2d-d55c4e651541"
/> | <img width="1392" height="1522" alt="Screenshot 2026-01-29 at 9 42
31 AM"
src="https://github.com/user-attachments/assets/633f3d46-ed8c-4d05-8173-77f2cf166703"
/> |

Closes NEXT-
Fixes #
parent 2b0edf62
...@@ -18,9 +18,9 @@ export const metadata = { ...@@ -18,9 +18,9 @@ export const metadata = {
export default function RootLayout({ children }) { export default function RootLayout({ children }) {
return ( return (
<html lang="en"> <html lang="en" className="h-full">
<body <body
className={`${geistSans.variable} ${geistMono.variable} antialiased`} className={`${geistSans.variable} ${geistMono.variable} antialiased min-h-full flex flex-col`}
> >
{children} {children}
</body> </body>
......
...@@ -2,8 +2,8 @@ import Image from "next/image"; ...@@ -2,8 +2,8 @@ import Image from "next/image";
export default function Home() { export default function Home() {
return ( return (
<div className="flex min-h-screen items-center justify-center bg-zinc-50 font-sans dark:bg-black"> <div className="flex flex-col flex-1 items-center justify-center bg-zinc-50 font-sans dark:bg-black">
<main className="flex min-h-screen w-full max-w-3xl flex-col items-center justify-between py-32 px-16 bg-white dark:bg-black sm:items-start"> <main className="flex flex-1 w-full max-w-3xl flex-col items-center justify-between py-32 px-16 bg-white dark:bg-black sm:items-start">
<Image <Image
className="dark:invert" className="dark:invert"
src="/next.svg" src="/next.svg"
......
...@@ -23,9 +23,9 @@ export default function RootLayout({ ...@@ -23,9 +23,9 @@ export default function RootLayout({
children: React.ReactNode; children: React.ReactNode;
}>) { }>) {
return ( return (
<html lang="en"> <html lang="en" className="h-full">
<body <body
className={`${geistSans.variable} ${geistMono.variable} antialiased`} className={`${geistSans.variable} ${geistMono.variable} antialiased min-h-full flex flex-col`}
> >
{children} {children}
</body> </body>
......
...@@ -2,8 +2,8 @@ import Image from "next/image"; ...@@ -2,8 +2,8 @@ import Image from "next/image";
export default function Home() { export default function Home() {
return ( return (
<div className="flex min-h-screen items-center justify-center bg-zinc-50 font-sans dark:bg-black"> <div className="flex flex-col flex-1 items-center justify-center bg-zinc-50 font-sans dark:bg-black">
<main className="flex min-h-screen w-full max-w-3xl flex-col items-center justify-between py-32 px-16 bg-white dark:bg-black sm:items-start"> <main className="flex flex-1 w-full max-w-3xl flex-col items-center justify-between py-32 px-16 bg-white dark:bg-black sm:items-start">
<Image <Image
className="dark:invert" className="dark:invert"
src="/next.svg" src="/next.svg"
......
...@@ -10,6 +10,10 @@ ...@@ -10,6 +10,10 @@
} }
} }
html {
height: 100%;
}
html, html,
body { body {
max-width: 100vw; max-width: 100vw;
...@@ -17,6 +21,9 @@ body { ...@@ -17,6 +21,9 @@ body {
} }
body { body {
min-height: 100%;
display: flex;
flex-direction: column;
color: var(--foreground); color: var(--foreground);
background: var(--background); background: var(--background);
font-family: Arial, Helvetica, sans-serif; font-family: Arial, Helvetica, sans-serif;
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
--button-secondary-border: #ebebeb; --button-secondary-border: #ebebeb;
display: flex; display: flex;
min-height: 100vh; flex: 1;
flex-direction: column;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
font-family: var(--font-geist-sans); font-family: var(--font-geist-sans);
...@@ -19,7 +20,7 @@ ...@@ -19,7 +20,7 @@
.main { .main {
display: flex; display: flex;
min-height: 100vh; flex: 1;
width: 100%; width: 100%;
max-width: 800px; max-width: 800px;
flex-direction: column; flex-direction: column;
......
...@@ -10,6 +10,10 @@ ...@@ -10,6 +10,10 @@
} }
} }
html {
height: 100%;
}
html, html,
body { body {
max-width: 100vw; max-width: 100vw;
...@@ -17,6 +21,9 @@ body { ...@@ -17,6 +21,9 @@ body {
} }
body { body {
min-height: 100%;
display: flex;
flex-direction: column;
color: var(--foreground); color: var(--foreground);
background: var(--background); background: var(--background);
font-family: Arial, Helvetica, sans-serif; font-family: Arial, Helvetica, sans-serif;
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
--button-secondary-border: #ebebeb; --button-secondary-border: #ebebeb;
display: flex; display: flex;
min-height: 100vh; flex: 1;
flex-direction: column;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
font-family: var(--font-geist-sans); font-family: var(--font-geist-sans);
...@@ -19,7 +20,7 @@ ...@@ -19,7 +20,7 @@
.main { .main {
display: flex; display: flex;
min-height: 100vh; flex: 1;
width: 100%; width: 100%;
max-width: 800px; max-width: 800px;
flex-direction: column; flex-direction: column;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment