Unverified Commit 1602c2af authored by Nick McCurdy's avatar Nick McCurdy Committed by GitHub

Fix pnpm `ERR_INVALID_THIS` on Node 20 (#51406)

### What?

Fixes pnpm/pnpm#6424

### Why?

So users of Node 20 can contribute to Next.js

### How?

Upgrades pnpm with back compatibility to patch `ERR_INVALID_THIS` error.
If Node 14 support isn't necessary, I'd recommend upgrading to pnpm 8
for continued feature support and committing the lockfile.

---------
Co-authored-by: 's avatarJJ Kasper <jj@jjsweb.site>
parent d6952989
...@@ -14,7 +14,7 @@ RUN ln $(which python3) /usr/bin/python ...@@ -14,7 +14,7 @@ RUN ln $(which python3) /usr/bin/python
RUN curl -sfLS https://install-node.vercel.app/v18 | bash -s -- -f RUN curl -sfLS https://install-node.vercel.app/v18 | bash -s -- -f
# Install node_modules # Install node_modules
RUN npm i -g pnpm@7.24.3 yarn@1.22.19 RUN npm i -g pnpm@7.32.2 yarn@1.22.19
RUN cd /next-stats && pnpm install --production RUN cd /next-stats && pnpm install --production
RUN git config --global user.email 'stats@localhost' RUN git config --global user.email 'stats@localhost'
......
...@@ -8,7 +8,7 @@ on: ...@@ -8,7 +8,7 @@ on:
env: env:
NAPI_CLI_VERSION: 2.14.7 NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18
......
...@@ -9,7 +9,7 @@ on: ...@@ -9,7 +9,7 @@ on:
env: env:
NAPI_CLI_VERSION: 2.14.7 NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18
TEST_CONCURRENCY: 6 TEST_CONCURRENCY: 6
......
...@@ -47,7 +47,7 @@ on: ...@@ -47,7 +47,7 @@ on:
env: env:
NAPI_CLI_VERSION: 2.14.7 NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18
TEST_CONCURRENCY: 6 TEST_CONCURRENCY: 6
......
...@@ -7,7 +7,7 @@ name: Generate Pull Request Stats ...@@ -7,7 +7,7 @@ name: Generate Pull Request Stats
env: env:
NAPI_CLI_VERSION: 2.14.7 NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18
TEST_CONCURRENCY: 6 TEST_CONCURRENCY: 6
......
...@@ -14,7 +14,7 @@ on: ...@@ -14,7 +14,7 @@ on:
name: Test examples name: Test examples
env: env:
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.32.2
jobs: jobs:
testExamples: testExamples:
......
...@@ -26,7 +26,7 @@ name: Trigger Release ...@@ -26,7 +26,7 @@ name: Trigger Release
env: env:
NAPI_CLI_VERSION: 2.14.7 NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18
......
...@@ -33,7 +33,7 @@ pr: ...@@ -33,7 +33,7 @@ pr:
variables: variables:
PNPM_CACHE_FOLDER: $(Pipeline.Workspace)/.pnpm-store PNPM_CACHE_FOLDER: $(Pipeline.Workspace)/.pnpm-store
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.32.2
NEXT_TELEMETRY_DISABLED: '1' NEXT_TELEMETRY_DISABLED: '1'
node_16_version: ^16.8.0 node_16_version: ^16.8.0
......
...@@ -51,7 +51,7 @@ ...@@ -51,7 +51,7 @@
"clean-trace-jaeger": "node scripts/rm.mjs test/integration/basic/.next && TRACE_TARGET=JAEGER pnpm next build test/integration/basic", "clean-trace-jaeger": "node scripts/rm.mjs test/integration/basic/.next && TRACE_TARGET=JAEGER pnpm next build test/integration/basic",
"debug": "cross-env NEXT_TELEMETRY_DISABLED=1 node --inspect packages/next/dist/bin/next", "debug": "cross-env NEXT_TELEMETRY_DISABLED=1 node --inspect packages/next/dist/bin/next",
"postinstall": "git config index.skipHash false && node scripts/install-native.mjs", "postinstall": "git config index.skipHash false && node scripts/install-native.mjs",
"version": "npx pnpm@7.24.3 install --no-frozen-lockfile && IS_PUBLISH=yes ./scripts/check-pre-compiled.sh && git add .", "version": "npx pnpm@7.32.2 install --no-frozen-lockfile && IS_PUBLISH=yes ./scripts/check-pre-compiled.sh && git add .",
"prepare": "husky install", "prepare": "husky install",
"sync-react": "node ./scripts/sync-react.js", "sync-react": "node ./scripts/sync-react.js",
"update-google-fonts": "node ./scripts/update-google-fonts.js" "update-google-fonts": "node ./scripts/update-google-fonts.js"
...@@ -239,5 +239,5 @@ ...@@ -239,5 +239,5 @@
"engines": { "engines": {
"node": ">=16.8.0" "node": ">=16.8.0"
}, },
"packageManager": "pnpm@7.24.3" "packageManager": "pnpm@7.32.2"
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment