Unverified Commit 1717fd2d authored by Shu Ding's avatar Shu Ding Committed by GitHub

Fix IntelliSense for generateMetadata (#46624)

Related to #46431, this makes sure the IntelliSense for both sync and async `generateMetadata` is correct.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
parent fcfab172
...@@ -158,7 +158,10 @@ function updateVirtualFileWithType( ...@@ -158,7 +158,10 @@ function updateVirtualFileWithType(
if (ts.isFunctionDeclaration(node)) { if (ts.isFunctionDeclaration(node)) {
if (isGenerateMetadata) { if (isGenerateMetadata) {
nodeEnd = node.body!.getFullStart() nodeEnd = node.body!.getFullStart()
annotation = TYPE_ANOTATION_ASYNC const isAsync = node.modifiers?.some(
(m) => m.kind === ts.SyntaxKind.AsyncKeyword
)
annotation = isAsync ? TYPE_ANOTATION_ASYNC : TYPE_ANOTATION
} else { } else {
return return
} }
......
export default function Page() {
return null
}
export async function generateMetadata() {
return {
title: 'foo',
}
}
export default function Page() {
return null
}
export function generateMetadata() {
return {
title: 'foo',
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment