Unverified Commit 182a4b44 authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

reduce function calls in walk (#59332)

### What?

Reduce the number of function calls

### Why?

Performance on incremental builds

### How?


Closes PACK-2104
parent f6ebc2be
......@@ -12,7 +12,7 @@ use turbo_tasks::{
};
use turbopack_binding::turbopack::core::{
module::{Module, Modules},
reference::ModuleReference,
reference::primary_referenced_modules,
};
use super::{
......@@ -179,21 +179,9 @@ impl Visit<VisitClientReferenceNode> for VisitClientReference {
// nodes' edges.
VisitClientReferenceNodeType::ClientReference(..) => Ok(vec![]),
VisitClientReferenceNodeType::Internal(module, _) => {
let references = module.references().await?;
let referenced_modules = primary_referenced_modules(module).await?;
let referenced_modules = references
.iter()
.copied()
.map(|reference| async move {
let resolve_result = reference.resolve_reference();
let assets = resolve_result.primary_modules().await?;
Ok(assets.clone_value())
})
.try_join()
.await?;
let referenced_modules = referenced_modules.into_iter().flatten();
let referenced_modules = referenced_modules.map(|module| async move {
let referenced_modules = referenced_modules.iter().map(|module| async move {
let module = module.resolve().await?;
if let Some(client_reference_module) =
Vc::try_resolve_downcast_type::<EcmascriptClientReferenceModule>(module)
......
......@@ -8,7 +8,7 @@ use turbo_tasks::{
};
use turbopack_binding::turbopack::core::{
module::{Module, Modules},
reference::ModuleReference,
reference::primary_referenced_modules,
};
use super::NextDynamicEntryModule;
......@@ -89,21 +89,9 @@ impl Visit<VisitDynamicNode> for VisitDynamic {
VisitDynamicNode::Internal(module, _) => module,
};
let references = module.references().await?;
let referenced_modules = references
.iter()
.copied()
.map(|reference| async move {
let resolve_result = reference.resolve_reference();
let assets = resolve_result.primary_modules().await?;
Ok(assets.clone_value())
})
.try_join()
.await?;
let referenced_modules = referenced_modules.into_iter().flatten();
let referenced_modules = referenced_modules.map(|module| async move {
let referenced_modules = primary_referenced_modules(module).await?;
let referenced_modules = referenced_modules.iter().map(|module| async move {
let module = module.resolve().await?;
if let Some(next_dynamic_module) =
Vc::try_resolve_downcast_type::<NextDynamicEntryModule>(module).await?
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment