Unverified Commit 1840942d authored by Sebastian "Sebbie" Silbermann's avatar Sebastian "Sebbie" Silbermann Committed by GitHub

next-upgrade: Ensure highest versions are used not latest (#73566)

parent 26d00a51
......@@ -3,3 +3,32 @@ Suggests adding `--turbopack` to `next dev` script
Suggests `app-dir-runtime-config-experimental-edge` transform
Suggests `next-async-request-api` transform
Suggests `next-request-geo-ip` transform
```diff
diff --git a/packages/next-codemod/bin/__testfixtures__/next-14-installed/package.json b/packages/next-codemod/bin/__testfixtures__/next-14-installed/package.json
index 5ec4c37f0b..131f5b9f4a 100644
--- a/packages/next-codemod/bin/__testfixtures__/next-14-installed/package.json
+++ b/packages/next-codemod/bin/__testfixtures__/next-14-installed/package.json
@@ -4,10 +4,16 @@
"dev": "next dev"
},
"dependencies": {
- "next": "14.3.0-canary.44",
- "react": "18.2.0",
- "react-dom": "18.2.0",
- "@types/react": "^18.2.0",
- "@types/react-dom": "^18.2.0"
+ "next": "15.0.4-canary.43",
+ "react": "19.0.0",
+ "react-dom": "19.0.0",
+ "@types/react": "19.0.0",
+ "@types/react-dom": "19.0.0"
+ },
+ "pnpm": {
+ "overrides": {
+ "@types/react": "19.0.0",
+ "@types/react-dom": "19.0.0"
+ }
}
}
```
......@@ -6,6 +6,8 @@
"dependencies": {
"next": "14.3.0-canary.44",
"react": "18.2.0",
"react-dom": "18.2.0"
"react-dom": "18.2.0",
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0"
}
}
......@@ -53,6 +53,8 @@ async function loadHighestNPMVersionMatching(query: string) {
// npm-view returns an array if there are multiple versions matching the query.
if (Array.isArray(versionOrVersions)) {
// The last entry will be the latest version published.
// But we want the highest version.
versionOrVersions.sort(compareVersions)
return versionOrVersions[versionOrVersions.length - 1]
}
return versionOrVersions
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment